Paths

Table of Contentst

Differential D31422

tcp, udp: improve input validation in bind()
ClosedPublic
Actions

Authored by tuexen on Aug 5 2021, 11:03 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jul 3, 9:45 PM

	Unknown Object (File)
	Thu, Jul 3, 8:55 AM

	Unknown Object (File)
	Wed, Jul 2, 6:43 AM

	Unknown Object (File)
	Tue, Jul 1, 6:12 AM

	Unknown Object (File)
	Mon, Jun 23, 11:57 PM

	Unknown Object (File)
	Sun, Jun 22, 2:53 PM

	Unknown Object (File)
	Fri, Jun 20, 6:13 AM

	Unknown Object (File)
	Fri, Jun 13, 4:01 AM

View All 68 Files

Subscribers

Details

Reviewers

markj
rscheff
rrs

Group Reviewers

Commits

rGdb8fc0ef23d1: tcp, udp: improve input validation in handling bind()
rG3f1f6b6ef7f6: tcp, udp: improve input validation in handling bind()

Summary

This fixes:

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

tuexen created this revision.Aug 5 2021, 11:03 AM

Herald added a reviewer: transport. · View Herald TranscriptAug 5 2021, 11:03 AM

Herald added a subscriber: melifaro. · View Herald Transcript

tuexen requested review of this revision.Aug 5 2021, 11:03 AM

tuexen added reviewers: rscheff, rrs.

lgtm

This revision is now accepted and ready to land.Aug 5 2021, 11:08 AM

Thank you.

sys/netinet/tcp_usrreq.c
329	I would just check `nam->sa_len != sizeof(*sinp)` since we perform that exact check again below. This is ok though.

tuexen marked an inline comment as done.Aug 5 2021, 1:04 PM

tuexen added inline comments.

sys/netinet/tcp_usrreq.c
329	I was considering that or even just do the check for `sa_len` before the check for `sa_family`. I decided to do it this way to report `EINVAL` if `sa_len` is not correct as often as possible.

Closed by commit rG3f1f6b6ef7f6: tcp, udp: improve input validation in handling bind() (authored by tuexen). · Explain WhyAug 5 2021, 1:12 PM

This revision was automatically updated to reflect the committed changes.

tuexen marked an inline comment as done.

tuexen added a commit: rG3f1f6b6ef7f6: tcp, udp: improve input validation in handling bind().

tuexen added a commit: rGdb8fc0ef23d1: tcp, udp: improve input validation in handling bind().Feb 22 2022, 10:28 PM

Herald added subscribers: glebius, imp. · View Herald TranscriptFeb 22 2022, 10:28 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

1 line

1 line

Diff 93266

sys/netinet/tcp_usrreq.c

Loading...

sys/netinet/udp_usrreq.c

Loading...