link_elf_obj: Invoke fini callbacks
ClosedPublic
Actions

Authored by markj on Jul 28 2021, 9:01 PM.

Details

Reviewers

Commits

rG9e575fadf491: link_elf_obj: Invoke fini callbacks

Summary

This is required for KASAN: when a module is unloaded, poisoned regions
(e.g., pad areas between global variables) are left as such, so if they
are reused as KLDs are loaded, false positives can arise.

Reported by: pho
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jul 28 2021, 9:01 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 28 2021, 9:01 PM

Harbormaster completed remote builds in B40732: Diff 92906.Jul 28 2021, 9:01 PM

markj requested review of this revision.Jul 28 2021, 9:01 PM

Is the same handling needed for link_elf.c?

This revision is now accepted and ready to land.Jul 29 2021, 12:32 AM

In D31339#706113, @kib wrote:

Is the same handling needed for link_elf.c?

Yes, I just didn't do it since I don't have a good way to test yet. I did not implement .init_array support there yet either. I'll revisit this for link_elf when KASAN is ported to arm64, if that's ok with you.

In D31339#706279, @markj wrote:

In D31339#706113, @kib wrote:

Is the same handling needed for link_elf.c?

Yes, I just didn't do it since I don't have a good way to test yet. I did not implement .init_array support there yet either. I'll revisit this for link_elf when KASAN is ported to arm64, if that's ok with you.