Page MenuHomeFreeBSD

bhyve: Move the gdb_active check to gdb_cpu_suspend().

Authored by jhb on Apr 1 2021, 4:47 PM.
Referenced Files
Unknown Object (File)
Tue, Nov 7, 12:11 PM
Unknown Object (File)
Sep 29 2023, 7:40 PM
Unknown Object (File)
Sep 17 2023, 5:54 AM
Unknown Object (File)
Sep 6 2023, 5:06 AM
Unknown Object (File)
Sep 2 2023, 3:06 AM
Unknown Object (File)
Aug 14 2023, 2:52 PM
Unknown Object (File)
Aug 14 2023, 2:02 AM
Unknown Object (File)
Jul 31 2023, 8:54 PM



The check needs to be in the public routine (gdb_cpu_suspend()), not
in the internal routine called from various places
(_gdb_cpu_suspend()). All the other callers of _gdb_cpu_suspend()
already check gdb_active, and this breaks the use of snapshots when
the debug server is not enabled since gdb_cpu_suspend() tries to lock
an uninitialized mutex.

Reported by: Darius Mihai, Elena Mihailescu
Fixes: 621b5090487de9fed1b503769702a9a2a27cc7bb

Diff Detail

rS FreeBSD src repository - subversion
Lint Passed
No Test Coverage
Build Status
Buildable 38257
Build 35146: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Apr 1 2021, 4:47 PM

We tested the patch and everything seems OK from our part. The fix works as intended. Thanks!

This revision is now accepted and ready to land.Apr 4 2021, 8:53 AM