Page MenuHomeFreeBSD

darius.mihaim_gmail.com (Darius Mihai)
User

Projects

User does not belong to any projects.

User Details

User Since
May 18 2017, 8:41 AM (118 w, 1 d)

Recent Activity

Thu, Aug 1

darius.mihaim_gmail.com added inline comments to D19495: bhyve - Snapshot Save and Restore.
Thu, Aug 1, 3:11 PM · bhyve
darius.mihaim_gmail.com added a comment to D19495: bhyve - Snapshot Save and Restore.
  • integrate updated vCPU pause mechanism from @jhb that uses the VM debug components.
  • separate BSP vCPU initialization from other vCPUs (do not initialize all vCPUs before starting the VM when not restoring; do not automatically grant UNRESTRICTED_GUEST capabilities to BSP)
  • fix various coding errors, such as removing unused macros, using proper buffer size for snprintf and coding style
Thu, Aug 1, 2:46 PM · bhyve

Jul 10 2019

darius.mihaim_gmail.com added a comment to D19495: bhyve - Snapshot Save and Restore.
  • kick the guest threads out of vmrun when starting the pausing vCPUs.
  • remove host registers from intel/vmx.c snapshot process (AMD registers have not been removed yet).
Jul 10 2019, 1:47 PM · bhyve

Jun 27 2019

darius.mihaim_gmail.com added inline comments to D19495: bhyve - Snapshot Save and Restore.
Jun 27 2019, 12:34 PM · bhyve
darius.mihaim_gmail.com added a comment to D19495: bhyve - Snapshot Save and Restore.

Remove some irrelevant comments and unused functions

Jun 27 2019, 12:32 PM · bhyve

Jun 26 2019

darius.mihaim_gmail.com added a comment to D19495: bhyve - Snapshot Save and Restore.

I have applied the feedback @jhb gave, except for the #ifdef guards. Will work on it after rebasing with a newer master.

Jun 26 2019, 10:21 AM · bhyve
darius.mihaim_gmail.com added a comment to D19495: bhyve - Snapshot Save and Restore.
  • rework vCPU pausing and resuming mechanism
  • rewrite VM suspend procedure - do not resume VM and devices before exit
  • add missing break clause in vmm_dev switch-case
  • various minor coding style fixes pointed by @jhb
  • remove unnecessary critical section nesting level check
Jun 26 2019, 9:59 AM · bhyve

Jun 10 2019

darius.mihaim_gmail.com updated the summary of D19495: bhyve - Snapshot Save and Restore.
Jun 10 2019, 6:58 PM · bhyve

Jun 5 2019

darius.mihaim_gmail.com updated the diff for D19495: bhyve - Snapshot Save and Restore.

Remove debug printfs from pci_ahci.c

Jun 5 2019, 3:28 PM · bhyve
darius.mihaim_gmail.com updated the diff for D19495: bhyve - Snapshot Save and Restore.

Remove vLAPIC fields from snapshot procedure, if they are not required after a restore / can be computed from other fields.
Save vLAPIC's LAPIC page as part of vLAPIC snapshot procedure, instead of a separate data structure.
Rename variables / functions / macros used to snapshot guest to host memory mappings to make them more intuitive.

Jun 5 2019, 12:02 PM · bhyve

May 20 2019

darius.mihaim_gmail.com updated the diff for D19495: bhyve - Snapshot Save and Restore.

Add minor fixes to snapshot logic:

  • correct variable used as parameter for 'sizeof' in vatpic.c (the size was correct before, by coincidence)
  • remove a comment that became irrelevant in the past in vhpet.c
  • fix vLAPIC timer reset logic in the off-chance the timer would be periodic and a value of 0 is saved for the counter
May 20 2019, 7:59 AM · bhyve

Apr 9 2019

darius.mihaim_gmail.com added a comment to D19495: bhyve - Snapshot Save and Restore.

This is a very useful feature, thanks for working on that!

Apr 9 2019, 7:50 AM · bhyve

Mar 29 2019

darius.mihaim_gmail.com updated the diff for D19495: bhyve - Snapshot Save and Restore.

Remove some unused code and fix style of comments

Mar 29 2019, 9:03 AM · bhyve

Mar 15 2019

darius.mihaim_gmail.com updated the diff for D19495: bhyve - Snapshot Save and Restore.
  • remove guest memory mapping device that is currently unused. The device was used to make snapshots faster by creating a separate Copy-on-Write mapping of the guest memory. This approach is not useful for guest suspends, and we may be able to avoid exporting it through a device even for snapshots (will be investigating that approach).
  • remove some unused code
Mar 15 2019, 9:16 AM · bhyve

Mar 10 2019

darius.mihaim_gmail.com added inline comments to D19495: bhyve - Snapshot Save and Restore.
Mar 10 2019, 10:52 AM · bhyve
darius.mihaim_gmail.com updated the diff for D19495: bhyve - Snapshot Save and Restore.

Fix issues pointed by inline comments

Mar 10 2019, 10:47 AM · bhyve

Mar 8 2019

darius.mihaim_gmail.com updated the test plan for D19495: bhyve - Snapshot Save and Restore.
Mar 8 2019, 10:20 AM · bhyve
darius.mihaim_gmail.com added inline comments to D19495: bhyve - Snapshot Save and Restore.
Mar 8 2019, 9:57 AM · bhyve

Mar 7 2019

darius.mihaim_gmail.com created D19495: bhyve - Snapshot Save and Restore.
Mar 7 2019, 4:56 PM · bhyve