Page MenuHomeFreeBSD
Differential D26263

bhyve: Fix build with option BHYVE_SNAPSHOT
ClosedPublic
Actions

Authored by gusev.vitaliy_gmail.com on Sep 1 2020, 9:58 AM.
Tags
Referenced Files
F171028027: D26263.diff
Tue, Sep 8, 6:52 AM
F170994446: D26263.id77740.diff
Tue, Sep 8, 1:59 AM
Unknown Object (File)
Sun, Sep 6, 10:33 AM
Unknown Object (File)
Sun, Sep 6, 10:06 AM
Unknown Object (File)
Sun, Sep 6, 6:16 AM
Unknown Object (File)
Sat, Sep 5, 10:39 AM
Unknown Object (File)
Fri, Sep 4, 10:54 PM
Unknown Object (File)
Fri, Sep 4, 1:51 PM
View All Files
Subscribers
afedorov
bcran
elenamihailescu22_gmail.com
evgueni.gavrilov_itglobal.com
imp
rgrimes
wanpengqian_gmail.com
bhyve

Details

Reviewers
grehan
jhb
darius.mihaim_gmail.com
Group Reviewers
bhyve
Commits
rS366331: bhyve: Fix build with option BHYVE_SNAPSHOT
Summary

ident was replaced with ata_ident in revision 363596

Test Plan

make command completes successfully

Note, this is a part of suspend/resume improvements

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

gusev.vitaliy_gmail.com created this revision.Sep 1 2020, 9:58 AM
Herald added a reviewer: bhyve. · View Herald TranscriptSep 1 2020, 9:58 AM
Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript
gusev.vitaliy_gmail.com requested review of this revision.Sep 1 2020, 9:58 AM
afedorov added a subscriber: afedorov.Sep 1 2020, 10:14 AM
mgrooms_shrew.net edited reviewers, added: darius.mihaim_gmail.com; removed: mgrooms_shrew.net.Sep 3 2020, 5:05 PM
darius.mihaim_gmail.com added a comment.Sep 3 2020, 6:53 PM

This one seems pretty straight-forward.

wanpengqian_gmail.com added a subscriber: wanpengqian_gmail.com.Sep 4 2020, 12:53 AM

Great.
Definitely my fault. I forgot checking the build with SNAPSHOT while doing the modification of ata_ident in D24174

elenamihailescu22_gmail.com added a subscriber: elenamihailescu22_gmail.com.Sep 7 2020, 7:10 AM
evgueni.gavrilov_itglobal.com added a subscriber: evgueni.gavrilov_itglobal.com.Sep 8 2020, 5:30 AM
jhb accepted this revision.Oct 1 2020, 5:14 PM
This revision is now accepted and ready to land.Oct 1 2020, 5:14 PM
Closed by commit rS366331: bhyve: Fix build with option BHYVE_SNAPSHOT (authored by jhb). · Explain WhyOct 1 2020, 5:16 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rS366331: bhyve: Fix build with option BHYVE_SNAPSHOT.

Revision Contents
Changeset List

PathSize
head/
usr.sbin/
bhyve/
2 lines

Diff 77740

View Options

head/usr.sbin/bhyve/pci_ahci.c

Loading...