Page MenuHomeFreeBSD

bhyve: Move the gdb_active check to gdb_cpu_suspend().

Authored by jhb on Apr 1 2021, 4:47 PM.
Referenced Files
Unknown Object (File)
Sat, Mar 4, 9:32 PM
Unknown Object (File)
Sat, Mar 4, 9:40 AM
Unknown Object (File)
Feb 15 2023, 6:39 AM
Unknown Object (File)
Feb 13 2023, 6:18 PM
Unknown Object (File)
Jan 26 2023, 11:06 PM
Unknown Object (File)
Jan 2 2023, 6:03 PM
Unknown Object (File)
Dec 20 2022, 2:06 AM
Unknown Object (File)
Dec 5 2022, 4:31 AM



The check needs to be in the public routine (gdb_cpu_suspend()), not
in the internal routine called from various places
(_gdb_cpu_suspend()). All the other callers of _gdb_cpu_suspend()
already check gdb_active, and this breaks the use of snapshots when
the debug server is not enabled since gdb_cpu_suspend() tries to lock
an uninitialized mutex.

Reported by: Darius Mihai, Elena Mihailescu
Fixes: 621b5090487de9fed1b503769702a9a2a27cc7bb

Diff Detail

rG FreeBSD src repository
Lint Not Applicable
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Apr 1 2021, 4:47 PM

We tested the patch and everything seems OK from our part. The fix works as intended. Thanks!

This revision is now accepted and ready to land.Apr 4 2021, 8:53 AM