Page MenuHomeFreeBSD
Differential D29538

bhyve: Move the gdb_active check to gdb_cpu_suspend().
ClosedPublic
Actions

Authored by jhb on Apr 1 2021, 4:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 4, 9:32 PM
Unknown Object (File)
Sat, Mar 4, 9:40 AM
Unknown Object (File)
Feb 15 2023, 6:39 AM
Unknown Object (File)
Feb 13 2023, 6:18 PM
Unknown Object (File)
Jan 26 2023, 11:06 PM
Unknown Object (File)
Jan 2 2023, 6:03 PM
Unknown Object (File)
Dec 20 2022, 2:06 AM
Unknown Object (File)
Dec 5 2022, 4:31 AM
Subscribers
bcran
emaste
imp
rgrimes

Details

Reviewers
elenamihailescu22_gmail.com
darius.mihaim_gmail.com
Group Reviewers
bhyve
Commits
rG77e736186d8f: bhyve: Move the gdb_active check to gdb_cpu_suspend().
rGeacc27affeff: bhyve: Move the gdb_active check to gdb_cpu_suspend().
Summary

The check needs to be in the public routine (gdb_cpu_suspend()), not
in the internal routine called from various places
(_gdb_cpu_suspend()). All the other callers of _gdb_cpu_suspend()
already check gdb_active, and this breaks the use of snapshots when
the debug server is not enabled since gdb_cpu_suspend() tries to lock
an uninitialized mutex.

Reported by: Darius Mihai, Elena Mihailescu
Fixes: 621b5090487de9fed1b503769702a9a2a27cc7bb

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Apr 1 2021, 4:47 PM
Herald added a reviewer: bhyve. · View Herald TranscriptApr 1 2021, 4:47 PM
Herald added subscribers: bcran, rgrimes, emaste, imp. · View Herald Transcript
jhb requested review of this revision.Apr 1 2021, 4:47 PM
Harbormaster completed remote builds in B38257: Diff 86698.Apr 1 2021, 4:47 PM
jhb added reviewers: elenamihailescu22_gmail.com, darius.mihaim_gmail.com.Apr 1 2021, 4:47 PM
elenamihailescu22_gmail.com accepted this revision.Apr 4 2021, 8:53 AM

We tested the patch and everything seems OK from our part. The fix works as intended. Thanks!

This revision is now accepted and ready to land.Apr 4 2021, 8:53 AM
ionut.mihalache1506_gmail.com mentioned this in D26387: bhyve - Snapshot Save and Restore multiple devices.Apr 8 2021, 9:36 AM
Closed by commit rGeacc27affeff: bhyve: Move the gdb_active check to gdb_cpu_suspend(). (authored by jhb). · Explain WhyApr 12 2021, 6:45 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGeacc27affeff: bhyve: Move the gdb_active check to gdb_cpu_suspend()..
jhb added a commit: rG77e736186d8f: bhyve: Move the gdb_active check to gdb_cpu_suspend()..Aug 11 2021, 10:15 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
4 lines

Diff 87337

View Options

usr.sbin/bhyve/gdb.c

Loading...