Unit Tests Skipped
meson and pkgconf dependencies are handled by USES.
libarchive could be handled by USES as well.
did you run portfmt -D, portclippy and portaudit -CA ?
is this supposed to be fixed to 3.7?
docs should be hidden behind DOCS knob.
Hi Norbert and Piotr,
Glad to see you here and thanks for your work on the FreeBSD port of fwupd. Norbert, I tentatively added you as a maintainer for the missing sysutil/fwupd dependencies. Please let me know if that's something you're not interested in and I'll change that.
probably a stray line?
documentation could be hidden behind %%DOCS%% perhaps?
if introspection is only needed for build, then introspection:build might be a better choice.
again, docs could be hidden behind %%DOCS%% and apropriate OPTIONS could be added?
Thank you all for your amazing work. Currently, the fwupd patches have been merged into main repository.
I have created the update diff, but I am not able to attach the changes to this revision. Should I create the new one,
or is it some permission related problem? I followed this documentation:
https://wiki.freebsd.org/Phabricator#Create_a_Revision_via_Web_Interface ("To submit an updated patch")
Embedded Systems Engineer
http://3mdeb.com | @3mdeb_com
I have created the update diff, but I am not able to attach the changes to this revision.
You can only upload a new diff if you are listed as the author; you can 'Commandeer' the review first, then upload the diff.
After my last update, the fwupd build was completing.
After these changes there are errors:
../libfwupd/fwupd-common.c:1062:7: warning: implicit declaration of function 'memfd_create' is invalid in C99 [-Wimplicit-function-declaration] fd = memfd_create ("fwupd", MFD_CLOEXEC); ^ ../libfwupd/fwupd-common.c:1062:30: error: use of undeclared identifier 'MFD_CLOEXEC' fd = memfd_create ("fwupd", MFD_CLOEXEC); ^
One caveat is that I first tested this in a 12.2 jail, but have since upgrade to 13.0 on the build host. There is a regression related to the switch to OpenZFS in 13.0 that is causing the 12.2 jail to crash, so I can only test on 13.0 at the moment. Unless you can beat me to it, I'll try to look at the cause of the error, but it may take me some time. Looks like it might be a missing #include.