Page MenuHomeFreeBSD

iflib: Make if_shared_ctx_t a pointer to const
ClosedPublic

Authored by markj on Mar 5 2021, 9:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 30, 2:41 PM
Unknown Object (File)
Mon, Jun 30, 1:29 PM
Unknown Object (File)
Sun, Jun 29, 7:29 AM
Unknown Object (File)
Fri, Jun 27, 11:20 PM
Unknown Object (File)
Thu, Jun 26, 4:43 PM
Unknown Object (File)
Wed, Jun 25, 6:04 PM
Unknown Object (File)
Sat, Jun 21, 6:42 AM
Unknown Object (File)
Wed, Jun 18, 5:17 AM
Subscribers

Details

Summary

This structure is shared among multiple instances of a driver, so we
should ensure that it doesn't somehow get treated as if there's a
separate instance per interface. This is especially important for
software-only drivers like wg.

We could perhaps make DEVICE_REGISTER return a pointer to const as well,
so the sctx structures themselves could be defined as const. I don't
quite understand what this method is supposed to do in the general case
though, so I didn't modify it.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Mar 5 2021, 9:10 PM
sys/net/iflib.h
52

This is the meat of the change, the rest is required to compile after.

This revision is now accepted and ready to land.Mar 5 2021, 10:15 PM
This revision was automatically updated to reflect the committed changes.