Differential D28370

Disable PIE for MIPS u-boot-loader.
ClosedPublic
Actions

Authored by dgr_semihalf.com on Jan 27 2021, 11:36 AM.

Tags

Referenced Files

	Unknown Object (File)
	Thu, Oct 30, 2:49 PM

	Unknown Object (File)
	Thu, Oct 30, 4:41 AM

	Unknown Object (File)
	Tue, Oct 28, 1:45 PM

	Unknown Object (File)
	Sun, Oct 26, 9:21 PM

	Unknown Object (File)
	Sat, Oct 25, 12:45 PM

	Unknown Object (File)
	Sat, Oct 25, 12:45 PM

	Unknown Object (File)
	Sat, Oct 25, 5:15 AM

	Unknown Object (File)
	Sat, Oct 25, 4:58 AM

Subscribers

Details

Reviewers

mw
kib
imp
emaste
jhibbits
jhb
andrew
manu

Commits

rGafd4a4940790: Disable PIE for MIPS ubldr
rGea2392f2f2b3: Disable PIE for MIPS ubldr
rGcd992885bcdf: Disable PIE for MIPS ubldr

Summary

When performing buildworld for MIPS with PIE enabled, the build fails
with "position-independent code requires '-mabicalls'" message.
-mno-abicalls and -fno-pic flags are explicitly set in MIPS ubldr
makefile, so to work around this problem, set MK_PIE=no for MIPS
ubldr. This change was only build tested.

Problem was found when testing D28328.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dgr_semihalf.com requested review of this revision.Jan 27 2021, 11:36 AM

dgr_semihalf.com created this revision.

dgr_semihalf.com added child revisions: D28328: Enable PIE by default on 64-bit architectures, D27666: Enable ASLR by default for 64-bit executables..

emaste added inline comments.Jan 27 2021, 2:59 PM

stand/mips/uboot/Makefile
47	I think a comment here would be useful (a short version of the review description above indicating that PIE is incompatible with`-mno-abicalls`)

Added a comment indicating that PIE is incompatible with -mno-abicalls. Thanks, @emaste.

mw mentioned this in D28328: Enable PIE by default on 64-bit architectures.Feb 3 2021, 9:56 AM

emaste accepted this revision.Feb 24 2021, 6:50 PM

This revision is now accepted and ready to land.Feb 24 2021, 6:50 PM

Closed by commit rGcd992885bcdf: Disable PIE for MIPS ubldr (authored by mw). · Explain WhyFeb 24 2021, 11:27 PM

This revision was automatically updated to reflect the committed changes.

mw added a commit: rGcd992885bcdf: Disable PIE for MIPS ubldr.

kevans added a commit: rGea2392f2f2b3: Disable PIE for MIPS ubldr.Oct 8 2021, 4:10 PM

Herald added a subscriber: dab. · View Herald TranscriptOct 8 2021, 4:10 PM

mw added a commit: rGafd4a4940790: Disable PIE for MIPS ubldr.Jan 23 2022, 10:26 AM

Herald added a reviewer: manu. · View Herald TranscriptJan 23 2022, 10:26 AM

Revision Contents
Changeset List

Path

Size

stand/

mips/

uboot/

4 lines

Diff 83023

stand/mips/uboot/Makefile

Loading...