Page MenuHomeFreeBSD

Disable PIE for MIPS u-boot-loader.
ClosedPublic

Authored by dgr_semihalf.com on Jan 27 2021, 11:36 AM.

Details

Summary

When performing buildworld for MIPS with PIE enabled, the build fails
with "position-independent code requires '-mabicalls'" message.
-mno-abicalls and -fno-pic flags are explicitly set in MIPS ubldr
makefile, so to work around this problem, set MK_PIE=no for MIPS
ubldr. This change was only build tested.

Problem was found when testing D28328.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

stand/mips/uboot/Makefile
46

I think a comment here would be useful (a short version of the review description above indicating that PIE is incompatible with`-mno-abicalls`)

Added a comment indicating that PIE is incompatible with -mno-abicalls. Thanks, @emaste.

This revision is now accepted and ready to land.Feb 24 2021, 6:50 PM
This revision was automatically updated to reflect the committed changes.