Page MenuHomeFreeBSD

sys: Remove DEV_RANDOM device option
ClosedPublic

Authored by cem on Apr 15 2019, 8:46 PM.

Details

Summary

Remove 'device random' from kernel configurations that reference it (most).
Replace perhaps mistaken 'nodevice random' in two MIPS configs with 'options
RANDOM_LOADABLE' instead. Document removal in UPDATING; update NOTES and
random.4.

Test Plan

tinderbox is clean

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

cem created this revision.Apr 15 2019, 8:46 PM

I'm in favor of this change; please consider this as an explicit "accepted" if nobody objects in a week.

UPDATING
35 ↗(On Diff #56228)

Maybe make the second sentence first (Entropy collection.. are no longer an optional component, and the "device random" option has been removed) to emphasize that it's now enabled by default?

cem added a subscriber: lwhsu.Apr 16 2019, 2:56 PM

I'm in favor of this change; please consider this as an explicit "accepted" if nobody objects in a week.

Thanks! I will hold off on this change a bit (probably more than 1 week) until I've put out the fires from the last change.

UPDATING
35 ↗(On Diff #56228)

Sure, that sounds reasonable to me. Perhaps s/an optional component/optional components/ as well to match the plurality of the object to the subject.

cem updated this revision to Diff 56253.Apr 16 2019, 4:22 PM

Rebase on WIP changes; no functional change.

cem added a comment.Thu, Jun 20, 12:40 AM

Hi @delphij , @markm . Is this still something that seems reasonable or should I drop it?

markm accepted this revision.Thu, Jun 20, 7:37 AM

No objection from me.

This revision is now accepted and ready to land.Thu, Jun 20, 7:37 AM
delphij accepted this revision.Thu, Jun 20, 5:59 PM

I think I have accepted back in April but let's make it an explicit one. Be sure to update the dates though.

cem updated this revision to Diff 58847.Thu, Jun 20, 8:52 PM

Rebase on recent HEAD

This revision now requires review to proceed.Thu, Jun 20, 8:52 PM
cem added inline comments.Thu, Jun 20, 8:56 PM
UPDATING
35 ↗(On Diff #56228)

will fix.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.
markm added a comment.Sat, Jun 22, 8:59 AM

Still LGTM :-)