Differential D13858

1 << 31 redux
AbandonedPublic
Actions

Authored by eadler on Jan 11 2018, 11:59 AM.

Tags

None

Referenced Files

	F83648626: D13858.diff
	Mon, May 13, 2:16 AM

	Unknown Object (File)
	Thu, May 9, 11:20 PM

	Unknown Object (File)
	Sat, May 4, 4:47 AM

	Unknown Object (File)
	Fri, May 3, 11:08 AM

	Unknown Object (File)
	Tue, Apr 30, 2:24 AM

	Unknown Object (File)
	Mon, Apr 29, 8:22 AM

	Unknown Object (File)
	Sat, Apr 27, 5:20 PM

	Unknown Object (File)
	Sat, Apr 27, 1:41 AM

View All 56 Files

Subscribers

Details

Reviewers

kib
sbruno
manu

Summary

There are a few cases in FreeBSD where the expression (1 << 31) is used.

However this produces undefined behavior as '1' is of type int. (see
6.4.4p5: The type of an unmarked integer constant is the first of the
following list in which its value can be represented: int, long int,
long long int). The shift of 31 is illegal (see 6.5.7p4) if the size
of an int is 32.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14327
Build 14485: arc lint + arc unit

Event Timeline

eadler created this revision.Jan 11 2018, 11:59 AM

Herald added a reviewer: sbruno. · View Herald TranscriptJan 11 2018, 11:59 AM

Herald added a reviewer: sbruno. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added a reviewer: Intel Networking. · View Herald Transcript

Herald added subscribers: ae, jhibbits, gnn and 3 others. · View Herald Transcript

fix overzelous change

Harbormaster completed remote builds in B14293: Diff 37788.Jan 11 2018, 12:12 PM

kib requested changes to this revision.Jan 11 2018, 12:19 PM

kib added a subscriber: kib.

kib added inline comments.

sys/ufs/ffs/ffs_vfsops.c
1177 ↗	(On Diff #37788)	This is not needed.
sys/vm/vm_mmap.c
103 ↗	(On Diff #37788)	This is not needed.

This revision now requires changes to proceed.Jan 11 2018, 12:19 PM

remove missed instances of casted 1s

Harbormaster completed remote builds in B14294: Diff 37789.Jan 11 2018, 12:23 PM

The changes to the Intel ethernet drivers look fine to me.

Changes to dev/mlx4 and dev/mlx5 look fine, but commit them as separate patch.

eadler mentioned this in rS327864: sys/dev/mlx[45]: fix uses of 1 << 31.Jan 12 2018, 6:37 AM

eadler mentioned this in rS327865: sys/dev/e1000: fix uses of 1 << 31.

exclude committed parts

arm/allwinner looks fine.

kib added inline comments.Jan 13 2018, 12:26 PM

sys/x86/include/specialreg.h
209	This one is fine.

erj removed a reviewer: Intel Networking.Oct 3 2018, 5:19 PM

erj removed a subscriber: erj.

sbruno resigned from this revision.Jan 18 2019, 7:29 PM

Herald added a subscriber: bdragon. · View Herald TranscriptJan 18 2019, 7:29 PM

manu resigned from this revision.Oct 9 2020, 6:24 PM

eadler planned changes to this revision.Oct 10 2020, 7:52 AM

eadler abandoned this revision.

Revision Contents
Changeset List

Path

Size

lib/

libc/

sparc64/

fpu/

4 lines

6 lines

release/

picobsd/

tinyware/

ns/

2 lines

sbin/

ipfw/

4 lines

stand/

i386/

libfirewire/

2 lines

6 lines

sys/

arm/

allwinner/

4 lines

18 lines

clk/

2 lines

2 lines

4 lines

2 lines

2 lines

2 lines

2 lines

18 lines

arm/

2 lines

at91/

10 lines

freescale/

imx/

2 lines

2 lines

vybrid/

4 lines

2 lines

6 lines

nvidia/

tegra124/

tegra124_machdep.c

2 lines

4 lines

2 lines

samsung/

exynos/

exynos5_usb_phy.c

4 lines

4 lines

ti/

cpsw/

2 lines

arm64/

arm64/

2 lines

dev/

acpi_support/

2 lines

ata/

chipsets/

4 lines

bxe/

2 lines

cesa/

2 lines

cxgb/

common/

2 lines

cxgbe/

firmware/

t4fw_interface.h

2 lines

drm2/

i915/

46 lines

2 lines

firewire/

2 lines

4 lines

6 lines

hwpmc/

2 lines

2 lines

hwpmc_mpc7xxx.c

2 lines

hwpmc_powerpc.h

2 lines

2 lines

if_ndis/

2 lines

iwm/

10 lines

ixgbe/

4 lines

mmc/

host/

2 lines

2 lines

2 lines

4 lines

qlnx/

qlnxe/

2 lines

qlxgb/

2 lines

qlxgbe/

2 lines

qlxge/

2 lines

sound/

pci/

2 lines

uart/

uart_dev_mvebu.c

2 lines

usb/

controller/

6 lines

saf1761_otg_reg.h

2 lines

net/

2 lines

geom/

raid/

2 lines

mips/

beri/

2 lines

ingenic/

2 lines

8 lines

2 lines

2 lines

mediatek/

2 lines

2 lines

nlm/

dev/

net/

8 lines

ofed/

include/

rdma/

4 lines

powerpc/

fpu/

4 lines

2 lines

6 lines

mpc85xx/

2 lines

riscv/

include/

4 lines

x86/

include/

2 lines

2 lines

Diff 37855

lib/libc/sparc64/fpu/fpu_div.c

Loading...

lib/libc/sparc64/fpu/fpu_sqrt.c

Loading...

release/picobsd/tinyware/ns/ns.c

Loading...

sbin/ipfw/tables.c

Loading...

stand/i386/libfirewire/fwohci.c

Loading...

stand/i386/libfirewire/fwohcireg.h

Loading...

sys/arm/allwinner/a10_fb.c

Loading...

sys/arm/allwinner/a10_hdmi.c

Loading...

sys/arm/allwinner/clk/aw_debeclk.c

Loading...

sys/arm/allwinner/clk/aw_hdmiclk.c

Loading...

sys/arm/allwinner/clk/aw_lcdclk.c

Loading...

sys/arm/allwinner/clk/aw_mmcclk.c

Loading...

sys/arm/allwinner/clk/aw_modclk.c

Loading...

sys/arm/allwinner/clk/aw_pll.c

Loading...

sys/arm/allwinner/clk/aw_thsclk.c

Loading...

sys/arm/allwinner/if_awgreg.h

Loading...

sys/arm/arm/identcpu-v6.c

Loading...

sys/arm/at91/at91_pioreg.h

Loading...

sys/arm/freescale/imx/imx6_audmux.c

Loading...

sys/arm/freescale/imx/imx6_ipu.c

Loading...

sys/arm/freescale/vybrid/vf_dcu4.c

Loading...

sys/arm/freescale/vybrid/vf_sai.c

Loading...

sys/arm/freescale/vybrid/vf_spi.c

Loading...

sys/arm/nvidia/tegra124/tegra124_machdep.c

Loading...

sys/arm/nvidia/tegra124/tegra124_pmc.c

Loading...

sys/arm/nvidia/tegra_ahci.c

Loading...

sys/arm/samsung/exynos/exynos5_usb_phy.c

Loading...

sys/arm/samsung/exynos/exynos5_xhci.c

Loading...

sys/arm/ti/cpsw/if_cpsw.c

Loading...

sys/arm64/arm64/gic_v3_reg.h

Loading...

sys/dev/acpi_support/acpi_ibm.c

Loading...

sys/dev/ata/chipsets/ata-intel.c

Loading...

sys/dev/bxe/ecore_hsi.h

Loading...

sys/dev/cesa/cesa.h

Loading...

sys/dev/cxgb/common/cxgb_t3_hw.c

Loading...

sys/dev/cxgbe/firmware/t4fw_interface.h

Loading...

sys/dev/drm2/i915/i915_reg.h

Loading...

sys/dev/drm2/i915/intel_pm.c

Loading...

sys/dev/firewire/firewire.c

Loading...

sys/dev/firewire/fwohci.c

Loading...

sys/dev/firewire/fwohcireg.h

Loading...

sys/dev/hwpmc/hwpmc_armv7.c

Loading...

sys/dev/hwpmc/hwpmc_e500.c

Loading...

sys/dev/hwpmc/hwpmc_mpc7xxx.c

Loading...

sys/dev/hwpmc/hwpmc_powerpc.h

Loading...

sys/dev/hwpmc/hwpmc_ppc970.c

Loading...

sys/dev/if_ndis/if_ndis.c

Loading...

sys/dev/iwm/if_iwmreg.h

Loading...

sys/dev/ixgbe/ixgbe_type.h

Loading...

sys/dev/mmc/host/dwmmc.c

Loading...

sys/dev/mmc/host/dwmmc_reg.h

Loading...

sys/dev/mmc/mmc_ioctl.h

Loading...

sys/dev/mmc/mmcsd.c

Loading...

sys/dev/qlnx/qlnxe/spad_layout.h

Loading...

sys/dev/qlxgb/qla_def.h

Loading...

sys/dev/qlxgbe/ql_def.h

Loading...

sys/dev/qlxge/qls_hw.h

Loading...

sys/dev/sound/pci/hdspe.h

Loading...

sys/dev/uart/uart_dev_mvebu.c

Loading...

sys/dev/usb/controller/saf1761_otg.c

Loading...

sys/dev/usb/controller/saf1761_otg_reg.h

Loading...

sys/dev/usb/net/if_urereg.h

Loading...

sys/geom/raid/tr_raid1e.c

Loading...

sys/mips/beri/beri_pic.c

Loading...

sys/mips/ingenic/jz4780_codec.h

Loading...

sys/mips/ingenic/jz4780_lcd.h

Loading...

sys/mips/ingenic/jz4780_pdma.h

Loading...

sys/mips/ingenic/jz4780_regs.h

Loading...

sys/mips/mediatek/mtk_intr_gic.c

Loading...

sys/mips/mediatek/mtk_pcie.c

Loading...

sys/mips/nlm/dev/net/sgmii.c

Loading...

sys/ofed/include/rdma/ib_verbs.h

Loading...

sys/powerpc/fpu/fpu_div.c

Loading...

sys/powerpc/fpu/fpu_mul.c

Loading...

sys/powerpc/fpu/fpu_sqrt.c

Loading...

sys/powerpc/mpc85xx/fsl_diu.c

Loading...

sys/riscv/include/riscvreg.h

Loading...

sys/x86/include/specialreg.h

Loading...

sys/x86/include/vmware.h

Loading...