Page MenuHomeFreeBSD

multimediaUmbrella
ActivePublic

Recent Activity

May 25 2022

hselasky added a comment to D11140: OSS: allow unplug sound cards without apps close devices.

https://cgit.freebsd.org/ports/commit/?id=3bc8803e5c4a96b60ffe5fa6887e2b73e0df7756

May 25 2022, 9:19 AM · Contributor Reviews (base), multimedia

Mar 20 2022

hselasky closed D34614: mixer.8: document shorthand syntax for volume setting.
Mar 20 2022, 7:22 PM · multimedia
hselasky closed D34603: mixer: fix mandoc -Tlint errors.
Mar 20 2022, 7:22 PM · multimedia
hselasky closed D34617: mixer(8): fix shorthand syntax bug.
Mar 20 2022, 7:22 PM · multimedia
hselasky accepted D34614: mixer.8: document shorthand syntax for volume setting.
Mar 20 2022, 7:14 PM · multimedia
christos updated the diff for D34617: mixer(8): fix shorthand syntax bug.

Done.

Mar 20 2022, 6:59 PM · multimedia
hselasky added inline comments to D34617: mixer(8): fix shorthand syntax bug.
Mar 20 2022, 6:43 PM · multimedia
christos updated the diff for D34617: mixer(8): fix shorthand syntax bug.

Combine conditions.

Mar 20 2022, 6:17 PM · multimedia
christos requested review of D34617: mixer(8): fix shorthand syntax bug.
Mar 20 2022, 6:10 PM · multimedia
christos abandoned D34613: mixer(8): move control defines into an enum.
Mar 20 2022, 6:06 PM · multimedia
christos added a comment to D34603: mixer: fix mandoc -Tlint errors.

Documented the new shorthand syntax in D34614. Depends on this revision.

Mar 20 2022, 5:17 PM · multimedia
christos requested review of D34614: mixer.8: document shorthand syntax for volume setting.
Mar 20 2022, 5:16 PM · multimedia
hselasky closed D34612: mixer(8): add shorthand syntax for setting the volume.
Mar 20 2022, 4:34 PM · multimedia
hselasky closed D34591: mixer(8): remove [.volume] string from default printout.
Mar 20 2022, 4:34 PM · multimedia
christos added a comment to D34603: mixer: fix mandoc -Tlint errors.

Yes.

Mar 20 2022, 4:32 PM · multimedia
christos added a comment to D34612: mixer(8): add shorthand syntax for setting the volume.

Don't push it. I also forgot to add suport for [+|-].

Mar 20 2022, 4:32 PM · multimedia
hselasky added a comment to D34603: mixer: fix mandoc -Tlint errors.

Can you add a section here about the new shorthand syntax while at it?

Mar 20 2022, 4:31 PM · multimedia
christos retitled D34613: mixer(8): move control defines into an enum from mixer(8): add control defines into an enum to mixer(8): move control defines into an enum.
Mar 20 2022, 4:28 PM · multimedia
christos requested review of D34613: mixer(8): move control defines into an enum.
Mar 20 2022, 4:27 PM · multimedia
hselasky accepted D34612: mixer(8): add shorthand syntax for setting the volume.
Mar 20 2022, 4:24 PM · multimedia
christos updated the diff for D34612: mixer(8): add shorthand syntax for setting the volume.

Accept floating point numbers as input.

Mar 20 2022, 4:21 PM · multimedia
hselasky accepted D34603: mixer: fix mandoc -Tlint errors.
Mar 20 2022, 4:17 PM · multimedia
christos added inline comments to D34612: mixer(8): add shorthand syntax for setting the volume.
Mar 20 2022, 4:13 PM · multimedia
hselasky added inline comments to D34612: mixer(8): add shorthand syntax for setting the volume.
Mar 20 2022, 4:12 PM · multimedia
christos added a comment to D34591: mixer(8): remove [.volume] string from default printout.

D34612 depends on this revision.

Mar 20 2022, 4:07 PM · multimedia
christos requested review of D34612: mixer(8): add shorthand syntax for setting the volume.
Mar 20 2022, 4:05 PM · multimedia

Mar 18 2022

christos updated the diff for D34603: mixer: fix mandoc -Tlint errors.

Ran igor(1) on both mixer.8 and mixer.3. The line changes were made because mandoc -Tlint was printing warnings, so I wanted them to go away. :-)

Mar 18 2022, 2:56 PM · multimedia
0mp requested changes to D34603: mixer: fix mandoc -Tlint errors.

Could you also run igor mixer.3? You can find igor in the package repo.

Mar 18 2022, 2:52 PM · multimedia
christos updated the diff for D34603: mixer: fix mandoc -Tlint errors.

Fixed.

Mar 18 2022, 2:44 PM · multimedia
0mp requested changes to D34603: mixer: fix mandoc -Tlint errors.

Your changes to mixer.8 seem to revert recent patches. Please submit a rebased patch.

Mar 18 2022, 2:28 PM · multimedia
christos added a reviewer for D34603: mixer: fix mandoc -Tlint errors: 0mp.
Mar 18 2022, 1:54 PM · multimedia
christos requested review of D34603: mixer: fix mandoc -Tlint errors.
Mar 18 2022, 1:51 PM · multimedia
christos abandoned D32499: sound(4): Apply mixer patches in 13.0-RELEASE.

Alright then, we can abandon it!

Mar 18 2022, 1:25 PM · multimedia
hselasky added a comment to D32499: sound(4): Apply mixer patches in 13.0-RELEASE.

Current plan is to release 13.1 April 26, 2022 .

Mar 18 2022, 1:19 PM · multimedia
christos added a comment to D32499: sound(4): Apply mixer patches in 13.0-RELEASE.

Mostly for completeness, but we can abandon it if 13.1 is close to release.

Mar 18 2022, 1:08 PM · multimedia
hselasky added a comment to D32499: sound(4): Apply mixer patches in 13.0-RELEASE.

Technically no, but I worried about some unknown side effects.

Mar 18 2022, 1:04 PM · multimedia
christos added a comment to D32499: sound(4): Apply mixer patches in 13.0-RELEASE.

Since these are just the kernel patches, would it break anything if we push them in 13.0-RELEASE as well?

Mar 18 2022, 1:02 PM · multimedia
hselasky added a comment to D32499: sound(4): Apply mixer patches in 13.0-RELEASE.

I think all of this will be part of the coming 13.1! So let's just abandon this one?

Mar 18 2022, 11:04 AM · multimedia

Mar 17 2022

christos added a comment to D32499: sound(4): Apply mixer patches in 13.0-RELEASE.

Bump.

Mar 17 2022, 8:20 PM · multimedia
christos updated the summary of D32499: sound(4): Apply mixer patches in 13.0-RELEASE.
Mar 17 2022, 8:20 PM · multimedia
christos added a comment to D34591: mixer(8): remove [.volume] string from default printout.

Looks good. Are there more patches coming?

Mar 17 2022, 5:34 PM · multimedia
hselasky accepted D34591: mixer(8): remove [.volume] string from default printout.

Looks good. Are there more patches coming?

Mar 17 2022, 5:32 PM · multimedia
christos requested review of D34591: mixer(8): remove [.volume] string from default printout.
Mar 17 2022, 5:19 PM · multimedia

Jan 4 2022

hselasky added a comment to D33732: mixer(3): Move unnecessary includes out of header file.

I would appreciate if you could build test a bit more, like "make buildworld", before submitting patches.

Jan 4 2022, 11:37 AM · multimedia
hselasky closed D33732: mixer(3): Move unnecessary includes out of header file.
Jan 4 2022, 10:45 AM · multimedia
hselasky accepted D33732: mixer(3): Move unnecessary includes out of header file.
Jan 4 2022, 10:37 AM · multimedia

Jan 3 2022

christos requested review of D33732: mixer(3): Move unnecessary includes out of header file.
Jan 3 2022, 9:55 PM · multimedia

Nov 29 2021

christos abandoned D33142: mixer(3): Remove useless comments.
Nov 29 2021, 2:13 PM · multimedia

Nov 28 2021

christos added a comment to D33142: mixer(3): Remove useless comments.

Comments sometimes help verify that the code has been implemented correctly.

Nov 28 2021, 4:32 PM · multimedia
hselasky added a comment to D33142: mixer(3): Remove useless comments.

Comments sometimes help verify that the code has been implemented correctly.

Nov 28 2021, 1:58 PM · multimedia