audio/mumble-server: update to 1.5.517

[vvd]

Summary

Upstream rename murmur to mumble-server - need help with entry in UPDATING.

Tested on live system 13.2-p1 amd64 - build, run and connect to server (and speak).
Build in poudriere 13.2-p1 amd64 and i386 with default options and with all options on.

Can't test on arm, ppc and other platforms. Who can test?

Also need testing on 14 with OpenSSL 3 and LLVM 16.

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261395

[adamw]

The problem with UPDATING is that it's only visible to people with a checked-out ports tree; people who only use binary packages will never see the messages.

You still want to put stuff in UPDATING, but pkg-message is actually the most helpful as it's visible to everyone using pkg (FreeBSD upstream, poudriere, etc.).

See https://docs.freebsd.org/en/books/porters-handbook/pkg-files/#porting-message, especially "Example 4: Display a Message on Upgrade."

[bofh]

UIDs

286 ↗

(On Diff #124723)

Do not do this please. Create a new user. For safety and sanity reasons it's not wise to change/remove this during the lifetime of supported releases. So we can remove this sometimes after the end of 13.

[eduardo]

The problem with UPDATING is that it's only visible to people with a checked-out ports tree; people who only use binary packages will never see the messages.

pkg-updating(8) - display UPDATING entries of software packages

[vvd]

After discussion in IRC I updated the patch:

• Keep old names for user and group is "technical debt" and "confuse the users" (especially new).
• Use new UID and GID is difficult to migrate for running systems - find and change owner for all files required for port.

So, IMHO, rename user and group is "the lesser of the evils".

[vvd]

In D41048#934479, @adamw wrote:

The problem with UPDATING is that it's only visible to people with a checked-out ports tree; people who only use binary packages will never see the messages.

You still want to put stuff in UPDATING, but pkg-message is actually the most helpful as it's visible to everyone using pkg (FreeBSD upstream, poudriere, etc.).

See https://docs.freebsd.org/en/books/porters-handbook/pkg-files/#porting-message, especially "Example 4: Display a Message on Upgrade."

Added pkg-message.

[adamw]

In D41048#943752, @eduardo wrote:

The problem with UPDATING is that it's only visible to people with a checked-out ports tree; people who only use binary packages will never see the messages.

pkg-updating(8) - display UPDATING entries of software packages

pkg-updating(8) requires a ports tree checked out locally. For users who exclusively use pkg(8), messages only come from pkg-message.

[tcberner]

UPDATING

16 ↗

(On Diff #126054)

@bapt is there a way to make pkg handle the migration during upgrade?

[vvd]

ping

[vvd]

ping :-(

[arrowd]

There is something strange going on with this diff. When trying to apply it via arc patch D41048 I do get the audio/mumble-server port, but it contains PORTNAME=murmur and PORTVERSION=1.3.3. Maybe this is because the patch doesn't apply.

@vvd can you please refresh it?

[vvd]

In D41048#955081, @arrowd wrote:

There is something strange going on with this diff. When trying to apply it via arc patch D41048 I do get the audio/mumble-server port, but it contains PORTNAME=murmur and PORTVERSION=1.3.3. Maybe this is because the patch doesn't apply.

@vvd can you please refresh it?

I don't know how to do this correct in one patch: 1) rename port, 2) update to new version.
So patch can look weird and possible not all tools can work correctly with it. This part:

diff --git a/audio/murmur/Makefile b/audio/mumble-server/Makefile
similarity index 100%
rename from audio/murmur/Makefile
rename to audio/mumble-server/Makefile
diff --git a/audio/murmur/distinfo b/audio/mumble-server/distinfo
similarity index 100%
rename from audio/murmur/distinfo
rename to audio/mumble-server/distinfo
diff --git a/audio/murmur/files/murmur.in b/audio/mumble-server/files/mumble_server.in
similarity index 100%
rename from audio/murmur/files/murmur.in
rename to audio/mumble-server/files/mumble_server.in
diff --git a/audio/murmur/files/patch-initialize-SSL b/audio/mumble-server/files/patch-initialize-SSL
similarity index 100%
rename from audio/murmur/files/patch-initialize-SSL
rename to audio/mumble-server/files/patch-initialize-SSL
diff --git a/audio/murmur/files/patch-scripts_murmur.ini b/audio/mumble-server/files/patch-scripts_murmur.ini
similarity index 100%
rename from audio/murmur/files/patch-scripts_murmur.ini
rename to audio/mumble-server/files/patch-scripts_murmur.ini
diff --git a/audio/murmur/files/patch-src_SelfSignedCertificate.cpp b/audio/mumble-server/files/patch-src_SelfSignedCertificate.
cpp
similarity index 100%
rename from audio/murmur/files/patch-src_SelfSignedCertificate.cpp
rename to audio/mumble-server/files/patch-src_SelfSignedCertificate.cpp
diff --git a/audio/murmur/pkg-descr b/audio/mumble-server/pkg-descr
similarity index 100%
rename from audio/murmur/pkg-descr
rename to audio/mumble-server/pkg-descr
diff --git a/audio/murmur/pkg-plist b/audio/mumble-server/pkg-plist
similarity index 100%
rename from audio/murmur/pkg-plist
rename to audio/mumble-server/pkg-plist

[arrowd]

I don't know how to do this correct in one patch: 1) rename port, 2) update to new version.

Create a commit, then use git format-patch -1.

[vvd]

Patch from git format-patch -1.
Not so obvious - diff look like "rm file && create file"…

[vvd]

I don't know if this is what you asked for...

[vvd]

As an option, create a new port with new UID/GID, and specify DEPRECATED in the old one and for some time there will be 2 ports at the same time. And then delete the old one with an entry in UPDATINGS describing the migration process.

[arrowd]

In D41048#990566, @vvd wrote:

As an option, create a new port with new UID/GID, and specify DEPRECATED in the old one and for some time there will be 2 ports at the same time. And then delete the old one with an entry in UPDATINGS describing the migration process.

I actually like this plan, even without deprecating. Just leave it as it is, use new UID/GID and free old UID/GID. In the pkg-message change step 5 from pw usermod to chown -R.

[vvd]

In D41048#990567, @arrowd wrote:

In D41048#990566, @vvd wrote:

As an option, create a new port with new UID/GID, and specify DEPRECATED in the old one and for some time there will be 2 ports at the same time. And then delete the old one with an entry in UPDATINGS describing the migration process.

I actually like this plan, even without deprecating. Just leave it as it is, use new UID/GID and free old UID/GID. In the pkg-message change step 5 from pw usermod to chown -R.

1.3 is deprecated by upstream (we have 1.3.3, but last verison in 1.3 branch is 1.3.4).
1.4 is current stable release, but it doesn't support OpenSSL 3.
1.5 is RC for 1 year already - waiting release.

Update audio/murumr from 1.3.3 to 1.3.4 is waste of time, IMHO.
Update audio/murumr 1.3 to 1.4 and add new port audio/mumble-server with 1.5 - it's IMHO double work (but I can do it).
Just deprecate audio/murumr 1.3 with EXPIRATION_DATE=2024-12-31 and add new port audio/mumble-server with 1.5 is best option, IMHO.

[vvd]

Added UIDs, GIDs and UPDATING.

[vvd]

I check - update from 1.3.3 to 1.3.4 is trivial. Can I update it and take maintainership without review?
Also it need LIB_DEPENDS=devel/abseil - tested in poudriere.

After that I'll update patch in this review.

[vvd]

Patch against current audio/murmur.

[vvd]

Trying to update diff using arcanist.

[vvd]

If you want to test it - get current patch.
If you want to see diff with old murmur - check history patch here: https://reviews.freebsd.org/D41048?id=133095