This looks like an older review for

looks OK, but tagging for srcmgr review since some of it looks weird too :)

code looks OK, though my arm assembler is rusty. tagged as srcmgr for review

srcmgr review, likely OK, but not actually accepted.

Wonder what the status of this is... Tagging for srcmgr review, even though it didn't make it to accepted.

tagging for srcmgr review. These are all likely a sea of conflicts now, but that should be easy to resolve.

Looks like this would be easy to forward port. But the patch series likely needs some work. tagging for srcmgr review.

This isn't in current. Tagging for further review by srcmgr.
It's looking, though, like an incomplete patch that maybe should be closed.

This appears to have landed in slightly modified form in the following. Any lingering open issues should be addressed in a new review.

Please rebase all relevant patches, including this one, on top of main, stack them properly, and also re-generate and update the diffs with full context: https://wiki.freebsd.org/Phabricator#Create_a_Revision_via_Web_Interface

Can you please:

• Rebase it on top of the current main branch.
• Generate the diffs with full context git diff -U999999.
• Organize the commit message, test plan and additional notes. Things are a bit all over the place now.

vybrid case it might be time to remove that one soon - some of the drivers seems to be used as base for the layerscape SoC for example D44020.
https://cgit.freebsd.org/src/commit/?id=ba9f8eeb478975069b644f2228808d5e0c0dc1b1

they should be in GENERIC if able (or at lease something tinderbox would build).

In D41888#977453, @oskar.holmlund_ohdata.se wrote:

Background why this driver is added:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/arch/arm/boot/dts/am33xx-clocks.dtsi?h=v6.1.64&id=c2f2646057bcf3f86a75f6a8aa9fbd159a1d4784

Fix Mikes comments.

Sorry - just confused and update wrong reviews... :)

Update sys/arm/ti/files.ti aswell and remove clock_common.c

adds comment that you need to read the manual pages about TSLOG

Split of https://reviews.freebsd.org/D27889

In D46703#1064788, @manu wrote:

Not sure this is worth it, people can have local modification if they want to work on TI stuff.
We know that the current code doesn't boot with latest dtb so until this is solved no point of adding this config.

Not sure this is worth it, people can have local modification if they want to work on TI stuff.
We know that the current code doesn't boot with latest dtb so until this is solved no point of adding this config.

If this boots on bbb, then great.... well, boots as well as it can... I've had two or three people contact me about fixes for new dts... should ibdo introductions since you know the issues with much better fidelity?