Nice work. This looks good to me. Thank you for implementing this.

I new I smelled something afoot. Good eye sir.

Thank you for your work on this.

Thank you for the quick turn around on this. These changes are exactly what I was looking for.

Fair enough. It does what its supposed to do regardless, so its probably better.

The only issue I can see is that the attentive Sysadmin and normal FreeBSD user will immediately want to remove either the AMD or Intel microcode package on installation depending on their hardware platform.

• Add a PORTEPOCH for this change so that users actually see a valid update

In D30029#674233, @tcberner wrote:

Note, that you will require to set PORTEPOCH as

pkg version -t clementine-player-1.4.0_6 clementine-player-1.4.0.r1.586
>

Address pkg naming convention.

In D25964#581321, @mat wrote:

The port is missing a DOCS option, also, can you regenerate the pkg-plist file with make makeplist? It is strangely ordered.

https://github.com/Cockatrice/Cockatrice/releases/tag/2020-08-23-Release-2.7.5

The author maintains actual factual releases in Gitlab. I didn't see any equivalent to GH_TAGNAME to support this, so I only used the hash of the release branch.

Drop all patches as they have been accepted upstream or worked around.

In D25964#576346, @mat wrote:

Ah, sorry, I should have added that patch files need to have a small comment at the top explaining they why of what they are doing, for example, like https://reviews.freebsd.org/source/ports/browse/head/lang/perl5.32/files/patch-Makefile.SH.

Use patch files to deal with man page locations.
Update pkg-plist for change to man page location.
Use patch files to deal with changing the desktop configuration file.

Add pkg-message to indicate where default ROMs should go.
Add HTML documentation files.
Fix bugs with last revision (SDL version, pkg-desc line len,
empty lines).
Change default behavior to *not* exec sdltrs from a terminal.

Obviously, without this change, no IFLIB enabled adapter will netboot/nfsboot on non-x86 hardware. For now, this was used in the FreeBSD Cluster to restore service to a failed ARM64 machine.

I think we need @hiren for further details for this revert. I believe he asked me to undo this.

I don't have access to this hardware. I can't test the changes here.

This was superceded by @kib in r343617. The purpose of this revision was to provide a simple way to have module support for the various adapters supported by iflib and to cull iflib out when not needed.

I've been running this with no defects for quite some time.

Is the raw patch updated so I can test it?

Huh ... Settings->Keyboard->Typing Settings->Repeat Speed was reset to "1". I've bumped it locally back to 50 so I don't throw my keyboard across the room. :-)

Ugh, no. It does repeat but its on a 3 second or so output delay.

Does anyone else notice that holding a key in xfce-terminal and waiting for a repeat of characters doesn't seem to happen with this update?

This is what I have installed currently for the record.

sbruno@alice:~ % pkg info |grep xfce
libxfce4menu-4.14.1            Widgets library for the Xfce desktop environment
libxfce4util-4.14.0            Extension library for the Xfce desktop environment
xfce-4.14                      meta-port for the Xfce Desktop Environment
xfce-icons-elementary-0.13.1   Elementary icons, extended and maintained for Xfce
xfce4-appfinder-4.14.0         Application launcher and finder
xfce4-conf-4.14.1              D-Bus-based configuration storage system
xfce4-desktop-4.14.1           Xfce's desktop manager
xfce4-mixer-4.11.0_5           Volume control for the Xfce desktop
xfce4-notifyd-0.4.4_1          Visually-appealing notification daemon for Xfce
xfce4-panel-4.14.0             Xfce's panel
xfce4-screenshooter-plugin-1.9.5_1 Application and panel plugin to take screenshots
xfce4-session-4.14.0           Xfce's session manager
xfce4-settings-4.14.0          Xfce 4 settings application
xfce4-terminal-0.8.8_1         Terminal emulator for the X windowing system
xfce4-tumbler-0.2.7            Thumbnail service for Xfce desktop
xfce4-wm-4.14.0                Xfce's window manager

I've applied and compiled all this and it seems to do the right thing. A few icons on my tool bars lost their icons, but that was easily fixed.

Allrighty, thank you. This applied and I'm rebuilding now. I'll report back on behavior.

In D21278#462738, @madpilot wrote:

In D21278#462737, @sbruno wrote:

Hrm ... phabricator and patch really don't like to apply this to my local tree. It chokes on adding new stuff and I can't seem to work around it. Any suggestions?

Strange, I generated it using arc from command line.

You can grab a ports overlay here:

https://github.com/madpilot78/FreeBSD-xfce4.13

it's the same as the patch.

I also uploaded the result of svn diff here:

https://people.freebsd.org/~madpilot/xfce414.diff

In D21278#462738, @madpilot wrote:

In D21278#462737, @sbruno wrote:

Hrm ... phabricator and patch really don't like to apply this to my local tree. It chokes on adding new stuff and I can't seem to work around it. Any suggestions?

Strange, I generated it using arc from command line.

You can grab a ports overlay here:

https://github.com/madpilot78/FreeBSD-xfce4.13

it's the same as the patch.

I also uploaded the result of svn diff here:

https://people.freebsd.org/~madpilot/xfce414.diff

Hrm ... phabricator and patch really don't like to apply this to my local tree. It chokes on adding new stuff and I can't seem to work around it. Any suggestions?