Pong. This one looks good too. :)

Thank you. And I'm glad to see upstream getting more in sync with us. ;-)

Wow. That's a blast from the past.

Thanks for clarifying.

This makes sense. Thank you.

This is good. And it passes the test in D52241.

Hah. I forgot I did a previous installworld after reviewing D52240. I am not smart.
This looks good. And the test passes with the D52240 applied.

• Check failed: /home/philip/freebsd/src/lib/libc/tests/stdtime/detect_tz_changes_test.c:96: expect != buf (-0700 (PDT) != +0000 (-00))

This looks good. Thank you!

This compiles and the "git diff" output against upstream and against main looks plausible. I have not checked every line of the diff with a fine tooth comb. But this can land. I don't think it will break.

This looks good. I agree about strftime.c.

Approved by: philip (mentor)

I tested this in the FreeBSD.org cluster and it works. Many thanks!

I did a cursory review and a quick test. This seems to do what it says on the box. I have not had time for an in-depth review. I think this is good to commit to main before stable/15.

I don't think PowerPC 32 failing is a blocker for main or stable/15: we're ending support for 32 bit platforms. Do we ever plan to merge this to stable/14 though?

Approved by: philip (mentor)

Approved by: philip (mentor)

Approved by: philip (mentor)

Approved by: philip (mentor)

I haven't tested this but assuming we do indeed use only interface ioctls, this looks like it should work.

Looks good to me. Thank you for addressing @bz's comments.

I don't know anyone who uses this option. I certainly don't test it. :-)
I don't mind additional documentation.

This looks good to me -- modulo @diizzy's comments.

Thanks for the feedback. That was my reasoning for doing posix_only instead of the tzdata default posix_right.

This builds the "main" format of the time zone database. That includes backward compatibility links but it doesn't include historical ("backzone") data. The "redo" bit controls how leapseconds are handled. We may want this to be posix_right. I'm not sure what other vendors do here.

Thank you for doing this work! At a glance, this looks good enough to give a test-drive on the cluster.

Thanks. LGTM.

...and remember to update the date stamps and type something in a REVISION... :)

This looks good to me. Go ahead and commit this.