Page MenuHomeFreeBSD
Differential D52241

tzcode: Add a test case for plain issetugid case
ClosedPublic
Actions

Authored by des on Aug 29 2025, 4:09 PM.
Tags
None
Referenced Files
F135680206: D52241.diff
Tue, Nov 11, 8:25 PM
Unknown Object (File)
Mon, Nov 3, 6:04 PM
Unknown Object (File)
Mon, Oct 27, 4:44 PM
Unknown Object (File)
Sat, Oct 25, 6:50 PM
Unknown Object (File)
Tue, Oct 21, 9:10 PM
Unknown Object (File)
Oct 11 2025, 12:07 AM
Unknown Object (File)
Oct 10 2025, 5:40 PM
Unknown Object (File)
Oct 10 2025, 5:40 PM
View All 28 Files
Subscribers
imp

Details

Reviewers
philip
Commits
rG016d3ec239b3: tzcode: Add a test case for plain issetugid case
Summary

This catches a bug in tzcode which incorrectly considers TZDEFAULT as
unsafe as if it came from the environment.

Also deduplicate some repeated code, and fix a missing mode in an
open(2) call with O_CREAT set.

Event: Oslo Hackathon 202508

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Aug 29 2025, 4:09 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 29 2025, 4:09 PM
des requested review of this revision.Aug 29 2025, 4:09 PM
Harbormaster completed remote builds in B66641: Diff 161196.Aug 29 2025, 4:09 PM
des added a parent revision: D52240: tzcode: Don't treat TZDEFAULT as tainted.Aug 29 2025, 4:09 PM
philip added a comment.Aug 30 2025, 3:51 AM

Hmm...

  • Check failed: /home/philip/freebsd/src/lib/libc/tests/stdtime/detect_tz_changes_test.c:96: expect != buf (-0700 (PDT) != +0000 (-00))
des added a comment.Aug 31 2025, 9:50 AM
In D52241#1193936, @philip wrote:

Hmm...

  • Check failed: /home/philip/freebsd/src/lib/libc/tests/stdtime/detect_tz_changes_test.c:96: expect != buf (-0700 (PDT) != +0000 (-00))

Yes, the test successfully demonstrated that your libc has the bug fixed by D52240.

philip accepted this revision.Aug 31 2025, 11:48 PM

Hah. I forgot I did a previous installworld after reviewing D52240. I am not smart.
This looks good. And the test passes with the D52240 applied.

This revision is now accepted and ready to land.Aug 31 2025, 11:48 PM
philip mentioned this in D52240: tzcode: Don't treat TZDEFAULT as tainted.Sep 1 2025, 12:29 AM
Closed by commit rG016d3ec239b3: tzcode: Add a test case for plain issetugid case (authored by des). · Explain WhySep 1 2025, 6:36 AM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG016d3ec239b3: tzcode: Add a test case for plain issetugid case.

Revision Contents
Changeset List

PathSize
lib/
libc/
tests/
stdtime/
60 lines

Diff 161313

View Options

lib/libc/tests/stdtime/detect_tz_changes_test.c

Loading...