Page MenuHomeFreeBSD

tzcode: Add a test case for plain issetugid case
ClosedPublic

Authored by des on Aug 29 2025, 4:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 12:07 AM
Unknown Object (File)
Fri, Oct 10, 5:40 PM
Unknown Object (File)
Fri, Oct 10, 5:40 PM
Unknown Object (File)
Fri, Oct 10, 12:36 PM
Unknown Object (File)
Wed, Oct 8, 9:23 PM
Unknown Object (File)
Thu, Oct 2, 2:01 PM
Unknown Object (File)
Fri, Sep 19, 9:13 AM
Unknown Object (File)
Fri, Sep 19, 3:16 AM
Subscribers

Details

Summary

This catches a bug in tzcode which incorrectly considers TZDEFAULT as
unsafe as if it came from the environment.

Also deduplicate some repeated code, and fix a missing mode in an
open(2) call with O_CREAT set.

Event: Oslo Hackathon 202508

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Aug 29 2025, 4:09 PM

Hmm...

  • Check failed: /home/philip/freebsd/src/lib/libc/tests/stdtime/detect_tz_changes_test.c:96: expect != buf (-0700 (PDT) != +0000 (-00))

Hmm...

  • Check failed: /home/philip/freebsd/src/lib/libc/tests/stdtime/detect_tz_changes_test.c:96: expect != buf (-0700 (PDT) != +0000 (-00))

Yes, the test successfully demonstrated that your libc has the bug fixed by D52240.

Hah. I forgot I did a previous installworld after reviewing D52240. I am not smart.
This looks good. And the test passes with the D52240 applied.

This revision is now accepted and ready to land.Aug 31 2025, 11:48 PM
This revision was automatically updated to reflect the committed changes.