Differential D52753

tzcode: Fix issues when TZ is an absolute path
ClosedPublic
Actions

Authored by des on Fri, Sep 26, 5:57 PM.

Tags

None

Referenced Files

	F132629256: D52753.id162890.diff
	Sat, Oct 18, 2:05 PM

	Unknown Object (File)
	Thu, Oct 16, 7:35 PM

	Unknown Object (File)
	Wed, Oct 15, 1:42 AM

	Unknown Object (File)
	Fri, Oct 10, 1:09 PM

	Unknown Object (File)
	Thu, Oct 9, 10:27 PM

	Unknown Object (File)
	Thu, Oct 9, 10:27 PM

	Unknown Object (File)
	Thu, Oct 9, 10:27 PM

	Unknown Object (File)
	Thu, Oct 9, 7:04 PM

View All 18 Files

Subscribers

Details

Reviewers

Commits

rG4048c39cfa6f: tzcode: Fix issues when TZ is an absolute path
rGdf8bc705eb04: tzcode: Fix issues when TZ is an absolute path

Summary

If TZ starts with TZDIR, strip any additional slashes so relname does not end up looking like an absolute path. For instance, TZ=/usr/share/zoneinfo//UTC should result in UTC, not /UTC.

In the setugid case, we were incorrectly passing name rather than relname to fstatat().

Modify the tz_env and tz_env_setugid test cases to exercise both of these scenarios.

Also add test cases for invalid values of TZ, which I wrote earlier but forgot to include in a5f14e4f9069.

Reported by: Paul Eggert <eggert@cs.ucla.edu>
MFC after: 3 days
Fixes: 967a49a21a27 ("Update tzcode to 2025b")
Fixes: a5f14e4f9069 ("tzcode: Use -00 only for invalid time zones")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Fri, Sep 26, 5:57 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Sep 26, 5:57 PM

des requested review of this revision.Fri, Sep 26, 5:57 PM

Harbormaster completed remote builds in B67353: Diff 162890.Fri, Sep 26, 5:57 PM

Thank you. And I'm glad to see upstream getting more in sync with us. ;-)

This revision is now accepted and ready to land.Fri, Sep 26, 11:36 PM

des added a parent revision: D52694: tzcode: Drop libc namespace.Sat, Sep 27, 12:16 AM

Closed by commit rGdf8bc705eb04: tzcode: Fix issues when TZ is an absolute path (authored by des). · Explain WhySat, Sep 27, 5:09 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGdf8bc705eb04: tzcode: Fix issues when TZ is an absolute path.

des added a commit: rG4048c39cfa6f: tzcode: Fix issues when TZ is an absolute path.Thu, Oct 2, 8:21 AM

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

2 lines

tests/

stdtime/

1 line

detect_tz_changes_test.c

90 lines

Diff 162954

lib/libc/gen/sysconf.c

Loading...

lib/libc/tests/stdtime/Makefile

Loading...

lib/libc/tests/stdtime/detect_tz_changes_test.c

Loading...