User Details
- User Since
- Sep 28 2014, 7:22 PM (633 w, 3 d)
Yesterday
To be honest I still find the justification for an entirely new bridge to be very thin.
That makes sense, and is similar to how fragments are handled during reassembly. (Which is to say, the rest of the stack can cope just fine with us returning PASS and m == NULL.)
I've taken my version mostly because it's a little closer to OpenBSD's code. There's nothing wrong with this patch, but I'm only fixing this once.
Thanks for the fix!
Wed, Nov 11
I’ll try to review this in detail next week, when I’m back.
Coincidentally I have a very similar patch I wrote yesterday.
I’ll figure out if I like yours or mine better when I’m back next week.
Mon, Nov 9
Mon, Nov 2
Fri, Oct 30
Should we try to account for a VLAN header here too?
Other than Mark's remark I think this looks good.
Other than not removing the pfvar.h include I'm happy with the pf changes, but please try to get someone to okay the addition in sys/time.h too.
Thu, Oct 29
Wed, Oct 21
Tue, Oct 20
Do we have measurements of what difference this makes?
Oct 19 2026
The commit message needs to answer the 'why' question.
Why do we want this? We already have if_bridge, what does veb do that if_bridge does not?
Oct 16 2026
Oct 15 2026
Oct 13 2026
Good, ship it ;)
That looks correct, but I don't quite follow the commit message. As far as I can tell nothing in userspace ever sends PF_ST_ID.
I suspect I left those out because nothing uses them, but we may as well add them to libpfctl anyway.
Given that we (Netgate certainly, and FreeBSD mostly too) no longer care about armv7 I wonder if we shouldn't back out the armv7 specific code from pf entirely at this point.
Oct 12 2026
Oct 11 2026
Oct 6 2026
Oct 3 2026
That test seems to fail for me with failed: 0 != 2 (0 != 2). The ping doesn't find a route:
Oct 2 2026
I wonder if we shouldn't just remove these versions of the get_states functions altogether.
Approved.
Oct 1 2026
Sep 30 2026
Sep 29 2026
Approved.
That looks sane, but I'd really like to have a test case for this as well.
