User Details
- User Since
- Sep 28 2014, 7:22 PM (533 w, 5 d)
Yesterday
Wed, Dec 18
Tue, Dec 17
Mon, Dec 16
I generally share Mark's views. I was tempted to suggest we should rename it to 'load-kmods' or similar, but there's a somewhat reasonable path to it also being able to install required packages (even if that will require test modifications), so keeping the generic name seems sensible. If we do get to that point we should consider adding a 'kyua prepare' or something to take care of all of the requirements (i.e. kmods, packages) it knows about. That should let us run (most) tests with kyua prepare && kyua test on a new install. (That's very much a maybe someday sort of thing, we do not need that to proceed here.)
Sat, Dec 14
Mon, Dec 9
Does this need an MFC tag too?
Wed, Dec 4
LGTM. Approved regardless of how you choose to deal with the remarks I've raised.
Tue, Dec 3
Mon, Dec 2
Fri, Nov 29
Approved.
Review remarks
Approved (without the 'draft' in the commit header line, of course).
Thu, Nov 28
review remarks
I need to have a closer look again tomorrow, but this looks like a good idea.
It expects to be applied on top of D47770, right?
rename PF_RT_RPOOL/PF_RT_NAT