Page MenuHomeFreeBSD

kp (Kristof Provost)
Troubleshooter

Projects (6)

User Details

User Since
Sep 28 2014, 7:22 PM (576 w, 7 h)

Recent Activity

Sat, Oct 11

kp committed rG1735d66a9c5b: pf tests: verify checksum offload handling (authored by kp).
pf tests: verify checksum offload handling
Sat, Oct 11, 12:04 PM
kp committed rG8a6bfa0455bf: pf tests: add missing atf_test_case lines for nat tests (authored by kp).
pf tests: add missing atf_test_case lines for nat tests
Sat, Oct 11, 12:04 PM
kp committed rG02923dd9b0de: dummynet: SDT probe dropped packets (authored by kp).
dummynet: SDT probe dropped packets
Sat, Oct 11, 12:04 PM
kp committed rG8217075f9ecb: pf tests: give rules_counter:4G more time (authored by kp).
pf tests: give rules_counter:4G more time
Sat, Oct 11, 12:04 PM
kp committed rGc70039393428: pf tests: give inetd some time to start (authored by kp).
pf tests: give inetd some time to start
Sat, Oct 11, 12:04 PM
kp committed rG98c1bf371c5d: pf tests: make syncookie:loopback more robust (authored by kp).
pf tests: make syncookie:loopback more robust
Sat, Oct 11, 12:04 PM

Fri, Oct 10

kp accepted D53022: if_vxlan: fix byteorder of source port.

LGTM

Fri, Oct 10, 12:56 PM
kp added inline comments to D45919: mv88e151x: fix potential attach and autonegotiation issues.
Fri, Oct 10, 12:34 PM
kp accepted D52906: mkimg: Add a -h option and improve usage output to be more expressive.

LGTM, ship it.

Fri, Oct 10, 12:16 PM
kp committed rG8638af3b2209: pf.conf.5: 'address' is mandatory with route-to (authored by kp).
pf.conf.5: 'address' is mandatory with route-to
Fri, Oct 10, 8:12 AM

Tue, Oct 7

kp accepted D52952: ipv6: don't complain when deleting an address with prefix length of 128.
Tue, Oct 7, 11:16 AM
kp committed rG306f29475fce: pf.conf.5: 'address' is mandatory with route-to (authored by kp).
pf.conf.5: 'address' is mandatory with route-to
Tue, Oct 7, 8:22 AM

Mon, Oct 6

kp committed rGb476593519e9: pfctl: check if the anchor exists before we attempt to flush anything from it (authored by kp).
pfctl: check if the anchor exists before we attempt to flush anything from it
Mon, Oct 6, 9:36 PM
kp committed rG8fecb09bc58e: pfctl: store correct ticket type (authored by kp).
pfctl: store correct ticket type
Mon, Oct 6, 9:36 PM

Sun, Oct 5

kp committed rG3e79ec993dc7: pf tests: fix intermittent mld test failures (authored by kp).
pf tests: fix intermittent mld test failures
Sun, Oct 5, 8:52 PM
kp committed rG4c7dba0c93fc: atf_python: allow test scripts to pass jail options (authored by kp).
atf_python: allow test scripts to pass jail options
Sun, Oct 5, 8:52 PM
kp committed rGff566e6b9b8f: pf: fix 'natpass' (authored by kp).
pf: fix 'natpass'
Sun, Oct 5, 8:52 PM
kp committed rGdd4095f11b1e: pf: return PF_PASS/PF_DROP from pf_setup_pdesc() (authored by kp).
pf: return PF_PASS/PF_DROP from pf_setup_pdesc()
Sun, Oct 5, 8:52 PM
kp committed rG48cbd5698d9b: pf: fix possibe SCTP panic (authored by kp).
pf: fix possibe SCTP panic
Sun, Oct 5, 8:52 PM

Sat, Oct 4

kp added a comment to D52852: vxlan: support moving to a different vnet.

I've ever considered this approach, but this adds too many headaches. Well I'd propose to use vlxan(4) + bridge(4) + epair(4) if the underlay network is in different VNET.

For example, how can the admin change the tunnel parameters ( vni / vxlanlocal / vxlanremote / ports ) when the vxlan(4) interface is vmoved to another VNET ?

Sat, Oct 4, 9:00 AM

Thu, Oct 2

kp committed rGb93394a38bc4: pf: fix 'natpass' (authored by kp).
pf: fix 'natpass'
Thu, Oct 2, 8:48 PM
kp closed D52838: pf: fix 'natpass'.
Thu, Oct 2, 8:48 PM
kp committed rG5d210f396e3f: pf: return PF_PASS/PF_DROP from pf_setup_pdesc() (authored by kp).
pf: return PF_PASS/PF_DROP from pf_setup_pdesc()
Thu, Oct 2, 7:20 PM
kp committed rGdd2fc08d8543: pf: fix possibe SCTP panic (authored by kp).
pf: fix possibe SCTP panic
Thu, Oct 2, 7:20 PM
kp committed rGf9fc93690aef: sys/netinet6: fix memory corruption in in6_ifadd (authored by mjg).
sys/netinet6: fix memory corruption in in6_ifadd
Thu, Oct 2, 2:26 PM
kp committed rGc23b64fba9fb: netinet6 tests: accept an RA on an interface without /64 address (authored by kp).
netinet6 tests: accept an RA on an interface without /64 address
Thu, Oct 2, 2:26 PM
kp added a comment to D52852: vxlan: support moving to a different vnet.

if_vmove bites again? I'm fine with adding more kludges around this problem as long as we all agree that eventually this thing needs to be removed and interfaces shall be fully destroyed and fully instantiated in a different jail.

Thu, Oct 2, 12:47 PM
kp requested review of D52853: vxlan tests: move a vxlan interface into a jail.
Thu, Oct 2, 12:36 PM
kp requested review of D52852: vxlan: support moving to a different vnet.
Thu, Oct 2, 12:35 PM
kp requested review of D52851: vxlan: support VNET.
Thu, Oct 2, 12:35 PM
kp committed rG244a5188e768: pf: mark pf_match_translation() static (authored by kp).
pf: mark pf_match_translation() static
Thu, Oct 2, 10:02 AM
kp accepted D52825: ip6+carp: revise the generation of ND6 NA.
Thu, Oct 2, 8:35 AM

Wed, Oct 1

kp requested review of D52838: pf: fix 'natpass'.
Wed, Oct 1, 8:18 PM
kp added a reverting change for rG4e7a375804e5: IfAPI: Added missing accessor for if_home_vnet: rGebb60d47a535: Revert "IfAPI: Added missing accessor for if_home_vnet".
Wed, Oct 1, 4:57 PM
kp committed rGebb60d47a535: Revert "IfAPI: Added missing accessor for if_home_vnet" (authored by kp).
Revert "IfAPI: Added missing accessor for if_home_vnet"
Wed, Oct 1, 4:57 PM
kp committed rGbdb205c53ed7: libpfctl: fix memory leak in pfctl_get_status() (authored by kp).
libpfctl: fix memory leak in pfctl_get_status()
Wed, Oct 1, 12:19 PM

Tue, Sep 30

kp committed rGa57f6ce4792f: pf tests: fix intermittent mld test failures (authored by kp).
pf tests: fix intermittent mld test failures
Tue, Sep 30, 12:54 PM
kp committed rG2213e158886f: atf_python: allow test scripts to pass jail options (authored by kp).
atf_python: allow test scripts to pass jail options
Tue, Sep 30, 12:54 PM
kp closed D52762: pf tests: fix intermittent mld test failures.
Tue, Sep 30, 12:54 PM
kp closed D52761: atf_python: allow test scripts to pass jail options.
Tue, Sep 30, 12:53 PM

Mon, Sep 29

kp committed rG4e7a375804e5: IfAPI: Added missing accessor for if_home_vnet (authored by ItzBlinkzy <kitey13579@gmail.com>).
IfAPI: Added missing accessor for if_home_vnet
Mon, Sep 29, 9:17 PM

Sun, Sep 28

kp accepted D50825: libexec/kgdb: Add a new VNET function and add more scaffolding.

I'm not qualified to review this in depth, but with the prerequisite patch included this works and is very, very useful.

Sun, Sep 28, 1:43 PM

Sat, Sep 27

kp added a comment to D50825: libexec/kgdb: Add a new VNET function and add more scaffolding.

I may be holding it wrong, but it still breaks for me:
It's a panic in vnet shutdown, so perhaps it's related to that:

Sat, Sep 27, 3:50 PM
kp requested review of D52762: pf tests: fix intermittent mld test failures.
Sat, Sep 27, 3:24 PM
kp requested review of D52761: atf_python: allow test scripts to pass jail options.
Sat, Sep 27, 3:23 PM

Thu, Sep 25

kp committed rGb84666f798e8: pf: export expiration time as time_t (authored by kp).
pf: export expiration time as time_t
Thu, Sep 25, 12:42 PM
kp committed rG08fbad1b135b: pfctl: refactor 'rule_numbers' variable (authored by kp).
pfctl: refactor 'rule_numbers' variable
Thu, Sep 25, 12:42 PM
kp committed rGc913959e9e03: pf tests: basic 'once' test (authored by kp).
pf tests: basic 'once' test
Thu, Sep 25, 12:42 PM
kp committed rG2c53e251601c: pf tests: test once rule inside an anchor (authored by kp).
pf tests: test once rule inside an anchor
Thu, Sep 25, 12:42 PM
kp committed rG64bfb82f1741: pfctl: print once shot rule expiration time (authored by kp).
pfctl: print once shot rule expiration time
Thu, Sep 25, 12:42 PM
kp committed rGceff35a3aeef: pfctl: fix anchor handling for nat/rdr/binat anchors (authored by kp).
pfctl: fix anchor handling for nat/rdr/binat anchors
Thu, Sep 25, 12:42 PM
kp committed rGcc97633b4b7a: pfctl.8/pf.conf.5: Improve "once" bits (authored by kp).
pfctl.8/pf.conf.5: Improve "once" bits
Thu, Sep 25, 12:42 PM
kp committed rGde8af57c6f41: pf: simplify expiration of 'once' rules. (authored by kp).
pf: simplify expiration of 'once' rules.
Thu, Sep 25, 12:42 PM
kp committed rG59f3838b0a94: pfctl: reduce duplicate code (authored by kp).
pfctl: reduce duplicate code
Thu, Sep 25, 12:42 PM
kp committed rG2be46b52f5db: pfctl: fix once rules (authored by kp).
pfctl: fix once rules
Thu, Sep 25, 12:42 PM
kp committed rGb9d652bb75ff: pf: print 'once' rule expire time (authored by kp).
pf: print 'once' rule expire time
Thu, Sep 25, 12:42 PM
kp committed rGd3b73a944b11: pfctl: deny "once" flags for match rules (authored by kp).
pfctl: deny "once" flags for match rules
Thu, Sep 25, 12:42 PM
kp committed rGb7ff11b380bf: pf.conf.5: Document a "once" filter option used to create one shot rules. (authored by kp).
pf.conf.5: Document a "once" filter option used to create one shot rules.
Thu, Sep 25, 12:42 PM
kp committed rG8a4386142d05: pfctl tests: basic 'once' rule test (authored by kp).
pfctl tests: basic 'once' rule test
Thu, Sep 25, 12:42 PM
kp committed rGaf922319e813: pf: support one shot rules (authored by kp).
pf: support one shot rules
Thu, Sep 25, 12:42 PM
kp committed rG882121672704: pfctl: One shot rules can be used in pf.conf by specifying a "once" filter… (authored by kp).
pfctl: One shot rules can be used in pf.conf by specifying a "once" filter…
Thu, Sep 25, 12:42 PM

Wed, Sep 24

kp committed rGe70a2bcdc4f7: pf: fix rules_counter:keepcounters test (authored by kp).
pf: fix rules_counter:keepcounters test
Wed, Sep 24, 1:41 PM
kp accepted D52448: pf: Fix interface counters for af-to rules.
Wed, Sep 24, 11:48 AM
kp committed rG7ec06143964a: pf: pass pre-NAT addresses to dummynet (authored by kp).
pf: pass pre-NAT addresses to dummynet
Wed, Sep 24, 11:45 AM
kp committed rGdc0cf0648c8d: pf: check if a group has a kif before dereferencing it (authored by kp).
pf: check if a group has a kif before dereferencing it
Wed, Sep 24, 11:45 AM
kp accepted D52447: pf: Fix rule and state counters.
Wed, Sep 24, 11:38 AM
kp accepted D52446: pf: Always skip outbound filtering for inbound af-to rules.
Wed, Sep 24, 11:31 AM

Fri, Sep 19

kp accepted D52176: pf: Add pfsync protocol for FreeBSD 15.
Fri, Sep 19, 8:21 AM

Thu, Sep 18

kp accepted D52445: pf: Fix interface binding for af-to with route-to.
Thu, Sep 18, 7:32 AM

Wed, Sep 17

kp committed rGe63534edbcd0: pf: fix rules_counter:keepcounters test (authored by kp).
pf: fix rules_counter:keepcounters test
Wed, Sep 17, 2:16 PM
kp committed rG3c3322d7ee97: pf.conf.5: rephrase macro section (authored by kp).
pf.conf.5: rephrase macro section
Wed, Sep 17, 2:16 PM
kp committed rGc016bd00294d: pfctl.8: -z honours -a (reset rule stats per anchor) (authored by kp).
pfctl.8: -z honours -a (reset rule stats per anchor)
Wed, Sep 17, 2:16 PM
kp committed rGfc63421de9f6: pf: allows TCP RST packets in the backwards window if ACK matches (authored by kp).
pf: allows TCP RST packets in the backwards window if ACK matches
Wed, Sep 17, 2:16 PM
kp committed rG7eb30b26aa12: pf tests: test set limit (authored by kp).
pf tests: test set limit
Wed, Sep 17, 2:16 PM
kp committed rG9d9bc7f462bd: pf: set limits before rules (authored by kp).
pf: set limits before rules
Wed, Sep 17, 2:16 PM
kp committed rG1066515eb521: pf: Count m_gethdr() failures in PFRES_MEMORY counter (authored by kp).
pf: Count m_gethdr() failures in PFRES_MEMORY counter
Wed, Sep 17, 2:16 PM
kp committed rG05e99f5d1751: pfctl.8: omit preceding flag from command/modifier lists to get tags (authored by kp).
pfctl.8: omit preceding flag from command/modifier lists to get tags
Wed, Sep 17, 2:16 PM
kp committed rG26c373aa367c: pf tests: declare a table inside an anchor (authored by kp).
pf tests: declare a table inside an anchor
Wed, Sep 17, 2:16 PM
kp committed rG9dfc5e03da50: pfctl: allow tables to be defined inside anchors (authored by kp).
pfctl: allow tables to be defined inside anchors
Wed, Sep 17, 2:16 PM
kp committed rG6e00a34c7613: ifconfig: also fix removing IPv6 addresses without netlink (authored by kp).
ifconfig: also fix removing IPv6 addresses without netlink
Wed, Sep 17, 8:09 AM
kp committed rG44d7a8298eae: ifconfig: also fix removing IPv6 addresses without netlink (authored by kp).
ifconfig: also fix removing IPv6 addresses without netlink
Wed, Sep 17, 8:09 AM

Mon, Sep 15

kp added inline comments to D52447: pf: Fix rule and state counters.
Mon, Sep 15, 1:03 PM
kp committed rGd0ea3de0fe71: pf tests: verify rule numbers in pflog output (authored by kp).
pf tests: verify rule numbers in pflog output
Mon, Sep 15, 11:55 AM
kp committed rG8e84e9443bb6: pfctl: remove prototypes with no matching function (authored by kp).
pfctl: remove prototypes with no matching function
Mon, Sep 15, 11:55 AM
kp committed rGa66df2b575c8: pf: sync_ifp doesn't exist, remove externs (authored by kp).
pf: sync_ifp doesn't exist, remove externs
Mon, Sep 15, 11:55 AM
kp committed rG2c42aecee696: pfctl: ctime(3) and ctime_r(3) can fail when timestamps are way off. (authored by kp).
pfctl: ctime(3) and ctime_r(3) can fail when timestamps are way off.
Mon, Sep 15, 11:55 AM
kp committed rG5e89648ee68e: pf tests: test fragment counters (authored by kp).
pf tests: test fragment counters
Mon, Sep 15, 11:55 AM
kp committed rGc00aca9a714e: pf: Show pf fragment reassembly counters. (authored by kp).
pf: Show pf fragment reassembly counters.
Mon, Sep 15, 11:55 AM
kp committed rG0a67f601fe4f: pf.conf.5: hint how to set tcp timeout collectively (authored by kp).
pf.conf.5: hint how to set tcp timeout collectively
Mon, Sep 15, 11:55 AM
kp committed rG79a0959affec: pfctl: add af-to and other missing action types in print_rule() (authored by kp).
pfctl: add af-to and other missing action types in print_rule()
Mon, Sep 15, 11:55 AM
kp committed rGc2d03a920ec7: pfctl: fix anchortypes bounds test (authored by kp).
pfctl: fix anchortypes bounds test
Mon, Sep 15, 11:55 AM
kp committed rG864458ce5025: pf.conf.5: document tcp.tsdiff (authored by kp).
pf.conf.5: document tcp.tsdiff
Mon, Sep 15, 11:55 AM
kp added inline comments to D52445: pf: Fix interface binding for af-to with route-to.
Mon, Sep 15, 7:11 AM
kp accepted D52543: if_ovpn.c: fix use of uninitialized variable.
Mon, Sep 15, 6:26 AM

Sat, Sep 13

kp committed rG4403631977a0: pf: fix possible pd->pcksum NULL deref (authored by kp).
pf: fix possible pd->pcksum NULL deref
Sat, Sep 13, 1:13 PM

Sep 12 2025

kp committed rG995d95c309fc: if_ovpn tests: skip float and linklocal test on < 2.7 (authored by kp).
if_ovpn tests: skip float and linklocal test on < 2.7
Sep 12 2025, 6:59 AM

Sep 10 2025

kp committed rGc8fb5a4d032b: ifconfig: also fix removing IPv6 addresses without netlink (authored by kp).
ifconfig: also fix removing IPv6 addresses without netlink
Sep 10 2025, 7:53 PM
kp committed rG53e44c59d13e: pf tests: test state killing by source and destination address (authored by kp).
pf tests: test state killing by source and destination address
Sep 10 2025, 7:53 PM
kp committed rG4889545b8795: pfctl: fix killing state by source and destination address (authored by kp).
pfctl: fix killing state by source and destination address
Sep 10 2025, 7:53 PM
kp committed rGd3020caed603: pf tests: recusrive table printing test (authored by kp).
pf tests: recusrive table printing test
Sep 10 2025, 7:52 PM