Page MenuHomeFreeBSD

kp (Kristof Provost)
Troubleshooter

Projects (6)

User Details

User Since
Sep 28 2014, 7:22 PM (594 w, 4 d)

Recent Activity

Yesterday

kp committed rG4d0186cd12a7: libpfctl: Sort order of snl attribute parser (authored by eborisch_gmail.com).
libpfctl: Sort order of snl attribute parser
Thu, Feb 19, 4:01 PM
kp committed rGdc7eb96ba945: pf tests: verify blocked count on log interface (authored by kp).
pf tests: verify blocked count on log interface
Thu, Feb 19, 4:01 PM
kp accepted D55367: icmp6: Remove csum_flags on mbuf reused for ICMP message.

(Not tested, but that just seems sensible.)

Thu, Feb 19, 12:47 PM

Wed, Feb 18

kp committed rGd60082f16e4c: pf: avoid NULL deref on purged states (authored by kp).
pf: avoid NULL deref on purged states
Wed, Feb 18, 10:27 PM

Tue, Feb 17

kp committed rGf3a0e54656cc: pf: fix use of uninitialised variable (authored by kp).
pf: fix use of uninitialised variable
Tue, Feb 17, 2:30 PM

Mon, Feb 16

kp committed rG281282e9357b: pf: convert DIOCRTSTADDRS to netlink (authored by kp).
pf: convert DIOCRTSTADDRS to netlink
Mon, Feb 16, 12:47 PM

Thu, Feb 12

kp committed rG363b57d579ba: libpfctl: Sort order of snl attribute parser (authored by eborisch_gmail.com).
libpfctl: Sort order of snl attribute parser
Thu, Feb 12, 9:40 PM
kp committed rGd03b6bb766f8: pf tests: verify blocked count on log interface (authored by kp).
pf tests: verify blocked count on log interface
Thu, Feb 12, 9:40 PM
kp committed rG1e7665e36860: libpfctl: verify all parsers (authored by kp).
libpfctl: verify all parsers
Thu, Feb 12, 9:40 PM
kp committed rGff2f3a6cc1b7: pf: fix pcounters array size (authored by kp).
pf: fix pcounters array size
Thu, Feb 12, 2:16 PM

Tue, Feb 10

kp committed rG950dedcd87af: pf: remove unused variable from pf_test_ctx (authored by kp).
pf: remove unused variable from pf_test_ctx
Tue, Feb 10, 5:12 PM

Mon, Feb 9

kp committed R11:7f4afbdfcf93: net/libpfctl: add 14.4 version (authored by kp).
net/libpfctl: add 14.4 version
Mon, Feb 9, 5:04 PM

Tue, Feb 3

kp committed rGfe9e4eb6f38a: pf: fix use of uninitialised variable (authored by kp).
pf: fix use of uninitialised variable
Tue, Feb 3, 10:52 PM

Wed, Jan 28

kp committed rG03094f3700be: if_ovpn: add interface counters (authored by kp).
if_ovpn: add interface counters
Wed, Jan 28, 7:21 PM
kp committed rGd2d25d8fde2e: pfctl: allow new page character (^L) in pf.conf (authored by kp).
pfctl: allow new page character (^L) in pf.conf
Wed, Jan 28, 7:21 PM
kp committed rG1b7a44fbc553: if_ovpn: add interface counters (authored by kp).
if_ovpn: add interface counters
Wed, Jan 28, 7:21 PM
kp committed rG19709a0cd866: pfctl: allow new page character (^L) in pf.conf (authored by kp).
pfctl: allow new page character (^L) in pf.conf
Wed, Jan 28, 7:21 PM

Tue, Jan 27

kp accepted D54847: pf: Pass v6 packets to the divert socket.
Tue, Jan 27, 11:05 AM

Sat, Jan 24

kp accepted D54848: divert: Update divert.4 to mention pf.
Sat, Jan 24, 11:42 AM
kp accepted D54846: pf tests: Set require.kmods in divert-to tests.
Sat, Jan 24, 11:41 AM
kp accepted D54845: pf: Rationalize the ip_divert_ptr test.
Sat, Jan 24, 11:41 AM

Fri, Jan 23

kp accepted D19960: Remove support for RFC2675.
In D19960#1253517, @thj wrote:

I don't think there are any links with an mtu to carry 65,575, but if there
ever are I would expect to find some bugs.

Fri, Jan 23, 2:16 PM

Jan 20 2026

kp committed rG2c42d62fd3a1: pf: fix min-ttl and set-tos for nat64 (authored by kp).
pf: fix min-ttl and set-tos for nat64
Jan 20 2026, 9:55 PM

Jan 19 2026

kp committed rG2e0e45a516b9: pfctl(8): change default limiter action from no-match to block (authored by kp).
pfctl(8): change default limiter action from no-match to block
Jan 19 2026, 10:58 PM

Jan 15 2026

kp committed rG21d666a19331: if_ovpn: add interface counters (authored by kp).
if_ovpn: add interface counters
Jan 15 2026, 5:15 PM

Jan 14 2026

kp committed rGfc353e5e61fa: pfctl: allow new page character (^L) in pf.conf (authored by kp).
pfctl: allow new page character (^L) in pf.conf
Jan 14 2026, 11:33 AM
kp added a comment to D54695: pf: tests: Introduce wait_for_process().

I'm not sure this is sufficient. It is still possible for tcpdump to have started, but not gotten to the point of actually opening the pflog device.

Jan 14 2026, 8:22 AM
kp committed rG3a609881c8c8: pf: remove unused function (authored by kp).
pf: remove unused function
Jan 14 2026, 8:07 AM
kp committed rG098febfcc155: pf tests: test block/no-match limiters (authored by kp).
pf tests: test block/no-match limiters
Jan 14 2026, 8:07 AM
kp committed rGe28dfd6b5557: pfctl: make the source limiter output match the input (authored by kp).
pfctl: make the source limiter output match the input
Jan 14 2026, 8:07 AM
kp committed rG8716d8c7d97e: pf: configurable action on limiter exceeded (authored by kp).
pf: configurable action on limiter exceeded
Jan 14 2026, 8:07 AM
kp committed rG1ee4405a00d7: pf: avoid a shadowed variable in the pf_create_state() source limiter handling (authored by kp).
pf: avoid a shadowed variable in the pf_create_state() source limiter handling
Jan 14 2026, 8:07 AM
kp committed rG393243a38d74: pfctl: ifa_load() in pfctl_parser.c may attempt to read beyond the buffer. (authored by kp).
pfctl: ifa_load() in pfctl_parser.c may attempt to read beyond the buffer.
Jan 14 2026, 8:07 AM
kp committed rG1550fcf802e3: pf.conf.5: s/State Limiter/&s/ in .Ss (authored by kp).
pf.conf.5: s/State Limiter/&s/ in .Ss
Jan 14 2026, 8:07 AM
kp committed rG7af7d6d61d41: pfctl: distinguish broadcast and PPP peer addresses (authored by kp).
pfctl: distinguish broadcast and PPP peer addresses
Jan 14 2026, 8:07 AM
kp committed rG95ee802f410f: pf: state/source limiter finishing touches (authored by kp).
pf: state/source limiter finishing touches
Jan 14 2026, 8:07 AM
kp committed rGf2d2d6f010e4: pf: remove redundant range checks (authored by kp).
pf: remove redundant range checks
Jan 14 2026, 8:07 AM
kp committed rG02126f8cb35c: pf.conf.5: spelling (authored by kp).
pf.conf.5: spelling
Jan 14 2026, 8:06 AM
kp committed rGa10e8e78c8d0: pf tests: basic state limiters test case (authored by kp).
pf tests: basic state limiters test case
Jan 14 2026, 8:06 AM
kp committed rGe3319f91900b: pf tests: extend the source limiter test (authored by kp).
pf tests: extend the source limiter test
Jan 14 2026, 8:06 AM
kp committed rG086a3cb4b850: pf tests: basic source limiters test case (authored by kp).
pf tests: basic source limiters test case
Jan 14 2026, 8:06 AM
kp committed rGcb7a5d9401d8: pf tests: state limiter rate test (authored by kp).
pf tests: state limiter rate test
Jan 14 2026, 8:06 AM
kp committed rG445a3c86e674: pfctl tests: basic source and state limiter tests (authored by kp).
pfctl tests: basic source and state limiter tests
Jan 14 2026, 8:06 AM
kp committed rG398ca30cb6d6: pfctl.8: mention -k source -k <IP> (authored by kp).
pfctl.8: mention -k source -k <IP>
Jan 14 2026, 8:06 AM
kp committed rG63d5d1b0b37e: pfctl: improve limiters printing (authored by kp).
pfctl: improve limiters printing
Jan 14 2026, 8:06 AM
kp committed rGaafa123641be: pfctl: resolve '-s' ambiguity (authored by kp).
pfctl: resolve '-s' ambiguity
Jan 14 2026, 8:06 AM
kp committed rGc72fb110e47f: pf: convert state limiter interface to netlink (authored by kp).
pf: convert state limiter interface to netlink
Jan 14 2026, 8:06 AM
kp committed rG461648121230: pf: introduce source and state limiters (authored by kp).
pf: introduce source and state limiters
Jan 14 2026, 8:06 AM

Jan 10 2026

kp committed rG71f4eb518cd9: pf: don't reject route-to'd too-large packets (authored by kp).
pf: don't reject route-to'd too-large packets
Jan 10 2026, 10:23 AM

Jan 8 2026

kp committed rG0df9054bc116: pf: handle nlattr_add_nested() failure (authored by kp).
pf: handle nlattr_add_nested() failure
Jan 8 2026, 12:28 PM
kp committed rGbf19253516ec: pf: remove redundant zeroing (authored by kp).
pf: remove redundant zeroing
Jan 8 2026, 12:28 PM

Jan 6 2026

kp accepted D54549: pf: tests: Require python3.
Jan 6 2026, 10:42 AM

Jan 3 2026

kp added a comment to D54382: MFC sys/netinet6: Implement RFC 7217 (private stable addresses).

Forgot to add references:

[1] 9e792f7ef7298080c058fbc2d36a4e60e596dae9

Jan 3 2026, 12:04 PM

Jan 2 2026

kp committed rGfb476c703117: pf: sprinkle const over pf_addr_cmp() (authored by kp).
pf: sprinkle const over pf_addr_cmp()
Jan 2 2026, 4:19 PM

Dec 30 2025

kp committed rG4fecc8e3fe94: pfctl: remove duplicate "va" entry (authored by kp).
pfctl: remove duplicate "va" entry
Dec 30 2025, 11:29 PM
kp committed rG2eec2bcca297: pf tests: avoid cleanup failures on skipped tests (authored by kp).
pf tests: avoid cleanup failures on skipped tests
Dec 30 2025, 1:17 PM
kp committed rG96c7e70c18a4: pf: convert DIOCRCLRASTATS to netlink (authored by kp).
pf: convert DIOCRCLRASTATS to netlink
Dec 30 2025, 1:17 PM
kp committed rGc2e7a52374b3: pf: move DIOCRCLRASTATS into libpfctl (authored by kp).
pf: move DIOCRCLRASTATS into libpfctl
Dec 30 2025, 1:17 PM
kp committed rG190c1f3d9326: pfctl: allow network programs select DSCP_VA for network ToS (authored by kp).
pfctl: allow network programs select DSCP_VA for network ToS
Dec 30 2025, 1:17 PM

Dec 29 2025

kp committed rG261642478c8e: pf: handle TTL expired during nat64 (authored by kp).
pf: handle TTL expired during nat64
Dec 29 2025, 10:14 AM

Dec 26 2025

kp accepted D54363: kyua: Make "debug -p" skip writing stdout/stderr to tmp files.
Dec 26 2025, 3:08 PM
kp committed rGeaa424e3bde8: snmp_pf: remove errno usage after pfctl_get_status_h change (authored by rootnode_freebsd_wollwage.com).
snmp_pf: remove errno usage after pfctl_get_status_h change
Dec 26 2025, 12:45 PM
kp committed rG2e7699355f08: pf: don't reject route-to'd too-large packets (authored by kp).
pf: don't reject route-to'd too-large packets
Dec 26 2025, 10:49 AM

Dec 22 2025

kp committed rG4f35a84b3241: atf_python: support setting interface mtu (authored by kp).
atf_python: support setting interface mtu
Dec 22 2025, 4:29 PM
kp closed D54333: atf_python: support setting interface mtu.
Dec 22 2025, 4:29 PM

Dec 21 2025

kp requested review of D54333: atf_python: support setting interface mtu.
Dec 21 2025, 5:35 PM
kp committed rG622d7fa18d33: pf: fix pcounters array size (authored by kp).
pf: fix pcounters array size
Dec 21 2025, 5:34 PM
kp committed rG823ebd7c4f89: libpfctl: export a get states variant that takes a pfctl_handle (authored by kp).
libpfctl: export a get states variant that takes a pfctl_handle
Dec 21 2025, 5:34 PM

Dec 20 2025

kp accepted D54321: pf: Fix state handling when ICMP packets are diverted.
Dec 20 2025, 3:17 PM

Dec 19 2025

kp accepted D54292: pf: Avoid taking the pf rules write lock in a couple of ioctls.

DIOCGETRULENV takes the write lock as well but I believe this is only
required when clearing rule counters. (It might not be required even
then, on platforms where counter increment is done atomically.) Acquire
the read lock if that is not the case.

Dec 19 2025, 1:18 PM

Dec 18 2025

kp committed rGa862e4b5a27c: snmp_pf: fix refresh (authored by kp).
snmp_pf: fix refresh
Dec 18 2025, 1:45 PM
kp committed rGad7f49f98b1a: libpfctl: fix tstats address count (authored by kp).
libpfctl: fix tstats address count
Dec 18 2025, 1:45 PM

Dec 17 2025

kp committed rG394d701c41ec: if_ovpn: use epoch to free peers (authored by kp).
if_ovpn: use epoch to free peers
Dec 17 2025, 10:06 AM
kp committed rGd19083e833d7: if_ovpn: use epoch to free peers (authored by kp).
if_ovpn: use epoch to free peers
Dec 17 2025, 10:06 AM

Dec 15 2025

kp added inline comments to D54105: kyua: Add flaky metadata.
Dec 15 2025, 9:19 PM
kp committed rGcdbc9b76ff49: pf: fix min-ttl and set-tos for nat64 (authored by kp).
pf: fix min-ttl and set-tos for nat64
Dec 15 2025, 4:26 PM
kp accepted D54199: pf: Fix the reply command in a couple of places.
Dec 15 2025, 9:47 AM

Dec 13 2025

kp committed rG1dee2336ab44: pfctl: report ICMP states consistently for IPv4/IPv6 (authored by kp).
pfctl: report ICMP states consistently for IPv4/IPv6
Dec 13 2025, 9:51 PM

Dec 11 2025

kp added a comment to D54175: if_ovpn: fix memory leak in VNET.

I believe that was accidentally broken by 96b29c7f0cffd377a757ad8ccc0cdd8fcb96d0dd, which fixed the issue of jails being unable to go away while they still had ovpn interfaces in them. It fixed that, but also removed the VNET_SYSUNINIT that prevented this leak.

Dec 11 2025, 3:10 PM
kp accepted D54163: pfsync: Avoid zeroing the state export union.
Dec 11 2025, 11:09 AM
kp committed rGac4fb06d096d: pf: handle TTL expired during nat64 (authored by kp).
pf: handle TTL expired during nat64
Dec 11 2025, 10:36 AM
kp closed D54166: pf: handle TTL expired during nat64.
Dec 11 2025, 10:36 AM
kp committed rG7b4482f3834a: pf: relax sctp v_tag verification (authored by kp).
pf: relax sctp v_tag verification
Dec 11 2025, 9:27 AM
kp committed rGcc638b24d56a: pf: relax sctp v_tag verification (authored by kp).
pf: relax sctp v_tag verification
Dec 11 2025, 9:27 AM
kp committed rGf629ee03fa78: libpfctl: improve error handling (authored by kp).
libpfctl: improve error handling
Dec 11 2025, 9:26 AM
kp committed rGa717a40f8449: pf: relax sctp v_tag verification (authored by kp).
pf: relax sctp v_tag verification
Dec 11 2025, 9:26 AM

Dec 10 2025

kp requested review of D54166: pf: handle TTL expired during nat64.
Dec 10 2025, 8:04 PM
kp added a reviewer for D54163: pfsync: Avoid zeroing the state export union: vegeta_tuxpowered.net.
Dec 10 2025, 4:21 PM

Dec 9 2025

kp added a comment to D54148: netlink: Don't overwrite existing data in a linear buffer in snl_writer.

Ah, thanks. With the original patch reverted this applies and works as expected.
I'm not all that familiar with this code, but it works and I don't see any obvious problems (and it addresses the problem CHERI found, being that we used more than 'new_size' from 'new_base'.)

Dec 9 2025, 5:00 PM
kp committed rG5e2bbfe387f7: if_ovpn: use epoch to free peers (authored by kp).
if_ovpn: use epoch to free peers
Dec 9 2025, 2:20 PM
kp committed rGb2d547abb76f: pfsync: fix incorrect unlock during destroy (authored by kp).
pfsync: fix incorrect unlock during destroy
Dec 9 2025, 11:19 AM
kp committed rGc09ffa69b6c9: pfctl: restore '-Tload -f pf.conf' functionality (authored by kp).
pfctl: restore '-Tload -f pf.conf' functionality
Dec 9 2025, 11:19 AM
kp committed rGa06df4218348: pfsync: fix incorrect unlock during destroy (authored by kp).
pfsync: fix incorrect unlock during destroy
Dec 9 2025, 11:19 AM
kp committed rG9b2551051fce: pfsync: fix incorrect unlock during destroy (authored by kp).
pfsync: fix incorrect unlock during destroy
Dec 9 2025, 11:19 AM
kp added a comment to D54148: netlink: Don't overwrite existing data in a linear buffer in snl_writer.

What's this based on? It doesn't seem to want to apply to FreeBSD main (f9500e75791cf793904c80ca4a52433afd585a23).

Dec 9 2025, 10:47 AM

Dec 8 2025

kp accepted D54094: pf: Fix error handling in pf_handle_get_tstats().
Dec 8 2025, 12:04 PM

Dec 5 2025

kp accepted D54083: pf: Fix an off-by-one in pf_handle_getcreators().
Dec 5 2025, 2:52 PM
kp committed rGf6aa57c86b62: snmp_pf: use the libpfctl wrapper to retrieve astats (authored by kp).
snmp_pf: use the libpfctl wrapper to retrieve astats
Dec 5 2025, 1:10 PM
kp committed rG08f54dfca197: pf: convert DIOCRGETASTATS to netlink (authored by kp).
pf: convert DIOCRGETASTATS to netlink
Dec 5 2025, 1:10 PM
kp committed rG4aa79010bcea: pfctl: move astats query into libpfctl (authored by kp).
pfctl: move astats query into libpfctl
Dec 5 2025, 1:10 PM