Page MenuHomeFreeBSD

kp (Kristof Provost)
Troubleshooter

Projects (6)

User Details

User Since
Sep 28 2014, 7:22 PM (579 w, 4 d)

Recent Activity

Wed, Nov 5

kp committed rGf939619a2f98: UPDATING: mention pf's nat64 support (authored by kp).
UPDATING: mention pf's nat64 support
Wed, Nov 5, 2:01 PM
kp committed rGf27e44e2e3b5: pf: convert DIOCRGETADDRS to netlink (authored by kp).
pf: convert DIOCRGETADDRS to netlink
Wed, Nov 5, 2:01 PM
kp committed rG9bb1c46b4c38: libpfctl: fix error handling (authored by kp).
libpfctl: fix error handling
Wed, Nov 5, 2:01 PM

Mon, Nov 3

kp committed rGcd7f3e4d9e83: pf.conf.5: add nat-to/rdr-to to BNF (authored by kp).
pf.conf.5: add nat-to/rdr-to to BNF
Mon, Nov 3, 4:06 PM
kp accepted D53515: pf: Add RELNOTES information about new features.
Mon, Nov 3, 3:40 PM
kp committed rGd481c3db42dc: pf: improve DIOCRCLRTABLES validation (authored by kp).
pf: improve DIOCRCLRTABLES validation
Mon, Nov 3, 8:39 AM
kp committed rG70154de06926: pf: improve add state validation (authored by kp).
pf: improve add state validation
Mon, Nov 3, 8:39 AM
kp committed rG4891e6f1c0ee: pf: improve add state validation (authored by kp).
pf: improve add state validation
Mon, Nov 3, 8:39 AM
kp committed rG909528f8a130: pf: improve DIOCRCLRTABLES validation (authored by kp).
pf: improve DIOCRCLRTABLES validation
Mon, Nov 3, 8:39 AM
kp committed rG8f92db3cf540: pf: improve DIOCRCLRTABLES validation (authored by kp).
pf: improve DIOCRCLRTABLES validation
Mon, Nov 3, 8:39 AM
kp committed rGba198fe8a03b: pf: improve add state validation (authored by kp).
pf: improve add state validation
Mon, Nov 3, 8:39 AM

Fri, Oct 31

kp committed rG08ed87a4a276: pf: convert DIOCRSETADDRS to netlink (authored by kp).
pf: convert DIOCRSETADDRS to netlink
Fri, Oct 31, 3:29 PM
kp committed rG56d5ec30e8e1: pf tests: pfctl -T replace test (authored by kp).
pf tests: pfctl -T replace test
Fri, Oct 31, 3:29 PM

Thu, Oct 30

kp committed rGfaacc0d96881: pf: improve add state validation (authored by kp).
pf: improve add state validation
Thu, Oct 30, 10:08 AM
kp committed rG1da3c0ca5b1d: pf: improve DIOCRCLRTABLES validation (authored by kp).
pf: improve DIOCRCLRTABLES validation
Thu, Oct 30, 10:08 AM

Wed, Oct 29

kp committed rGf17856896d32: pfctl: only set limit restore handler if limits are changed (authored by kp).
pfctl: only set limit restore handler if limits are changed
Wed, Oct 29, 8:52 PM
kp accepted D53231: pf: Check if source nodes use a valid redirection address.

Do you have a specific OpenBSD patch you obtained this from?

Wed, Oct 29, 10:58 AM
kp accepted D53216: pf: Make nat-to and rdr-to work properly both on in and out rules.
Wed, Oct 29, 10:17 AM
kp committed rGdb0d002a217b: pf tests: tftp-proxy test case (authored by kp).
pf tests: tftp-proxy test case
Wed, Oct 29, 9:24 AM

Tue, Oct 28

kp accepted D53358: libpfctl: Fix displaying deeply nested anchors.
Tue, Oct 28, 9:55 AM

Mon, Oct 27

kp accepted D53360: pfctl: Do not warn if there is no Ethernet anchor.

Part of the issue here is that we've got layer 3 and ethernet anchors and it's possible for an anchor to exist in one but not the other. So a pfctl -sA -a foo can be valid for one but not the other. I don't immediately see a better way of handling that than to just not raise errors either.

Mon, Oct 27, 9:36 PM
kp added inline comments to D53358: libpfctl: Fix displaying deeply nested anchors.
Mon, Oct 27, 4:27 PM
kp accepted D53342: altq: Clear stats structures in get_class_stats().
Mon, Oct 27, 2:41 PM

Sun, Oct 26

kp added a comment to D53360: pfctl: Do not warn if there is no Ethernet anchor.

Thanks. I’ll try to review this (and your other patch) in the next days.

Sun, Oct 26, 1:17 PM

Wed, Oct 22

kp committed rG536b07512c4b: pf: fix 'no rdr' (authored by kp).
pf: fix 'no rdr'
Wed, Oct 22, 7:08 PM

Tue, Oct 21

kp closed D53022: if_vxlan: fix byteorder of source port.
Tue, Oct 21, 8:02 PM
kp committed rG1cc316727eba: if_vxlan: fix byteorder of source port (authored by p.mousavizadeh_protonmail.com).
if_vxlan: fix byteorder of source port
Tue, Oct 21, 8:01 PM
kp accepted D53215: tests/sys/netpfil/pf/sctp: make use of required.kmods.
Tue, Oct 21, 7:42 PM

Sun, Oct 19

kp committed rGcb36bfee25b7: pf: fix 'no rdr' (authored by kp).
pf: fix 'no rdr'
Sun, Oct 19, 9:08 PM
kp closed D53191: pf: fix 'no rdr'.
Sun, Oct 19, 9:08 PM

Sat, Oct 18

kp requested review of D53191: pf: fix 'no rdr'.
Sat, Oct 18, 8:25 PM

Wed, Oct 15

kp added a comment to D53070: pf: remove unused variable allrulelist.
In D53070#1213136, @mjg wrote:
In D53070#1212847, @kp wrote:

I do still want to murder this code, but we'll wait until armv7 finally dies, or dies enough.

one can consider reverting this to a state prior to introduction of per-cpu counters. that is, just have a var updated directly. this loses updates, but maybe it's good enough for armv7?

Wed, Oct 15, 7:57 PM

Tue, Oct 14

kp accepted D45919: mv88e151x: fix potential attach and autonegotiation issues.
Tue, Oct 14, 10:12 PM
kp added inline comments to D45919: mv88e151x: fix potential attach and autonegotiation issues.
Tue, Oct 14, 5:40 PM
kp abandoned D53070: pf: remove unused variable allrulelist.

Thanks for catching that. I'm not sure how I missed it, but I'm glad I remembered you wrote it and would be a good person to copy on a review.

Tue, Oct 14, 5:29 PM

Mon, Oct 13

kp requested review of D53070: pf: remove unused variable allrulelist.
Mon, Oct 13, 2:12 PM

Sat, Oct 11

kp committed rG1735d66a9c5b: pf tests: verify checksum offload handling (authored by kp).
pf tests: verify checksum offload handling
Sat, Oct 11, 12:04 PM
kp committed rG8a6bfa0455bf: pf tests: add missing atf_test_case lines for nat tests (authored by kp).
pf tests: add missing atf_test_case lines for nat tests
Sat, Oct 11, 12:04 PM
kp committed rG02923dd9b0de: dummynet: SDT probe dropped packets (authored by kp).
dummynet: SDT probe dropped packets
Sat, Oct 11, 12:04 PM
kp committed rG8217075f9ecb: pf tests: give rules_counter:4G more time (authored by kp).
pf tests: give rules_counter:4G more time
Sat, Oct 11, 12:04 PM
kp committed rGc70039393428: pf tests: give inetd some time to start (authored by kp).
pf tests: give inetd some time to start
Sat, Oct 11, 12:04 PM
kp committed rG98c1bf371c5d: pf tests: make syncookie:loopback more robust (authored by kp).
pf tests: make syncookie:loopback more robust
Sat, Oct 11, 12:04 PM

Fri, Oct 10

kp accepted D53022: if_vxlan: fix byteorder of source port.

LGTM

Fri, Oct 10, 12:56 PM
kp added inline comments to D45919: mv88e151x: fix potential attach and autonegotiation issues.
Fri, Oct 10, 12:34 PM
kp accepted D52906: mkimg: Add a -h option and improve usage output to be more expressive.

LGTM, ship it.

Fri, Oct 10, 12:16 PM
kp committed rG8638af3b2209: pf.conf.5: 'address' is mandatory with route-to (authored by kp).
pf.conf.5: 'address' is mandatory with route-to
Fri, Oct 10, 8:12 AM

Oct 7 2025

kp accepted D52952: ipv6: don't complain when deleting an address with prefix length of 128.
Oct 7 2025, 11:16 AM
kp committed rG306f29475fce: pf.conf.5: 'address' is mandatory with route-to (authored by kp).
pf.conf.5: 'address' is mandatory with route-to
Oct 7 2025, 8:22 AM

Oct 6 2025

kp committed rGb476593519e9: pfctl: check if the anchor exists before we attempt to flush anything from it (authored by kp).
pfctl: check if the anchor exists before we attempt to flush anything from it
Oct 6 2025, 9:36 PM
kp committed rG8fecb09bc58e: pfctl: store correct ticket type (authored by kp).
pfctl: store correct ticket type
Oct 6 2025, 9:36 PM

Oct 5 2025

kp committed rG3e79ec993dc7: pf tests: fix intermittent mld test failures (authored by kp).
pf tests: fix intermittent mld test failures
Oct 5 2025, 8:52 PM
kp committed rG4c7dba0c93fc: atf_python: allow test scripts to pass jail options (authored by kp).
atf_python: allow test scripts to pass jail options
Oct 5 2025, 8:52 PM
kp committed rGff566e6b9b8f: pf: fix 'natpass' (authored by kp).
pf: fix 'natpass'
Oct 5 2025, 8:52 PM
kp committed rGdd4095f11b1e: pf: return PF_PASS/PF_DROP from pf_setup_pdesc() (authored by kp).
pf: return PF_PASS/PF_DROP from pf_setup_pdesc()
Oct 5 2025, 8:52 PM
kp committed rG48cbd5698d9b: pf: fix possibe SCTP panic (authored by kp).
pf: fix possibe SCTP panic
Oct 5 2025, 8:52 PM

Oct 4 2025

kp added a comment to D52852: vxlan: support moving to a different vnet.

I've ever considered this approach, but this adds too many headaches. Well I'd propose to use vlxan(4) + bridge(4) + epair(4) if the underlay network is in different VNET.

For example, how can the admin change the tunnel parameters ( vni / vxlanlocal / vxlanremote / ports ) when the vxlan(4) interface is vmoved to another VNET ?

Oct 4 2025, 9:00 AM

Oct 2 2025

kp committed rGb93394a38bc4: pf: fix 'natpass' (authored by kp).
pf: fix 'natpass'
Oct 2 2025, 8:48 PM
kp closed D52838: pf: fix 'natpass'.
Oct 2 2025, 8:48 PM
kp committed rG5d210f396e3f: pf: return PF_PASS/PF_DROP from pf_setup_pdesc() (authored by kp).
pf: return PF_PASS/PF_DROP from pf_setup_pdesc()
Oct 2 2025, 7:20 PM
kp committed rGdd2fc08d8543: pf: fix possibe SCTP panic (authored by kp).
pf: fix possibe SCTP panic
Oct 2 2025, 7:20 PM
kp committed rGf9fc93690aef: sys/netinet6: fix memory corruption in in6_ifadd (authored by mjg).
sys/netinet6: fix memory corruption in in6_ifadd
Oct 2 2025, 2:26 PM
kp committed rGc23b64fba9fb: netinet6 tests: accept an RA on an interface without /64 address (authored by kp).
netinet6 tests: accept an RA on an interface without /64 address
Oct 2 2025, 2:26 PM
kp added a comment to D52852: vxlan: support moving to a different vnet.

if_vmove bites again? I'm fine with adding more kludges around this problem as long as we all agree that eventually this thing needs to be removed and interfaces shall be fully destroyed and fully instantiated in a different jail.

Oct 2 2025, 12:47 PM
kp requested review of D52853: vxlan tests: move a vxlan interface into a jail.
Oct 2 2025, 12:36 PM
kp requested review of D52852: vxlan: support moving to a different vnet.
Oct 2 2025, 12:35 PM
kp requested review of D52851: vxlan: support VNET.
Oct 2 2025, 12:35 PM
kp committed rG244a5188e768: pf: mark pf_match_translation() static (authored by kp).
pf: mark pf_match_translation() static
Oct 2 2025, 10:02 AM
kp accepted D52825: ip6+carp: revise the generation of ND6 NA.
Oct 2 2025, 8:35 AM

Oct 1 2025

kp requested review of D52838: pf: fix 'natpass'.
Oct 1 2025, 8:18 PM
kp added a reverting change for rG4e7a375804e5: IfAPI: Added missing accessor for if_home_vnet: rGebb60d47a535: Revert "IfAPI: Added missing accessor for if_home_vnet".
Oct 1 2025, 4:57 PM
kp committed rGebb60d47a535: Revert "IfAPI: Added missing accessor for if_home_vnet" (authored by kp).
Revert "IfAPI: Added missing accessor for if_home_vnet"
Oct 1 2025, 4:57 PM
kp committed rGbdb205c53ed7: libpfctl: fix memory leak in pfctl_get_status() (authored by kp).
libpfctl: fix memory leak in pfctl_get_status()
Oct 1 2025, 12:19 PM

Sep 30 2025

kp committed rGa57f6ce4792f: pf tests: fix intermittent mld test failures (authored by kp).
pf tests: fix intermittent mld test failures
Sep 30 2025, 12:54 PM
kp committed rG2213e158886f: atf_python: allow test scripts to pass jail options (authored by kp).
atf_python: allow test scripts to pass jail options
Sep 30 2025, 12:54 PM
kp closed D52762: pf tests: fix intermittent mld test failures.
Sep 30 2025, 12:54 PM
kp closed D52761: atf_python: allow test scripts to pass jail options.
Sep 30 2025, 12:53 PM

Sep 29 2025

kp committed rG4e7a375804e5: IfAPI: Added missing accessor for if_home_vnet (authored by ItzBlinkzy <kitey13579@gmail.com>).
IfAPI: Added missing accessor for if_home_vnet
Sep 29 2025, 9:17 PM

Sep 28 2025

kp accepted D50825: libexec/kgdb: Add a new VNET function and add more scaffolding.

I'm not qualified to review this in depth, but with the prerequisite patch included this works and is very, very useful.

Sep 28 2025, 1:43 PM

Sep 27 2025

kp added a comment to D50825: libexec/kgdb: Add a new VNET function and add more scaffolding.

I may be holding it wrong, but it still breaks for me:
It's a panic in vnet shutdown, so perhaps it's related to that:

Sep 27 2025, 3:50 PM
kp requested review of D52762: pf tests: fix intermittent mld test failures.
Sep 27 2025, 3:24 PM
kp requested review of D52761: atf_python: allow test scripts to pass jail options.
Sep 27 2025, 3:23 PM

Sep 25 2025

kp committed rGb84666f798e8: pf: export expiration time as time_t (authored by kp).
pf: export expiration time as time_t
Sep 25 2025, 12:42 PM
kp committed rG08fbad1b135b: pfctl: refactor 'rule_numbers' variable (authored by kp).
pfctl: refactor 'rule_numbers' variable
Sep 25 2025, 12:42 PM
kp committed rGc913959e9e03: pf tests: basic 'once' test (authored by kp).
pf tests: basic 'once' test
Sep 25 2025, 12:42 PM
kp committed rG2c53e251601c: pf tests: test once rule inside an anchor (authored by kp).
pf tests: test once rule inside an anchor
Sep 25 2025, 12:42 PM
kp committed rG64bfb82f1741: pfctl: print once shot rule expiration time (authored by kp).
pfctl: print once shot rule expiration time
Sep 25 2025, 12:42 PM
kp committed rGceff35a3aeef: pfctl: fix anchor handling for nat/rdr/binat anchors (authored by kp).
pfctl: fix anchor handling for nat/rdr/binat anchors
Sep 25 2025, 12:42 PM
kp committed rGcc97633b4b7a: pfctl.8/pf.conf.5: Improve "once" bits (authored by kp).
pfctl.8/pf.conf.5: Improve "once" bits
Sep 25 2025, 12:42 PM
kp committed rGde8af57c6f41: pf: simplify expiration of 'once' rules. (authored by kp).
pf: simplify expiration of 'once' rules.
Sep 25 2025, 12:42 PM
kp committed rG59f3838b0a94: pfctl: reduce duplicate code (authored by kp).
pfctl: reduce duplicate code
Sep 25 2025, 12:42 PM
kp committed rG2be46b52f5db: pfctl: fix once rules (authored by kp).
pfctl: fix once rules
Sep 25 2025, 12:42 PM
kp committed rGb9d652bb75ff: pf: print 'once' rule expire time (authored by kp).
pf: print 'once' rule expire time
Sep 25 2025, 12:42 PM
kp committed rGd3b73a944b11: pfctl: deny "once" flags for match rules (authored by kp).
pfctl: deny "once" flags for match rules
Sep 25 2025, 12:42 PM
kp committed rGb7ff11b380bf: pf.conf.5: Document a "once" filter option used to create one shot rules. (authored by kp).
pf.conf.5: Document a "once" filter option used to create one shot rules.
Sep 25 2025, 12:42 PM
kp committed rG8a4386142d05: pfctl tests: basic 'once' rule test (authored by kp).
pfctl tests: basic 'once' rule test
Sep 25 2025, 12:42 PM
kp committed rGaf922319e813: pf: support one shot rules (authored by kp).
pf: support one shot rules
Sep 25 2025, 12:42 PM
kp committed rG882121672704: pfctl: One shot rules can be used in pf.conf by specifying a "once" filter… (authored by kp).
pfctl: One shot rules can be used in pf.conf by specifying a "once" filter…
Sep 25 2025, 12:42 PM

Sep 24 2025

kp committed rGe70a2bcdc4f7: pf: fix rules_counter:keepcounters test (authored by kp).
pf: fix rules_counter:keepcounters test
Sep 24 2025, 1:41 PM
kp accepted D52448: pf: Fix interface counters for af-to rules.
Sep 24 2025, 11:48 AM
kp committed rG7ec06143964a: pf: pass pre-NAT addresses to dummynet (authored by kp).
pf: pass pre-NAT addresses to dummynet
Sep 24 2025, 11:45 AM