♟ kp

pfctl: Move AF-specific mask logic from callers into set_ipmask()

pfctl: Use error label in host_if()

pfctl: Zap bits in host_v4(), use mask parameter

pfctl: Zap v4mask and v6mask in host()

pfctl: Simplify host()

pfctl: Use strtonum in host()

pfctl: Move duplicate code into new helper print_addr_str()

pfctl: Simplify getaddrinfo() error handling

wg: fix LINT-NOIP build

pfctl: Stop checking table commands for `create'

pfctl: simplify FOM_PRIO handling

pf: trade few 'goto unlock: for 'break' in pf_test()

pf: remove STATE_LOOKUP

pfctl: use __func__ rather than hardcoding function names for errors

pf.conf.5: reflect the new state limit

pfctl: Add "listenrepv2" for MLDv2 Listener Reports from RFC3810

pf tests: verify max-pkt-rate on anchors

pfctl: fix anchor rules with filter opts, introduce filteropts_to_rule()

pfctl: Zap dead code

pfctl: clean up allocation warnings

pfctl: fix memory leak

pfctl: plug some memory leaks

pf: Refactor the six ways to find TCP options into one new function.

pfctl tests: test line number reporting in include files

pfctl: fix reporting of line numbers for included files

pf: add 'max-pkt-size'

pf: ensure max-pkt-size works on match rules

pf: fix ICMP ECHO handling of ID conflicts

pf tests: test handling of ICMP echo requests with the same ID

pfctl: Plug leak in error case of the common 'varset' implementations.

pf: fix regression in pflog output

pf: decrement TTL in pf_route(6)()

pf: Use pf_send_icmp() consistently in pf_route()

pf: disallow IPv6 routing header by default

pfctl: fails to handle nested 'load anchor' properly

pf: drop neighbor discovery packets with the wrong hop limit

pf: limit extra SCTP states

pfctl: fix use-after-free and memory leak in pfctl_optimzie.c

pfctl: rule optimizer: anchor name vs. anchor path mix up

pf tests: basic max-pkt-rate test

pfctl tests: max-pkt-rate test

pfctl: nested anchors vs. pfctl/parse.y

pf.conf.5: tweak max-pkt-rate

pf: add a generic packet rate matching filter

pf: use counter_rate() for rate checking

counter(9): rate limit periods may be more than 1 second

In D50796#1162649, @kp wrote:

Unless Jonathan remembers something I'd like to go with this version.

pf tests: do not shutdown the sctp server in sctp:related_icmp

In D50796#1162059, @glebius wrote:

I'm not sure about making the structure opaque and thus only dynamically allocated. In general I prefer hiding internals, but for some reason when we did this, we decided to make it exposed. There definitely was some reason for that, otherwise I would make it opaque. Adding Jonathan, maybe he can recall.

Oh sure, blame me for the commit message ;)

The change is good, but I'd rephrase the commit message slightly. We never actually added the sysctl. The limit was implemented, and the sysctl to tune it was documented but never added (so the limit is there, but is always 16 and cannot be changed).

While testing I found that this has issues with vnet variables in kernel modules.

qlnx: fix panic at startup

net/libpfctl: add 14.3 version

In D50796#1159287, @glebius wrote:

May I ask to wait for my review until next week?

I'm going to need to take a deeper look later (probably when I'm back home from BSDCan). First impressions are that the implementation is probably good, but I really dislike the 'RFC5549' naming of the flag and variables. Unfortunately I don't immediately have a better suggestion.

sys: add LINT-NOVIMAGE

Approved, but please only commit it along with a test case that uses this setup code.

pf tests: frag6.py:TestFrag6_RouteTo::test_too_big requires scapy

pf: split pf_find_or_create_ruleset() into smaller chunks

pf tests: killstate:key requires scapy

pf: reorganise fragment reassembly

pfctl: add option -S (no domain resolution)

pf: use time_uptime rather than time_seconds

pf: fix panic in pf_return()

pfctl: void functions and exit(3) on error

pf.conf.5: clarify filter evaluation and anchor loading

pf.conf.5: clarify set prio

UPDATING: document recent pf changes

kp (Kristof Provost)
Troubleshooter

Projects (6)
View All

User Details

Recent Activity
View All

Yesterday

Fri, Jun 27

Thu, Jun 26

Wed, Jun 25

Mon, Jun 23

Sat, Jun 21

Thu, Jun 19

Mon, Jun 16

Sat, Jun 14

Fri, Jun 13

Thu, Jun 12

Wed, Jun 11

Tue, Jun 10

Mon, Jun 9

Fri, Jun 6

kp (Kristof Provost)Troubleshooter

Projects (6)View All