Page MenuHomeFreeBSD
People kp

kp (Kristof Provost)
Troubleshooter

Projects (6)
View All

User Details

User Since
Sep 28 2014, 7:22 PM (619 w, 3 d)

Recent Activity
View All

Yesterday

kp accepted D58786: epair: allow disabling receive checksum offloading.
Wed, Aug 12, 12:30 PM

Tue, Aug 11

kp committed rG80d732d64099: pf: attempt to handle overlapping group and interface names (authored by kp).
pf: attempt to handle overlapping group and interface names
Tue, Aug 11, 8:43 AM
kp committed rGe4e4d1b5ed7b: pf: check if a group has a kif before dereferencing it (authored by kp).
pf: check if a group has a kif before dereferencing it
Tue, Aug 11, 8:43 AM
kp committed rG71ac7ff5d6f9: pf: attempt to handle overlapping group and interface names (authored by kp).
pf: attempt to handle overlapping group and interface names
Tue, Aug 11, 8:43 AM
kp committed rG82255ae91399: pf: check if a group has a kif before dereferencing it (authored by kp).
pf: check if a group has a kif before dereferencing it
Tue, Aug 11, 8:43 AM

Mon, Aug 10

kp committed rG0f2e98c1515d: libsysdecode: verify decoder tables are sorted (authored by iagrawal9990_gmail.com).
libsysdecode: verify decoder tables are sorted
Mon, Aug 10, 2:35 PM
kp committed rG2ef4baaffce0: libsysdecode: avoid extra commas for undecoded netlink attributes (authored by iagrawal9990_gmail.com).
libsysdecode: avoid extra commas for undecoded netlink attributes
Mon, Aug 10, 2:35 PM
kp committed rG15c0c9df3a4a: libsysdecode: use decoder table for PF netlink commands (authored by iagrawal9990_gmail.com).
libsysdecode: use decoder table for PF netlink commands
Mon, Aug 10, 2:35 PM
kp committed rG1d926be8824a: libsysdecode : add attribute parsing for PFNL_CMD_KILLSTATES (authored by iagrawal9990_gmail.com).
libsysdecode : add attribute parsing for PFNL_CMD_KILLSTATES
Mon, Aug 10, 2:35 PM
kp committed rG91aa9bf0ae16: libsysdecode : add attribute parsing for PFNL_CMD_GET_LIMIT (authored by iagrawal9990_gmail.com).
libsysdecode : add attribute parsing for PFNL_CMD_GET_LIMIT
Mon, Aug 10, 2:35 PM
kp committed rG11bc53984b1f: libsysdecode: add attribute parsing for PFNL_CMD_GETRULES (authored by iagrawal9990_gmail.com).
libsysdecode: add attribute parsing for PFNL_CMD_GETRULES
Mon, Aug 10, 2:35 PM
kp committed rG9b9b3b157a89: libsysdecode: also verify command decoders (authored by kp).
libsysdecode: also verify command decoders
Mon, Aug 10, 2:35 PM
kp added a comment to D58754: if_ovpn: free crp, mbuf, and release refcount on crypto_dispatch() failure.

Thanks for the fix.

Mon, Aug 10, 1:24 PM
kp committed rGa841961da752: if_ovpn: free crp, mbuf, and release refcount on crypto_dispatch() failure (authored by ing.castellanosdz_gmail.com).
if_ovpn: free crp, mbuf, and release refcount on crypto_dispatch() failure
Mon, Aug 10, 1:24 PM
kp closed D58754: if_ovpn: free crp, mbuf, and release refcount on crypto_dispatch() failure.
Mon, Aug 10, 1:23 PM
kp accepted D58755: pf: Fix uninitialised action when dropping bad TTL ND packets.

LGTM

Mon, Aug 10, 11:45 AM
kp added inline comments to D58754: if_ovpn: free crp, mbuf, and release refcount on crypto_dispatch() failure.
Mon, Aug 10, 8:35 AM
kp added inline comments to D58754: if_ovpn: free crp, mbuf, and release refcount on crypto_dispatch() failure.
Mon, Aug 10, 8:32 AM

Sat, Aug 8

kp committed rG7e2781fdcfdb: pfsync: handle large MTU pfsync interfaces (authored by kp).
pfsync: handle large MTU pfsync interfaces
Sat, Aug 8, 9:08 AM
kp closed D58701: net: don't panic on ifconfig pfsync0 mtu 9000.
Sat, Aug 8, 9:08 AM
kp committed rG8ea4e92945d3: net: don't panic on ifconfig pfsync0 mtu 9000 (authored by kp).
net: don't panic on ifconfig pfsync0 mtu 9000
Sat, Aug 8, 9:08 AM
kp updated the diff for D58701: net: don't panic on ifconfig pfsync0 mtu 9000.

Add IFT_PFSYNC comment.

Sat, Aug 8, 8:10 AM

Fri, Aug 7

kp edited reviewers for D58701: net: don't panic on ifconfig pfsync0 mtu 9000, added: glebius; removed: melifaro.
Fri, Aug 7, 2:55 PM
kp requested review of D58701: net: don't panic on ifconfig pfsync0 mtu 9000.
Fri, Aug 7, 2:55 PM

Tue, Aug 4

kp added a comment to D58560: Adding libxo support to ifconfig (XML / JSON output).
In D58560#1344488, @paige_paige.bio wrote:

fixing a couple of errors where I used xo_warn to replace calls to Perror by changing the calls back to Perror instead of xo_warn

Tue, Aug 4, 8:11 PM

Mon, Aug 3

kp committed rGd2a5b5a86a92: pf: attempt to handle overlapping group and interface names (authored by kp).
pf: attempt to handle overlapping group and interface names
Mon, Aug 3, 4:03 PM
kp committed rGd13dffa150d1: pf: fix securelevel off-by-one (authored by kp).
pf: fix securelevel off-by-one
Mon, Aug 3, 4:03 PM
kp closed D58377: pf: fix securelevel off-by-one.
Mon, Aug 3, 4:02 PM

Wed, Jul 29

kp accepted D58521: ipsec: Fix a lock leak in ipsec_chkreplay().
Wed, Jul 29, 8:29 AM
kp committed rGd68de8c2cd95: authpf(8) read_config() should chop off trailing white space (authored by kp).
authpf(8) read_config() should chop off trailing white space
Wed, Jul 29, 7:30 AM
kp committed rGc8af571bf1f8: authpf(8) read_config() should chop off trailing white space (authored by kp).
authpf(8) read_config() should chop off trailing white space
Wed, Jul 29, 7:30 AM

Mon, Jul 27

kp committed rG407b7bcc9386: libsysdecode: decode combined Netlink message flags (authored by iagrawal9990_gmail.com).
libsysdecode: decode combined Netlink message flags
Mon, Jul 27, 9:29 AM
kp committed rG5c1461a2b0fd: libsysdecode: use local sysdecode.h (authored by iagrawal9990_gmail.com).
libsysdecode: use local sysdecode.h
Mon, Jul 27, 7:52 AM

Fri, Jul 24

kp committed rG26bb78b77231: libsysdecode: add Netlink attribute decoding infrastructure (authored by iagrawal9990_gmail.com).
libsysdecode: add Netlink attribute decoding infrastructure
Fri, Jul 24, 3:05 PM

Thu, Jul 23

kp committed rG145541d4ed79: pf(4) fix NULL pointer dereference in outbound packet path. (authored by kp).
pf(4) fix NULL pointer dereference in outbound packet path.
Thu, Jul 23, 12:41 PM
kp committed rG850041b02548: pf: include direction in fragment key (authored by kp).
pf: include direction in fragment key
Thu, Jul 23, 12:41 PM

Wed, Jul 22

kp committed rG04f25ef716f7: authpf(8) read_config() should chop off trailing white space (authored by kp).
authpf(8) read_config() should chop off trailing white space
Wed, Jul 22, 9:30 AM

Tue, Jul 21

kp requested review of D58377: pf: fix securelevel off-by-one.
Tue, Jul 21, 3:08 PM

Wed, Jul 15

kp committed rGf2202ab5abda: mbuf: make m_unshare() allow unmapped mbufs (authored by takahiro.kurosawa_gmail.com).
mbuf: make m_unshare() allow unmapped mbufs
Wed, Jul 15, 1:51 PM
kp committed rG40c611d0939f: pfctl: fix incorrect errno checks (authored by kp).
pfctl: fix incorrect errno checks
Wed, Jul 15, 1:51 PM
kp committed rGddbf89234312: pfctl: fix CREATE_TABLE error handling (authored by kp).
pfctl: fix CREATE_TABLE error handling
Wed, Jul 15, 1:51 PM
kp closed D58189: mbuf: make m_unshare() allow unmapped mbufs.
Wed, Jul 15, 1:51 PM

Jul 8 2026

kp committed rG8a14fcd23a20: pf: fix a crash on sendfile() (authored by takahiro.kurosawa_gmail.com).
pf: fix a crash on sendfile()
Jul 8 2026, 7:53 AM
kp committed rG2039fe8ea421: tests/sendfile_helper: support remote connection (authored by takahiro.kurosawa_gmail.com).
tests/sendfile_helper: support remote connection
Jul 8 2026, 7:53 AM
kp committed rG6a5ba658dd48: tests/sendfile: move the helper program to common (authored by takahiro.kurosawa_gmail.com).
tests/sendfile: move the helper program to common
Jul 8 2026, 7:53 AM
kp committed rGc38abd64dbc1: if_epair: support IFCAP_MEXTPG (authored by kp).
if_epair: support IFCAP_MEXTPG
Jul 8 2026, 7:53 AM
kp closed D58021: pf: fix a crash on sendfile().
Jul 8 2026, 7:53 AM
kp closed D58054: if_epair: support IFCAP_MEXTPG.
Jul 8 2026, 7:52 AM
kp closed D58041: tests/sendfile_helper: support remote connection.
Jul 8 2026, 7:52 AM
kp closed D58040: tests/sendfile: move the helper program to common.
Jul 8 2026, 7:52 AM

Jul 7 2026

kp committed rG3e3752ce73b7: if_bridge: Remove unused disable parameter in bridge_stop (authored by acesp25).
if_bridge: Remove unused disable parameter in bridge_stop
Jul 7 2026, 1:24 PM
kp accepted D58021: pf: fix a crash on sendfile().

I'll give Gleb a few more days to take another look and then I'll commit the entire series.
Thanks for the fix!

Jul 7 2026, 8:53 AM
kp accepted D58040: tests/sendfile: move the helper program to common.
Jul 7 2026, 8:49 AM

Jul 6 2026

kp added inline comments to D58021: pf: fix a crash on sendfile().
Jul 6 2026, 2:06 PM
kp requested review of D58054: if_epair: support IFCAP_MEXTPG.
Jul 6 2026, 2:05 PM
kp added inline comments to D58021: pf: fix a crash on sendfile().
Jul 6 2026, 12:07 PM
kp added inline comments to D58021: pf: fix a crash on sendfile().
Jul 6 2026, 12:06 PM
kp added inline comments to D58021: pf: fix a crash on sendfile().
Jul 6 2026, 9:23 AM
kp added inline comments to D58021: pf: fix a crash on sendfile().
Jul 6 2026, 7:40 AM

Jul 5 2026

kp committed rGfa50691ecf87: libsysdecode: decode PF Generic Netlink commands (authored by iagrawal9990_gmail.com).
libsysdecode: decode PF Generic Netlink commands
Jul 5 2026, 2:17 PM
kp committed rGc268c80fc3d5: libsysdecode: cache Generic Netlink family IDs (authored by iagrawal9990_gmail.com).
libsysdecode: cache Generic Netlink family IDs
Jul 5 2026, 2:16 PM
kp committed rG8a1576dc26b9: truss: track Netlink socket protocols (authored by iagrawal9990_gmail.com).
truss: track Netlink socket protocols
Jul 5 2026, 2:16 PM
kp committed rG80586e853674: libsysdecode: decode Generic Netlink controller messages (authored by iagrawal9990_gmail.com).
libsysdecode: decode Generic Netlink controller messages
Jul 5 2026, 2:16 PM

Jul 3 2026

kp added inline comments to D58021: pf: fix a crash on sendfile().
Jul 3 2026, 12:36 PM
kp added a comment to D58021: pf: fix a crash on sendfile().

That looks pretty good to me, but I'd like to give Gleb some time to look as well. He's a lot more familiar with unmapped buffers than I am.

Jul 3 2026, 12:35 PM
kp committed rGc9d98c013486: netlink: add const variants of NLA iteration macros (authored by iagrawal9990_gmail.com).
netlink: add const variants of NLA iteration macros
Jul 3 2026, 8:40 AM

Jul 1 2026

kp accepted D57866: pf: revert netlink commands back to enum.
Jul 1 2026, 12:25 PM

Jun 30 2026

kp committed rGb8c6f5811b2a: pflog: run VNET_SYSUNINIT in SI_SUB_PROTO_FIREWALL (authored by kp).
pflog: run VNET_SYSUNINIT in SI_SUB_PROTO_FIREWALL
Jun 30 2026, 1:58 PM

Jun 28 2026

kp committed rGe4f3ab161a9e: pflog: create bpf tapping points without ifnet(9) (authored by kp).
pflog: create bpf tapping points without ifnet(9)
Jun 28 2026, 2:31 PM
kp closed D57851: pflog: create bpf tapping points without ifnet(9).
Jun 28 2026, 2:31 PM

Jun 26 2026

kp committed rG9de06f27b140: libpfctl: fix memory leak (authored by kp).
libpfctl: fix memory leak
Jun 26 2026, 11:02 PM
kp committed rGf95439f6c9d0: libpfctl: retrieve family id only once (authored by kp).
libpfctl: retrieve family id only once
Jun 26 2026, 11:02 PM
kp added a comment to D57851: pflog: create bpf tapping points without ifnet(9).
In D57851#1327103, @glebius wrote:
In D57851#1327098, @kp wrote:

Do you happen to know of a way to get an interface (struct ifnet) without AF_INET6? I used to use pflog0 for this, and now clearly can't any more. (The test for PR 288263 does that.)
Ideally I'd like to not remove the test, but without such an interface there's no point to it.

The whole point of the change, that now (after pfsync0 de-ifnetting) you can assert that any interface has IPv6 context. Lots of checks for that in netinet6 go away.

Jun 26 2026, 10:17 PM
kp updated the diff for D57851: pflog: create bpf tapping points without ifnet(9).

Remove epoch cleanup.
Update failing test case to use pfsync0 iso. pflog0 (for now).

Jun 26 2026, 10:16 PM
kp updated the diff for D57851: pflog: create bpf tapping points without ifnet(9).

mtx -> sx

Jun 26 2026, 5:59 PM
kp added a comment to D57851: pflog: create bpf tapping points without ifnet(9).

Do you happen to know of a way to get an interface (struct ifnet) without AF_INET6? I used to use pflog0 for this, and now clearly can't any more. (The test for PR 288263 does that.)
Ideally I'd like to not remove the test, but without such an interface there's no point to it.

Jun 26 2026, 5:56 PM
kp accepted D57865: libsysdecode: parse enums.
Jun 26 2026, 2:58 PM
kp accepted D57866: pf: revert netlink commands back to enum.
Jun 26 2026, 1:43 PM
kp added inline comments to D57865: libsysdecode: parse enums.
Jun 26 2026, 1:04 PM
kp updated the diff for D57851: pflog: create bpf tapping points without ifnet(9).
  • locking fixes
  • man page improvement
  • fix pflogd to not look for a network interface
  • have /etc/rc.d/pflogd create extra log devices if required
Jun 26 2026, 12:40 PM
kp added a comment to D57851: pflog: create bpf tapping points without ifnet(9).
In D57851#1326392, @glebius wrote:

My only concern is racyness of sysctl vs sysctl. The node and proc are marked CTLFLAG_MPSAFE, so they can execute in parallel. bpf_attach() doesn't have protection against duplicates, so we will leak one.

Ah, yeah, that's an issue.
I could remove the MPSAFE, but we probably don't want to rely on Giant, so that's not great either.

Jun 26 2026, 8:28 AM

Jun 25 2026

kp committed rGefcc183f9b0d: pflog: remove unused argument from pflogattach() (authored by kp).
pflog: remove unused argument from pflogattach()
Jun 25 2026, 7:35 PM
kp requested review of D57851: pflog: create bpf tapping points without ifnet(9).
Jun 25 2026, 7:32 PM

Jun 24 2026

kp committed rG6c744621c720: truss: add AF_NETLINK syscall argument decoding support (authored by Ishan Agrawal <iagrawal9990@gmail.com>).
truss: add AF_NETLINK syscall argument decoding support
Jun 24 2026, 2:51 PM
kp committed rG4c932a4d45fb: netlink: decode netlink message flags symbolically (authored by Ishan Agrawal <iagrawal9990@gmail.com>).
netlink: decode netlink message flags symbolically
Jun 24 2026, 12:17 PM

Jun 23 2026

kp committed rGf4e2f07f0cbc: pfsync: remove invalid panic (authored by kp).
pfsync: remove invalid panic
Jun 23 2026, 6:47 AM
kp committed rG26a94ad8fb31: pfsync: remove invalid panic (authored by kp).
pfsync: remove invalid panic
Jun 23 2026, 6:47 AM

Jun 22 2026

kp added a comment to D57737: libpfctl: reset the snl(3) arena per netlink transaction.
In D57737#1323743, @oshogbo wrote:

Oh, thank you somehow I have missed it.

Thanks!

Jun 22 2026, 11:15 AM
kp added a comment to D57737: libpfctl: reset the snl(3) arena per netlink transaction.

Yes. that's indeed a bug, but I fixed it two weeks ago: https://cgit.freebsd.org/src/commit/?id=fcb31b57112425a4eb64241651a0206108105298

Jun 22 2026, 10:58 AM

Jun 20 2026

kp accepted D57696: if_ovpn: Fix a lock leak in an error path.
Jun 20 2026, 3:57 AM

Jun 17 2026

kp abandoned D52851: vxlan: support VNET.
Jun 17 2026, 7:59 PM
kp abandoned D52852: vxlan: support moving to a different vnet.
Jun 17 2026, 7:58 PM
kp abandoned D52853: vxlan tests: move a vxlan interface into a jail.
Jun 17 2026, 7:58 PM
kp accepted D57550: iflib: handle transient errors from isc_txd_encap().
Jun 17 2026, 7:45 PM
kp committed rGe2903636a069: iflib: Fix mbufs leaked by 0 len packets emitted from the if driver (authored by linnemannr_gmail.com).
iflib: Fix mbufs leaked by 0 len packets emitted from the if driver
Jun 17 2026, 7:31 PM
kp closed D57537: iflib: Fix mbufs leaked by 0 len packets emitted from the if driver.
Jun 17 2026, 7:31 PM · network
kp added a comment to D57537: iflib: Fix mbufs leaked by 0 len packets emitted from the if driver.
In D57537#1321192, @gallatin wrote:

@gallatin Do you want to commit this, or should I? (Reid doesn't have a bit, so someone else needs to.)

If you could push it, that would be great.

Will do.

Jun 17 2026, 6:12 PM · network
kp added a comment to D57537: iflib: Fix mbufs leaked by 0 len packets emitted from the if driver.
In D57537#1319082, @gallatin wrote:

It took me a while, but I think your patch is correct.

Jun 17 2026, 4:54 PM · network

Jun 16 2026

kp accepted D57608: pfctl: pfctl_get_astats() doesn't set errno.
Jun 16 2026, 4:49 PM

Jun 12 2026

kp committed rGfcb31b571124: libpfctl: fix memory leak (authored by kp).
libpfctl: fix memory leak
Jun 12 2026, 11:54 AM