Page MenuHomeFreeBSD

kp (Kristof Provost)
Troubleshooter

Projects (6)

User Details

User Since
Sep 28 2014, 7:22 PM (551 w, 2 d)

Recent Activity

Yesterday

kp committed rG461b79d8ee58: pfctl: also remove incorrect counter print for rule anchors (authored by kp).
pfctl: also remove incorrect counter print for rule anchors
Mon, Apr 21, 9:16 PM
kp committed rGa60eeb4331e5: pfctl: fix crash on "pfctl -a '*' -vvsr" (authored by kp).
pfctl: fix crash on "pfctl -a '*' -vvsr"
Mon, Apr 21, 9:16 PM
kp committed rGb89bc49a6348: pf: explicitly NULL state key pointers (authored by kp).
pf: explicitly NULL state key pointers
Mon, Apr 21, 9:16 PM
kp committed rG8b9d1dc82ac4: pf: don't use state keys after pf_state_insert() (authored by kp).
pf: don't use state keys after pf_state_insert()
Mon, Apr 21, 9:16 PM
kp committed rG482f4dc272cc: pf: improve pf_state_key_attach() error handling (authored by kp).
pf: improve pf_state_key_attach() error handling
Mon, Apr 21, 9:16 PM
kp committed rG5b182c68c0f5: pfctl: also remove incorrect counter print for rule anchors (authored by kp).
pfctl: also remove incorrect counter print for rule anchors
Mon, Apr 21, 9:16 PM
kp committed rG35a83d58bdbe: pfctl: fix crash on "pfctl -a '*' -vvsr" (authored by kp).
pfctl: fix crash on "pfctl -a '*' -vvsr"
Mon, Apr 21, 9:16 PM
kp committed rG7161339bb5e9: pf: don't use state keys after pf_state_insert() (authored by kp).
pf: don't use state keys after pf_state_insert()
Mon, Apr 21, 9:16 PM
kp committed rGd6381193a3e8: pf: improve pf_state_key_attach() error handling (authored by kp).
pf: improve pf_state_key_attach() error handling
Mon, Apr 21, 9:16 PM
kp committed rG4df4b69530c3: pf: explicitly NULL state key pointers (authored by kp).
pf: explicitly NULL state key pointers
Mon, Apr 21, 9:16 PM
kp committed rG612ae9c9d06c: pf: add extra unhandled_af() assertions (authored by kp).
pf: add extra unhandled_af() assertions
Mon, Apr 21, 12:50 PM
kp committed rG4bbd5db0086a: pf: use struct pf_pdesc for pf_change_ap() (authored by kp).
pf: use struct pf_pdesc for pf_change_ap()
Mon, Apr 21, 12:50 PM
kp committed rG04ed606def89: pf: pull icmp-nested headers into struct pf_pdesc (authored by kp).
pf: pull icmp-nested headers into struct pf_pdesc
Mon, Apr 21, 12:49 PM
kp committed rG88986a4d7183: pf: fix ICMP pcksum pointers (authored by kp).
pf: fix ICMP pcksum pointers
Mon, Apr 21, 12:49 PM
kp accepted D49936: link_addr: only accept '.' and ':' as separators.
In D49936#1138714, @ivy wrote:
In D49936#1138707, @kp wrote:

I wonder if that's worth changing too.

so... i'm not opposed to changing that. actually, i think that makes a lot of sense. however, i think this change to link_addr() also makes sense regardless of that.

Mon, Apr 21, 9:19 AM
kp added a comment to D49936: link_addr: only accept '.' and ':' as separators.

in this case ifconfig(8) defaults to the 'link' address family instead of the 'inet' address family.

Mon, Apr 21, 8:54 AM

Fri, Apr 18

kp accepted D49352: pf: Avoid logging state creation failures unless requested.
Fri, Apr 18, 12:37 PM

Wed, Apr 16

kp committed rG435e9214478c: pf: remove _unaligned from pf_patch_(16|32)_unaligned() (authored by kp).
pf: remove _unaligned from pf_patch_(16|32)_unaligned()
Wed, Apr 16, 6:03 PM
kp committed rG911d74bcbd7a: pf: simplify pf_patch* arguments (authored by kp).
pf: simplify pf_patch* arguments
Wed, Apr 16, 6:03 PM
kp committed rGf09ee340d2b7: pf: remove unused macros (authored by kp).
pf: remove unused macros
Wed, Apr 16, 6:03 PM
kp committed rG3f39713e4e34: pf: log reused states in addition to failed state insertions (authored by kp).
pf: log reused states in addition to failed state insertions
Wed, Apr 16, 6:03 PM
kp committed rGe2177bca94f2: pf: allow pf_get_sport() to work on in rules (authored by kp).
pf: allow pf_get_sport() to work on in rules
Wed, Apr 16, 6:03 PM
kp committed rG5b13b79a5c3a: pf tests: test includes inside anchors (authored by kp).
pf tests: test includes inside anchors
Wed, Apr 16, 6:03 PM
kp committed rG16c25f9861db: pfctl: allow include in inline anchors (authored by kp).
pfctl: allow include in inline anchors
Wed, Apr 16, 6:03 PM
kp committed rGa6a98453d8c9: pf: Don't convert arc4random() to host byte order (authored by kp).
pf: Don't convert arc4random() to host byte order
Wed, Apr 16, 6:03 PM
kp committed rG162dfe766b2a: pfctl: Remove NULL-checks before free(). ok tb@ (authored by kp).
pfctl: Remove NULL-checks before free(). ok tb@
Wed, Apr 16, 6:03 PM
kp committed rGcfdc4f6d0647: pf: g/c unneeded af (address family) params to pf_change_ap (authored by kp).
pf: g/c unneeded af (address family) params to pf_change_ap
Wed, Apr 16, 6:03 PM
kp committed rG0da181786849: pfctl: fix recursive printing of NAT rules (authored by kp).
pfctl: fix recursive printing of NAT rules
Wed, Apr 16, 1:49 PM
kp committed rG9edd1e62ca11: pfctl: fix recursive printing of NAT rules (authored by kp).
pfctl: fix recursive printing of NAT rules
Wed, Apr 16, 1:49 PM

Tue, Apr 15

kp committed rGc59492025073: sys/net: add DOT1Q_VID_{MIN,MAX} (authored by ivy).
sys/net: add DOT1Q_VID_{MIN,MAX}
Tue, Apr 15, 9:44 PM
kp closed D49837: sys/net: add DOT1Q_VID_{MIN,MAX}.
Tue, Apr 15, 9:44 PM
kp committed rG96f830456fd4: sys/net: add a new ether_vlanid_t type (authored by ivy).
sys/net: add a new ether_vlanid_t type
Tue, Apr 15, 9:44 PM
kp closed D49836: sys/net: add a new ether_vlanid_t type.
Tue, Apr 15, 9:43 PM
kp committed rG0fc3c29fb3dd: pfctl: also remove incorrect counter print for rule anchors (authored by kp).
pfctl: also remove incorrect counter print for rule anchors
Tue, Apr 15, 12:47 PM
kp committed rG29273f6a2582: pf: add SDT on REASON_SET() (authored by kp).
pf: add SDT on REASON_SET()
Tue, Apr 15, 12:47 PM
kp committed rG4e5657ab346c: pf: pass struct pf_pdesc to pf_change_ap() (authored by kp).
pf: pass struct pf_pdesc to pf_change_ap()
Tue, Apr 15, 12:47 PM
kp committed rG9c68e37d96b9: pf: share reason between pf_test() and pf_test_rule() (authored by kp).
pf: share reason between pf_test() and pf_test_rule()
Tue, Apr 15, 12:47 PM
kp committed rG1463d5ff1316: if_ovpn: fix use-after-free of mbuf (authored by kp).
if_ovpn: fix use-after-free of mbuf
Tue, Apr 15, 12:27 PM
kp committed rG168d873ae41f: pfctl: fix crash on "pfctl -a '*' -vvsr" (authored by kp).
pfctl: fix crash on "pfctl -a '*' -vvsr"
Tue, Apr 15, 7:43 AM

Sat, Apr 12

kp added inline comments to D28530: Widen ifnet_detach_sxlock coverage.
Sat, Apr 12, 12:43 PM

Thu, Apr 10

kp committed rGf36292f010fc: bridge: define VLANTAGOF correctly (authored by ivy).
bridge: define VLANTAGOF correctly
Thu, Apr 10, 6:54 PM
kp committed rGf6aedb956ef1: net/if_bridgevar.h: add include guard (authored by ivy).
net/if_bridgevar.h: add include guard
Thu, Apr 10, 6:54 PM
kp committed rG646b453110aa: pf: fix pf_ioctl_add_addr() validation (authored by kp).
pf: fix pf_ioctl_add_addr() validation
Thu, Apr 10, 1:37 PM

Wed, Apr 9

kp committed rGea6432cfa3c4: pf: rename pf_unlink_state() to pf_remove_state() (authored by kp).
pf: rename pf_unlink_state() to pf_remove_state()
Wed, Apr 9, 7:31 PM
kp committed rG02a12814c14f: pf.conf.5: remove incorrect performance comparison (authored by kp).
pf.conf.5: remove incorrect performance comparison
Wed, Apr 9, 7:31 PM
kp committed rG75fd973198f4: pf.conf.5: improve indentation in list block. (authored by kp).
pf.conf.5: improve indentation in list block.
Wed, Apr 9, 7:31 PM
kp committed rG0a376f7e7e03: pfctl: route-to, dup-to, reply-to should not override the block action (authored by kp).
pfctl: route-to, dup-to, reply-to should not override the block action
Wed, Apr 9, 7:31 PM
kp committed rGa4bd4e4b5632: pf tests: verify that we generate an ICMP6 packet too big error on route-to (authored by kp).
pf tests: verify that we generate an ICMP6 packet too big error on route-to
Wed, Apr 9, 7:31 PM
kp committed rGd1f4b9ffabbc: pf: emit ICMPv6 packet too big for route-to (authored by kp).
pf: emit ICMPv6 packet too big for route-to
Wed, Apr 9, 7:31 PM
kp committed rGf132e8b4c7d9: net tests: enable if_lagg_test:lacp_linkstate_destroy_stress (authored by K Rin <rin@sandb0x.tw>).
net tests: enable if_lagg_test:lacp_linkstate_destroy_stress
Wed, Apr 9, 1:51 PM
kp committed rG747483038e6f: netinet6 tests: fix typo in the test (authored by K Rin <rin@sandb0x.tw>).
netinet6 tests: fix typo in the test
Wed, Apr 9, 11:31 AM
kp committed rG8e7d333f9207: pf: added /* FALLTHROUGH */ comments, typecasts (u_int32_t)-1, ... (authored by kp).
pf: added /* FALLTHROUGH */ comments, typecasts (u_int32_t)-1, ...
Wed, Apr 9, 9:52 AM
kp committed rG9d38d2203b32: pf: unused arguments at pf_normalize_tcp_init() (authored by kp).
pf: unused arguments at pf_normalize_tcp_init()
Wed, Apr 9, 9:52 AM
kp committed rG7e0195e24896: pf: add unhandled_af() to pf_socket_lookup() (authored by kp).
pf: add unhandled_af() to pf_socket_lookup()
Wed, Apr 9, 9:52 AM
kp committed rGabda72f3a1f6: pf: INET/INET6 address family check should be unified in PF (authored by kp).
pf: INET/INET6 address family check should be unified in PF
Wed, Apr 9, 9:52 AM
kp committed rG97a74f461621: pfctl: fix no nat / no rdr rules (authored by kp).
pfctl: fix no nat / no rdr rules
Wed, Apr 9, 9:52 AM
kp closed D49665: pfctl: fix no nat / no rdr rules.
Wed, Apr 9, 9:52 AM
kp committed rG85967694b459: bridge: store a bridge_iflist pointer in ifnet (authored by ivy).
bridge: store a bridge_iflist pointer in ifnet
Wed, Apr 9, 8:18 AM
kp committed rGdd49816b0d66: bpf: avoid panic on multiple readers (authored by kp).
bpf: avoid panic on multiple readers
Wed, Apr 9, 8:18 AM
kp closed D49135: bpf: avoid panic on multiple readers.
Wed, Apr 9, 8:18 AM

Tue, Apr 8

kp committed rG50725e585de7: netinet6 tests: add a test for SIOCAIFADDRing an invalid IPv6 address (authored by ivy).
netinet6 tests: add a test for SIOCAIFADDRing an invalid IPv6 address
Tue, Apr 8, 9:07 AM

Mon, Apr 7

kp committed rG1408670c90ae: in6_control_ioctl: correctly report errors from SIOCAIFADDR_IN6 (authored by ivy).
in6_control_ioctl: correctly report errors from SIOCAIFADDR_IN6
Mon, Apr 7, 10:12 PM
kp added inline comments to D49665: pfctl: fix no nat / no rdr rules.
Mon, Apr 7, 1:21 PM
kp added inline comments to D49665: pfctl: fix no nat / no rdr rules.
Mon, Apr 7, 1:20 PM

Fri, Apr 4

kp requested review of D49665: pfctl: fix no nat / no rdr rules.
Fri, Apr 4, 4:18 PM

Thu, Apr 3

kp committed rG7e70d94acd68: pf: allow 'allow-opts' to be used on match rules (authored by kp).
pf: allow 'allow-opts' to be used on match rules
Thu, Apr 3, 5:00 PM
kp committed rG42aa0d02c281: pf tests: test table information export via snmp_pf (authored by kp).
pf tests: test table information export via snmp_pf
Thu, Apr 3, 4:44 PM
kp committed rGca1bf31177d2: pf tests: add a basic snmp_pf test case (authored by kp).
pf tests: add a basic snmp_pf test case
Thu, Apr 3, 4:44 PM
kp committed rG861b8faca9e3: snmp_pf: fix pfInterfacesIfRefsState (authored by kp).
snmp_pf: fix pfInterfacesIfRefsState
Thu, Apr 3, 4:43 PM
kp committed rG3410b98ce2c3: pf tests: add a basic snmp_pf test case (authored by kp).
pf tests: add a basic snmp_pf test case
Thu, Apr 3, 4:43 PM
kp committed rG7fa5f4995f06: pf tests: test table information export via snmp_pf (authored by kp).
pf tests: test table information export via snmp_pf
Thu, Apr 3, 4:43 PM
kp committed rGc844e848458f: snmp_pf: fix pfInterfacesIfRefsState (authored by kp).
snmp_pf: fix pfInterfacesIfRefsState
Thu, Apr 3, 4:43 PM

Wed, Apr 2

kp committed rG58164dcb55d6: pfctl: fix recursive printing of NAT rules (authored by kp).
pfctl: fix recursive printing of NAT rules
Wed, Apr 2, 7:13 PM

Tue, Apr 1

kp committed rG04a7134c1e92: if_ovpn: fix use-after-free of mbuf (authored by kp).
if_ovpn: fix use-after-free of mbuf
Tue, Apr 1, 2:26 PM

Mon, Mar 31

kp committed rG1bf46184cdc3: pf: factor out duplicate code to undo nat (authored by kp).
pf: factor out duplicate code to undo nat
Mon, Mar 31, 2:58 PM
kp committed rGe7995c99f1e4: pf: inline pf_addrcpy() (authored by kp).
pf: inline pf_addrcpy()
Mon, Mar 31, 2:58 PM
kp committed rG592418343348: pf: explicitly NULL state key pointers (authored by kp).
pf: explicitly NULL state key pointers
Mon, Mar 31, 2:58 PM
kp closed D49582: pf: factor out duplicate code to undo nat.
Mon, Mar 31, 2:58 PM
kp committed rGd7eacb1531e7: pf: simplify action resolution in pf_test_rule() (authored by kp).
pf: simplify action resolution in pf_test_rule()
Mon, Mar 31, 2:58 PM
kp closed D49581: pf: inline pf_addrcpy().
Mon, Mar 31, 2:58 PM
kp closed D49553: pf: explicitly NULL state key pointers.
Mon, Mar 31, 2:58 PM
kp committed rGbdea9cbcf2de: pf: don't use state keys after pf_state_insert() (authored by kp).
pf: don't use state keys after pf_state_insert()
Mon, Mar 31, 2:58 PM
kp committed rG8efd2acf07bc: pf: improve pf_state_key_attach() error handling (authored by kp).
pf: improve pf_state_key_attach() error handling
Mon, Mar 31, 2:58 PM
kp closed D49552: pf: simplify action resolution in pf_test_rule().
Mon, Mar 31, 2:58 PM
kp closed D49551: pf: don't use state keys after pf_state_insert().
Mon, Mar 31, 2:58 PM
kp closed D49550: pf: improve pf_state_key_attach() error handling.
Mon, Mar 31, 2:58 PM
kp added inline comments to D49582: pf: factor out duplicate code to undo nat.
Mon, Mar 31, 9:49 AM
kp committed rG6091e2aa9236: pfctl.8: fix typo in reference to rc.conf variable (authored by quentin.thebault_defenso.fr).
pfctl.8: fix typo in reference to rc.conf variable
Mon, Mar 31, 7:56 AM

Sun, Mar 30

kp requested review of D49582: pf: factor out duplicate code to undo nat.
Sun, Mar 30, 7:55 PM
kp requested review of D49581: pf: inline pf_addrcpy().
Sun, Mar 30, 7:55 PM
kp updated the diff for D49550: pf: improve pf_state_key_attach() error handling.

Move free operations outside the lock

Sun, Mar 30, 7:53 PM

Sat, Mar 29

kp added inline comments to D49551: pf: don't use state keys after pf_state_insert().
Sat, Mar 29, 9:53 AM
kp added a comment to D49551: pf: don't use state keys after pf_state_insert().

The pf_pdesc is always on the stack, is it?

Sat, Mar 29, 9:44 AM

Fri, Mar 28

kp requested review of D49553: pf: explicitly NULL state key pointers.
Fri, Mar 28, 2:48 PM
kp requested review of D49552: pf: simplify action resolution in pf_test_rule().
Fri, Mar 28, 2:47 PM
kp requested review of D49551: pf: don't use state keys after pf_state_insert().
Fri, Mar 28, 2:47 PM
kp requested review of D49550: pf: improve pf_state_key_attach() error handling.
Fri, Mar 28, 2:47 PM
kp added a comment to D49520: pf: Clear state key pointers after freeing them.

Sure, I'll drop this diff if you're going to roll it into your patch set somehow.

Fri, Mar 28, 2:42 PM
kp added a comment to D49221: pfctl: Add modern NAT syntax.

Looks good. It does still need the man page updates. We can probably stea^W borrow those from OpenBSD.

Fri, Mar 28, 2:38 PM
kp added a comment to D49520: pf: Clear state key pointers after freeing them.

I've added this as well:

Fri, Mar 28, 11:53 AM