Page MenuHomeFreeBSD

kp (Kristof Provost)
Troubleshooter

Projects (6)

User Details

User Since
Sep 28 2014, 7:22 PM (533 w, 5 d)

Recent Activity

Yesterday

kp committed R11:b1767abcb9a3: net/libpfctl: update main version (authored by kp).
net/libpfctl: update main version
Fri, Dec 20, 10:05 PM
kp accepted D48158: pf.conf.5: Fix endpoint-independent description.
Fri, Dec 20, 2:00 PM

Wed, Dec 18

kp committed rG3624de539499: if_ovpn: improve reconnect handling (authored by kp).
if_ovpn: improve reconnect handling
Wed, Dec 18, 4:18 PM

Tue, Dec 17

kp committed rG01eb1261443d: pf: fix double free in pf_state_key_attach() (authored by kp).
pf: fix double free in pf_state_key_attach()
Tue, Dec 17, 8:34 PM
kp committed rGf25d7ff3037e: pf: SCTP abort messages fully close the connection (authored by kp).
pf: SCTP abort messages fully close the connection
Tue, Dec 17, 8:34 PM
kp committed rG32cac604487b: pf tests: test dummynet on nat64 rules (authored by kp).
pf tests: test dummynet on nat64 rules
Tue, Dec 17, 10:16 AM
kp closed D47804: pf: handle fragmentation for nat64.
Tue, Dec 17, 10:15 AM
kp closed D47800: pfctl: print_rule: rename opts -> ropts.
Tue, Dec 17, 10:15 AM
kp committed rG5d1219378dd5: pf: teach nat64 to handle 0 UDP checksums (authored by kp).
pf: teach nat64 to handle 0 UDP checksums
Tue, Dec 17, 10:11 AM
kp committed rG706b42cc4bd9: pf: give the correct address family to dummynet after nat64 (authored by kp).
pf: give the correct address family to dummynet after nat64
Tue, Dec 17, 10:11 AM
kp committed rG08a512019ccb: pf: fix dummynet + route-to for IPv6 (authored by kp).
pf: fix dummynet + route-to for IPv6
Tue, Dec 17, 10:11 AM
kp committed rG7f3d159b9ff2: pf tests: test using an address range inside a table for nat64 (authored by kp).
pf tests: test using an address range inside a table for nat64
Tue, Dec 17, 10:11 AM
kp committed rGbdb583afa198: pf tests: test address range as nat64 from address (authored by kp).
pf tests: test address range as nat64 from address
Tue, Dec 17, 10:11 AM
kp committed rGe0dcc51ddb43: pfctl: do not allow af-to tables without round-robin (authored by kp).
pfctl: do not allow af-to tables without round-robin
Tue, Dec 17, 10:11 AM
kp closed D47803: pf: update pd->tot_len after reassembly.
Tue, Dec 17, 10:11 AM
kp committed rG125e395278cf: pf tests: test not having an IPv4 address to nat64 to (authored by kp).
pf tests: test not having an IPv4 address to nat64 to
Tue, Dec 17, 10:11 AM
kp committed rG27fca15016a9: pf tests: validate ToS translation with nat64 (authored by kp).
pf tests: validate ToS translation with nat64
Tue, Dec 17, 10:11 AM
kp committed rG1df79d81343d: pf: preserve TOS with nat64 (authored by kp).
pf: preserve TOS with nat64
Tue, Dec 17, 10:11 AM
kp committed rGe128e988a26a: pf tests: check packet reassembly with nat64 (authored by kp).
pf tests: check packet reassembly with nat64
Tue, Dec 17, 10:11 AM
kp committed rG7cae58a44955: pf: handle fragmentation for nat64 (authored by kp).
pf: handle fragmentation for nat64
Tue, Dec 17, 10:11 AM
kp committed rG6c5c91a039c7: pf: update pd->tot_len after reassembly (authored by kp).
pf: update pd->tot_len after reassembly
Tue, Dec 17, 10:10 AM
kp closed D47799: pf: add forgotten fixup for icmp6 id's when translating.
Tue, Dec 17, 10:10 AM
kp committed rGb717c67686c0: pf tests: verify that we preserve the hop limit/TTL for ICMP errors (authored by kp).
pf tests: verify that we preserve the hop limit/TTL for ICMP errors
Tue, Dec 17, 10:10 AM
kp committed rGc6210cfd58f6: pf: fix if-bound with nat64 (authored by kp).
pf: fix if-bound with nat64
Tue, Dec 17, 10:10 AM
kp committed rGd7e9df4fc67f: pfctl: print_rule: rename opts -> ropts (authored by kp).
pfctl: print_rule: rename opts -> ropts
Tue, Dec 17, 10:10 AM
kp committed rGf1ddd7f1dae6: pf: add forgotten fixup for icmp6 id's when translating (authored by kp).
pf: add forgotten fixup for icmp6 id's when translating
Tue, Dec 17, 10:10 AM
kp closed D47802: pf tests: verify that we preserve the hop limit/TTL for ICMP errors.
Tue, Dec 17, 10:10 AM
kp committed rG373d6dbf34a8: pf tests: verify that ICMP destination unreachable makes it through NAT64 (authored by kp).
pf tests: verify that ICMP destination unreachable makes it through NAT64
Tue, Dec 17, 10:10 AM
kp committed rGbc66cb3bfa9b: pf tests: verify that ICMP port unreachable makes it through NAT64 (authored by kp).
pf tests: verify that ICMP port unreachable makes it through NAT64
Tue, Dec 17, 10:10 AM
kp closed D47795: pfctl: basic nat64 parser test.
Tue, Dec 17, 10:10 AM
kp committed rGa4e040329525: pf tests: verify that TCP RST makes it through NAT64 (authored by kp).
pf tests: verify that TCP RST makes it through NAT64
Tue, Dec 17, 10:10 AM
kp closed D47801: pf: fix if-bound with nat64.
Tue, Dec 17, 10:10 AM
kp closed D47800: pfctl: print_rule: rename opts -> ropts.
Tue, Dec 17, 10:10 AM
kp committed rG86bcaedd35f4: pfctl: basic nat64 parser test (authored by kp).
pfctl: basic nat64 parser test
Tue, Dec 17, 10:10 AM
kp committed rGa43589dcbf8b: pf tests: add an SCTP test case for nat64 (authored by kp).
pf tests: add an SCTP test case for nat64
Tue, Dec 17, 10:10 AM
kp closed D47798: pf tests: verify that ICMP destination unreachable makes it through NAT64.
Tue, Dec 17, 10:10 AM
kp closed D47797: pf tests: verify that ICMP port unreachable makes it through NAT64.
Tue, Dec 17, 10:10 AM
kp closed D47796: pf tests: verify that TCP RST makes it through NAT64.
Tue, Dec 17, 10:10 AM
kp committed rG7e309356b009: pf tests: add a UDP test case for nat64 (authored by kp).
pf tests: add a UDP test case for nat64
Tue, Dec 17, 10:10 AM
kp committed rG0656a680567a: pf tests: basic nat64 test case (authored by kp).
pf tests: basic nat64 test case
Tue, Dec 17, 10:10 AM
kp committed rG22c634905bd4: pf tests: add a TCP test case for nat64 (authored by kp).
pf tests: add a TCP test case for nat64
Tue, Dec 17, 10:10 AM
kp committed rGeaf484fdb70d: pf.conf.5: document af-to (aka nat64) (authored by kp).
pf.conf.5: document af-to (aka nat64)
Tue, Dec 17, 10:10 AM
kp closed D47794: pf tests: add an SCTP test case for nat64.
Tue, Dec 17, 10:10 AM
kp closed D47791: pf tests: basic nat64 test case.
Tue, Dec 17, 10:10 AM
kp closed D47793: pf tests: add a UDP test case for nat64.
Tue, Dec 17, 10:10 AM
kp closed D47792: pf tests: add a TCP test case for nat64.
Tue, Dec 17, 10:10 AM
kp committed rGaa69fdf1542d: pfctl: change for af-to / NAT64 support. (authored by kp).
pfctl: change for af-to / NAT64 support.
Tue, Dec 17, 10:09 AM
kp committed rGb8e538443882: pf: drop packets if they fail nat64 translation (authored by kp).
pf: drop packets if they fail nat64 translation
Tue, Dec 17, 10:09 AM
kp closed D47790: pfctl: change for af-to / NAT64 support..
Tue, Dec 17, 10:09 AM
kp committed rGd89a5d853e2b: pf: support nat64 for SCTP (authored by kp).
pf: support nat64 for SCTP
Tue, Dec 17, 10:09 AM
kp closed D47789: pf: support nat64 for SCTP.
Tue, Dec 17, 10:09 AM
kp committed rGea9113be3f19: pf: extra route lookup in pf_route(6)() (authored by kp).
pf: extra route lookup in pf_route(6)()
Tue, Dec 17, 10:09 AM
kp closed D47788: pf: extra route lookup in pf_route(6)().
Tue, Dec 17, 10:09 AM
kp committed rGebe11b46988e: pf: fix state export in the face of NAT64 (authored by kp).
pf: fix state export in the face of NAT64
Tue, Dec 17, 10:09 AM
kp closed D47787: pf: fix state export in the face of NAT64.
Tue, Dec 17, 10:09 AM
kp committed rGfcdb520c1b4e: pf: nat64 (authored by kp).
pf: nat64
Tue, Dec 17, 10:09 AM
kp closed D47786: pf: nat64.
Tue, Dec 17, 10:09 AM
kp committed rGe4e0f497429c: in: add in_mask2len() (authored by kp).
in: add in_mask2len()
Tue, Dec 17, 10:08 AM
kp closed D47785: in: add in_mask2len().
Tue, Dec 17, 10:08 AM
kp committed rG2d7e68d5cd76: pf: add post-NAT src/dst address/port to pf_pdesc (authored by kp).
pf: add post-NAT src/dst address/port to pf_pdesc
Tue, Dec 17, 10:08 AM
kp closed D47784: pf: add post-NAT src/dst address/port to pf_pdesc.
Tue, Dec 17, 10:08 AM
kp closed D47783: pf: partially import OpenBSD's NAT rewrite.
Tue, Dec 17, 10:08 AM
kp committed rGe11dacbf8484: pf: partially import OpenBSD's NAT rewrite (authored by kp).
pf: partially import OpenBSD's NAT rewrite
Tue, Dec 17, 10:08 AM

Mon, Dec 16

kp committed rG85570785b9ce: pf: remove unused variable from pf_pdesc (authored by kp).
pf: remove unused variable from pf_pdesc
Mon, Dec 16, 10:35 PM
kp committed rG67b655980885: pf: fix address range handling in pfr_pool_get() (authored by kp).
pf: fix address range handling in pfr_pool_get()
Mon, Dec 16, 10:35 PM
kp committed rG358c5f5c0899: pf: fix cleanup deadlock (authored by kp).
pf: fix cleanup deadlock
Mon, Dec 16, 10:34 PM
kp closed D48083: pf: fix address range handling in pfr_pool_get().
Mon, Dec 16, 10:34 PM
kp closed D48082: pf: fix cleanup deadlock.
Mon, Dec 16, 10:34 PM
kp added a comment to D48087: kyua: Add requirement resolver concept.

I generally share Mark's views. I was tempted to suggest we should rename it to 'load-kmods' or similar, but there's a somewhat reasonable path to it also being able to install required packages (even if that will require test modifications), so keeping the generic name seems sensible. If we do get to that point we should consider adding a 'kyua prepare' or something to take care of all of the requirements (i.e. kmods, packages) it knows about. That should let us run (most) tests with kyua prepare && kyua test on a new install. (That's very much a maybe someday sort of thing, we do not need that to proceed here.)

Mon, Dec 16, 12:51 PM

Sat, Dec 14

kp requested review of D48083: pf: fix address range handling in pfr_pool_get().
Sat, Dec 14, 7:36 PM
kp requested review of D48082: pf: fix cleanup deadlock.
Sat, Dec 14, 7:36 PM
kp committed rGac92792bbdb2: pfctl: clear statistic for specified addresses (authored by kp).
pfctl: clear statistic for specified addresses
Sat, Dec 14, 2:42 PM
kp committed rG642ade0a3d82: pfctl: clear statistic for specified addresses (authored by kp).
pfctl: clear statistic for specified addresses
Sat, Dec 14, 2:42 PM

Mon, Dec 9

kp added a comment to D47953: pf: Force logging if pf_create_state() fails.

Does this need an MFC tag too?

Mon, Dec 9, 10:25 AM
kp committed rG5b59b0c61e29: pfctl: add -T `reset` to touch pfras_tzero only for non-zero entries (authored by Leonid Evdokimov <leon+freebsd@darkk.net.ru>).
pfctl: add -T `reset` to touch pfras_tzero only for non-zero entries
Mon, Dec 9, 9:40 AM

Wed, Dec 4

kp accepted D47906: pf: Don't pfsync states with unrecoverable routing information.

LGTM. Approved regardless of how you choose to deal with the remarks I've raised.

Wed, Dec 4, 10:53 PM
kp committed rGf966ef3a6770: pf: fold if (s != NULL) and if (s) into one block (authored by kp).
pf: fold if (s != NULL) and if (s) into one block
Wed, Dec 4, 1:23 PM

Tue, Dec 3

kp committed rGc22c98798456: pf: fix potential NULL dereference in SCTP multihome handling (authored by kp).
pf: fix potential NULL dereference in SCTP multihome handling
Tue, Dec 3, 7:29 PM
kp committed rGdaad0b650135: LINT: Remove DTrace support, but leave the commented out option (authored by kp).
LINT: Remove DTrace support, but leave the commented out option
Tue, Dec 3, 4:03 PM

Mon, Dec 2

kp committed rG2f915345634e: LINT: Remove DTrace support (authored by kp).
LINT: Remove DTrace support
Mon, Dec 2, 7:39 PM
kp committed rG928864a93594: fix build with LOCK_PROFILING but without KDTRACE_HOOKS (authored by kp).
fix build with LOCK_PROFILING but without KDTRACE_HOOKS
Mon, Dec 2, 7:39 PM
kp closed D47821: LINT: Remove DTrace support.
Mon, Dec 2, 7:39 PM
kp closed D47822: fix build with LOCK_PROFILING but without KDTRACE_HOOKS.
Mon, Dec 2, 7:39 PM

Fri, Nov 29

kp added inline comments to D47822: fix build with LOCK_PROFILING but without KDTRACE_HOOKS.
Fri, Nov 29, 5:36 PM
kp accepted D47827: Draft: pf: Move route-to information to pf_rule_actions.

Approved.

Fri, Nov 29, 1:39 PM
kp updated the diff for D47822: fix build with LOCK_PROFILING but without KDTRACE_HOOKS.

Review remarks

Fri, Nov 29, 12:59 PM
kp accepted D47827: Draft: pf: Move route-to information to pf_rule_actions.

Approved (without the 'draft' in the commit header line, of course).

Fri, Nov 29, 12:38 PM

Thu, Nov 28

kp updated the diff for D47822: fix build with LOCK_PROFILING but without KDTRACE_HOOKS.

review remarks

Thu, Nov 28, 5:22 PM
kp added a comment to D47827: Draft: pf: Move route-to information to pf_rule_actions.

I need to have a closer look again tomorrow, but this looks like a good idea.
It expects to be applied on top of D47770, right?

Thu, Nov 28, 4:24 PM
kp updated the diff for D47783: pf: partially import OpenBSD's NAT rewrite.

rename PF_RT_RPOOL/PF_RT_NAT

Thu, Nov 28, 3:54 PM
kp accepted D47770: pf: Fix source node locking.

Still approved :)

Thu, Nov 28, 3:48 PM
kp added a comment to D47106: add TH_AE capabilities to ppp and pf.

@kp can you please review the PF-related changes in this Diff?

Thu, Nov 28, 3:47 PM
kp accepted D47770: pf: Fix source node locking.

Approved.

Thu, Nov 28, 2:15 PM
kp added inline comments to D47822: fix build with LOCK_PROFILING but without KDTRACE_HOOKS.
Thu, Nov 28, 1:55 PM
kp added inline comments to D47783: pf: partially import OpenBSD's NAT rewrite.
Thu, Nov 28, 10:26 AM
kp added inline comments to D47788: pf: extra route lookup in pf_route(6)().
Thu, Nov 28, 9:33 AM
kp added inline comments to D47783: pf: partially import OpenBSD's NAT rewrite.
Thu, Nov 28, 8:01 AM
kp added inline comments to D47788: pf: extra route lookup in pf_route(6)().
Thu, Nov 28, 7:56 AM

Wed, Nov 27

kp added a reviewer for D47821: LINT: Remove DTrace support: DTrace.
Wed, Nov 27, 8:40 PM
kp requested review of D47822: fix build with LOCK_PROFILING but without KDTRACE_HOOKS.
Wed, Nov 27, 8:39 PM