Page MenuHomeFreeBSD

kp (Kristof Provost)
Troubleshooter

Projects (6)

User Details

User Since
Sep 28 2014, 7:22 PM (539 w, 6 d)

Recent Activity

Thu, Jan 30

kp committed rGa55197c3228c: if_ovpn: fix module load in NOINET6 kernels (authored by kp).
if_ovpn: fix module load in NOINET6 kernels
Thu, Jan 30, 12:43 PM
kp committed rG491f5e37ae45: pf: add 'allow-related' to always allow SCTP multihome extra connections (authored by kp).
pf: add 'allow-related' to always allow SCTP multihome extra connections
Thu, Jan 30, 11:03 AM
kp committed rG4557b1693a11: pf: verify SCTP v_tag before updating connection state (authored by kp).
pf: verify SCTP v_tag before updating connection state
Thu, Jan 30, 11:03 AM
kp committed rGfc167e91313c: pf: verify that ABORT chunks are not mixed with DATA chunks (authored by kp).
pf: verify that ABORT chunks are not mixed with DATA chunks
Thu, Jan 30, 11:02 AM
kp committed rGd467e667dfcc: pf: add extra SCTP multihoming probe points (authored by kp).
pf: add extra SCTP multihoming probe points
Thu, Jan 30, 11:02 AM

Mon, Jan 27

kp committed rG1c465e529208: netinet: enter epoch in garp_rexmit() (authored by kp).
netinet: enter epoch in garp_rexmit()
Mon, Jan 27, 5:22 PM
kp committed rGe69309223199: netinet: enter epoch in garp_rexmit() (authored by kp).
netinet: enter epoch in garp_rexmit()
Mon, Jan 27, 5:22 PM

Fri, Jan 24

kp committed rG3bf6554017b7: pf: remove PFLOGIFS_MAX (authored by kp).
pf: remove PFLOGIFS_MAX
Fri, Jan 24, 10:26 AM
kp committed rG7a372bded812: pf: make reply-to work with nat64 (authored by kp).
pf: make reply-to work with nat64
Fri, Jan 24, 10:26 AM
kp committed rG06a6ec55fbd0: pf: ignore/preserve ECN bits on ToS matching and scrubbing (authored by kp).
pf: ignore/preserve ECN bits on ToS matching and scrubbing
Fri, Jan 24, 10:26 AM
kp committed rGca0e69345320: pf: cope with route-to on af-to rules (authored by kp).
pf: cope with route-to on af-to rules
Fri, Jan 24, 10:26 AM
kp committed rG0972294ef034: pf: add a dedicated pf pool for route options (authored by kp).
pf: add a dedicated pf pool for route options
Fri, Jan 24, 10:26 AM
kp committed rG899e79760dcc: pfctl: allow an implicit address family for af-to rules (authored by kp).
pfctl: allow an implicit address family for af-to rules
Fri, Jan 24, 10:26 AM
kp committed rGaf33f86e6aef: carp: don't unintentionally revert to multicast mode (authored by kp).
carp: don't unintentionally revert to multicast mode
Fri, Jan 24, 10:26 AM
kp committed rG3331975ab18f: pf: check rather than assert pool type (authored by kp).
pf: check rather than assert pool type
Fri, Jan 24, 10:26 AM
kp committed rG5cb08fddef99: pfctl: improve NAT pool handling (authored by kp).
pfctl: improve NAT pool handling
Fri, Jan 24, 10:26 AM
kp committed rG096efeb658b5: pfctl: follow rpool -> rdr rename (authored by kp).
pfctl: follow rpool -> rdr rename
Fri, Jan 24, 10:26 AM

Thu, Jan 23

kp committed rG697c1568b75a: pf: fix IPv6 route lookup for nat64 (authored by kp).
pf: fix IPv6 route lookup for nat64
Thu, Jan 23, 12:59 PM

Mon, Jan 20

kp committed rGfaec43a79bf9: pf: avoid use-after-free on reassembly (authored by kp).
pf: avoid use-after-free on reassembly
Mon, Jan 20, 4:28 PM
kp committed rG980eedb0cad6: pf: avoid use-after-free on reassembly (authored by kp).
pf: avoid use-after-free on reassembly
Mon, Jan 20, 4:28 PM
kp committed rGb4bd97ec168e: netinet tests: basic garp test (authored by kp).
netinet tests: basic garp test
Mon, Jan 20, 3:11 PM
kp committed rG38fdcca05d09: netinet: enter epoch in garp_rexmit() (authored by kp).
netinet: enter epoch in garp_rexmit()
Mon, Jan 20, 3:11 PM
kp committed rG013784c967f9: netinet: virtualize net.link.ether.inet.garp_rexmit_count (authored by kp).
netinet: virtualize net.link.ether.inet.garp_rexmit_count
Mon, Jan 20, 3:11 PM

Sat, Jan 18

kp committed rG685cafd668f5: pf: allow ICMP messages related to an SCTP state to pass (authored by kp).
pf: allow ICMP messages related to an SCTP state to pass
Sat, Jan 18, 11:59 PM

Fri, Jan 17

kp committed rG7f846fc0e7ce: pf tests: reproduce use-after-free in fragment reassembly (authored by kp).
pf tests: reproduce use-after-free in fragment reassembly
Fri, Jan 17, 4:02 PM
kp committed rG76e00c722bee: dummymbuf: add 'enlarge' (authored by kp).
dummymbuf: add 'enlarge'
Fri, Jan 17, 4:02 PM
kp committed rG5d28f4cab8d5: pf: clean up mbuf passing for reassembly (authored by kp).
pf: clean up mbuf passing for reassembly
Fri, Jan 17, 4:02 PM
kp committed rG4713d2fd5663: pf: verify SCTP v_tag before updating connection state (authored by kp).
pf: verify SCTP v_tag before updating connection state
Fri, Jan 17, 12:07 PM
kp committed rGe4f2733df8c9: pf: add 'allow-related' to always allow SCTP multihome extra connections (authored by kp).
pf: add 'allow-related' to always allow SCTP multihome extra connections
Fri, Jan 17, 12:07 PM
kp committed rG541ea3d7828e: pf: verify that ABORT chunks are not mixed with DATA chunks (authored by kp).
pf: verify that ABORT chunks are not mixed with DATA chunks
Fri, Jan 17, 12:07 PM
kp closed D48453: pf: add 'allow-related' to always allow SCTP multihome extra connections.
Fri, Jan 17, 12:07 PM

Thu, Jan 16

kp committed rG635c2b82f60e: pf tests: check cleared time when zeroing stats for table addresses (authored by leon_darkk.net.ru).
pf tests: check cleared time when zeroing stats for table addresses
Thu, Jan 16, 3:24 PM
kp committed rG3870483ec496: pf tests: check cleared time when zeroing stats for table addresses (authored by leon_darkk.net.ru).
pf tests: check cleared time when zeroing stats for table addresses
Thu, Jan 16, 3:24 PM
kp accepted D48478: genl: properly handle possible failures by snl(3) library.
Thu, Jan 16, 11:03 AM
kp accepted D48477: netlink: change snl(3) API for more robust handling of malloc errors.

Note for @kp . Even without this change there is a lot of bad copy & paste in libpfctl and lack of result checking. The change is not expected to break anything beyond current level of brokenness. Once we accept this revision, and maybe a couple future ones, I promise to do a sweep over libpfctl. It is too early to do it now, since I might find more potential malloc failures not propagated to API user as well as general API pitfalls.

Thu, Jan 16, 11:02 AM
kp committed rG7c882c69a4f0: libpfctl: use snl_f_p_empty instead of declaring own empty array (authored by kp).
libpfctl: use snl_f_p_empty instead of declaring own empty array
Thu, Jan 16, 9:11 AM
kp closed D48460: libpfctl: use snl_f_p_empty instead of declaring own empty array.
Thu, Jan 16, 9:11 AM

Wed, Jan 15

kp committed rG2d2481c35f5a: pf: add extra SCTP multihoming probe points (authored by kp).
pf: add extra SCTP multihoming probe points
Wed, Jan 15, 10:07 PM
kp requested review of D48460: libpfctl: use snl_f_p_empty instead of declaring own empty array.
Wed, Jan 15, 11:05 AM

Tue, Jan 14

kp committed rG5466aca1536e: pf: minor fixes for pf_walk_header6() (authored by kp).
pf: minor fixes for pf_walk_header6()
Tue, Jan 14, 10:38 AM
kp committed rGd90854a60a91: pf: reset index if it's outside the table (authored by kp).
pf: reset index if it's outside the table
Tue, Jan 14, 10:38 AM
kp committed rG1941d370bf89: pf: pass struct pf_pdesc to pf_walk_option6() and pf_walk_header6() (authored by kp).
pf: pass struct pf_pdesc to pf_walk_option6() and pf_walk_header6()
Tue, Jan 14, 10:38 AM
kp committed rG3b79f6d2d394: pf: do not keep state when dropping overlapping IPv6 fragments (authored by kp).
pf: do not keep state when dropping overlapping IPv6 fragments
Tue, Jan 14, 10:38 AM
kp committed rG0300b49ac821: pf.conf.5: fix description for tcp.opening timeout (authored by kp).
pf.conf.5: fix description for tcp.opening timeout
Tue, Jan 14, 10:38 AM
kp committed rGa8136ab47c97: pfctl: convert an snprintf to strlcpy (authored by kp).
pfctl: convert an snprintf to strlcpy
Tue, Jan 14, 10:38 AM
kp committed rG6a3266f72e43: pf: drop IPv6 packets built from overlapping fragments in pf reassembly (authored by kp).
pf: drop IPv6 packets built from overlapping fragments in pf reassembly
Tue, Jan 14, 10:38 AM
kp committed rGb6a5e2213938: pf.conf.5: make "self" a bit more visible (authored by kp).
pf.conf.5: make "self" a bit more visible
Tue, Jan 14, 10:38 AM
kp committed rG481374d5f7b0: pf: remove pf_remove_fragment() (authored by kp).
pf: remove pf_remove_fragment()
Tue, Jan 14, 10:38 AM
kp committed rGf2a1e40bb19b: pf: simplify state key setup (authored by kp).
pf: simplify state key setup
Tue, Jan 14, 10:38 AM
kp committed rG37101926c920: pf improve the icmp direction check (authored by kp).
pf improve the icmp direction check
Tue, Jan 14, 10:38 AM
kp committed rG0d68985b0170: pfctl: unbreak rule optimizer (authored by kp).
pfctl: unbreak rule optimizer
Tue, Jan 14, 10:38 AM
kp committed rGf88019e8a35c: pf: fixup af-to regression with match rules (authored by kp).
pf: fixup af-to regression with match rules
Tue, Jan 14, 10:38 AM
kp committed rG4aafc73d1255: pfctl: pfctl_set_hostid always returns 0 (authored by kp).
pfctl: pfctl_set_hostid always returns 0
Tue, Jan 14, 10:38 AM
kp committed rG441d489493e8: pf: convert DIOCRCLRTABLES to netlink (authored by kp).
pf: convert DIOCRCLRTABLES to netlink
Tue, Jan 14, 10:38 AM
kp requested review of D48453: pf: add 'allow-related' to always allow SCTP multihome extra connections.
Tue, Jan 14, 8:55 AM

Sun, Jan 12

kp committed rGdfd9c9bc3f86: umtx: handle allocation failire in umtx_pi_alloc() (authored by kp).
umtx: handle allocation failire in umtx_pi_alloc()
Sun, Jan 12, 10:21 AM
kp committed rG2e2c4e312ef1: umtx: handle allocation failire in umtx_pi_alloc() (authored by kp).
umtx: handle allocation failire in umtx_pi_alloc()
Sun, Jan 12, 10:21 AM

Sun, Jan 5

kp committed rG50c1e179b584: umtx: handle allocation failire in umtx_pi_alloc() (authored by kp).
umtx: handle allocation failire in umtx_pi_alloc()
Sun, Jan 5, 6:21 PM

Sat, Jan 4

kp committed rG7d5e02b01577: pf: allow ICMP messages related to an SCTP state to pass (authored by kp).
pf: allow ICMP messages related to an SCTP state to pass
Sat, Jan 4, 2:50 PM
kp closed D48170: pf: allow ICMP messages related to an SCTP state to pass.
Sat, Jan 4, 2:50 PM

Fri, Jan 3

kp accepted D48306: pf: netlink KPI use cleanup.

That looks good. Nice little tidy-up.

Fri, Jan 3, 9:35 PM

Jan 2 2025

kp committed rG0749d8134300: pf tests: check cleared time when zeroing stats for table addresses (authored by leon_darkk.net.ru).
pf tests: check cleared time when zeroing stats for table addresses
Jan 2 2025, 12:36 PM
kp closed D48242: pf (tests): Set cleared time when zeroing stats for table addresses.
Jan 2 2025, 12:35 PM

Dec 30 2024

kp committed rGe2bb5f213a72: pf: fix double free in pf_state_key_attach() (authored by kp).
pf: fix double free in pf_state_key_attach()
Dec 30 2024, 8:45 PM
kp committed rGe0a1a2e47fbf: if_ovpn: improve reconnect handling (authored by kp).
if_ovpn: improve reconnect handling
Dec 30 2024, 8:45 PM
kp committed rG0fd06bd44aa0: pf: fix double free in pf_state_key_attach() (authored by kp).
pf: fix double free in pf_state_key_attach()
Dec 30 2024, 8:45 PM
kp committed rG4be8e29e776b: pf: initialise addresses in pf_get_transaddr_af() (authored by kp).
pf: initialise addresses in pf_get_transaddr_af()
Dec 30 2024, 8:45 PM
kp committed rG54ead732cf08: pf: deduplicate IPPROTO_ICMPV6 and IPPROTO_ICMP handling (authored by kp).
pf: deduplicate IPPROTO_ICMPV6 and IPPROTO_ICMP handling
Dec 30 2024, 8:45 PM
kp committed rG07579e2110b3: pf: sprinkle const over function arguments (authored by kp).
pf: sprinkle const over function arguments
Dec 30 2024, 8:45 PM
kp committed rGec30ca2e13ae: pf: remove impossible condition (authored by kp).
pf: remove impossible condition
Dec 30 2024, 8:45 PM

Dec 29 2024

kp added a comment to D48242: pf (tests): Set cleared time when zeroing stats for table addresses.

I assume you're not entirely serious about the 'Sponsored by:' line?
I'm happy to credit any organisation for your work, but um .. it raises questions?

Dec 29 2024, 11:27 AM

Dec 27 2024

kp committed rG6c7cef47bdd0: pf: Set cleared time when zeroing stats for table addresses (authored by vegeta_tuxpowered.net).
pf: Set cleared time when zeroing stats for table addresses
Dec 27 2024, 6:05 PM
kp committed rG1d673cc1fd82: pf: Set cleared time when zeroing stats for table addresses (authored by vegeta_tuxpowered.net).
pf: Set cleared time when zeroing stats for table addresses
Dec 27 2024, 6:05 PM

Dec 24 2024

kp committed rG13ea23ee6eeb: pf: fix potential NULL dereference in SCTP multihome handling (authored by kp).
pf: fix potential NULL dereference in SCTP multihome handling
Dec 24 2024, 2:27 PM
kp committed rG30b9d8a73721: pfctl: add -T `reset` to touch pfras_tzero only for non-zero entries (authored by Leonid Evdokimov <leon+freebsd@darkk.net.ru>).
pfctl: add -T `reset` to touch pfras_tzero only for non-zero entries
Dec 24 2024, 2:27 PM
kp committed rGfd8dadbe222a: pf: fix potential NULL dereference in SCTP multihome handling (authored by kp).
pf: fix potential NULL dereference in SCTP multihome handling
Dec 24 2024, 2:26 PM
kp committed rG3fa5d13c5be0: pfctl: add -T `reset` to touch pfras_tzero only for non-zero entries (authored by Leonid Evdokimov <leon+freebsd@darkk.net.ru>).
pfctl: add -T `reset` to touch pfras_tzero only for non-zero entries
Dec 24 2024, 2:26 PM

Dec 21 2024

kp requested review of D48170: pf: allow ICMP messages related to an SCTP state to pass.
Dec 21 2024, 12:59 PM

Dec 20 2024

kp committed R11:b1767abcb9a3: net/libpfctl: update main version (authored by kp).
net/libpfctl: update main version
Dec 20 2024, 10:05 PM
kp accepted D48158: pf.conf.5: Fix endpoint-independent description.
Dec 20 2024, 2:00 PM

Dec 18 2024

kp committed rG3624de539499: if_ovpn: improve reconnect handling (authored by kp).
if_ovpn: improve reconnect handling
Dec 18 2024, 4:18 PM

Dec 17 2024

kp committed rG01eb1261443d: pf: fix double free in pf_state_key_attach() (authored by kp).
pf: fix double free in pf_state_key_attach()
Dec 17 2024, 8:34 PM
kp committed rGf25d7ff3037e: pf: SCTP abort messages fully close the connection (authored by kp).
pf: SCTP abort messages fully close the connection
Dec 17 2024, 8:34 PM
kp committed rG32cac604487b: pf tests: test dummynet on nat64 rules (authored by kp).
pf tests: test dummynet on nat64 rules
Dec 17 2024, 10:16 AM
kp closed D47804: pf: handle fragmentation for nat64.
Dec 17 2024, 10:15 AM
kp closed D47800: pfctl: print_rule: rename opts -> ropts.
Dec 17 2024, 10:15 AM
kp committed rG5d1219378dd5: pf: teach nat64 to handle 0 UDP checksums (authored by kp).
pf: teach nat64 to handle 0 UDP checksums
Dec 17 2024, 10:11 AM
kp committed rG706b42cc4bd9: pf: give the correct address family to dummynet after nat64 (authored by kp).
pf: give the correct address family to dummynet after nat64
Dec 17 2024, 10:11 AM
kp committed rG08a512019ccb: pf: fix dummynet + route-to for IPv6 (authored by kp).
pf: fix dummynet + route-to for IPv6
Dec 17 2024, 10:11 AM
kp committed rG7f3d159b9ff2: pf tests: test using an address range inside a table for nat64 (authored by kp).
pf tests: test using an address range inside a table for nat64
Dec 17 2024, 10:11 AM
kp committed rGbdb583afa198: pf tests: test address range as nat64 from address (authored by kp).
pf tests: test address range as nat64 from address
Dec 17 2024, 10:11 AM
kp committed rGe0dcc51ddb43: pfctl: do not allow af-to tables without round-robin (authored by kp).
pfctl: do not allow af-to tables without round-robin
Dec 17 2024, 10:11 AM
kp closed D47803: pf: update pd->tot_len after reassembly.
Dec 17 2024, 10:11 AM
kp committed rG125e395278cf: pf tests: test not having an IPv4 address to nat64 to (authored by kp).
pf tests: test not having an IPv4 address to nat64 to
Dec 17 2024, 10:11 AM
kp committed rG27fca15016a9: pf tests: validate ToS translation with nat64 (authored by kp).
pf tests: validate ToS translation with nat64
Dec 17 2024, 10:11 AM
kp committed rG1df79d81343d: pf: preserve TOS with nat64 (authored by kp).
pf: preserve TOS with nat64
Dec 17 2024, 10:11 AM
kp committed rGe128e988a26a: pf tests: check packet reassembly with nat64 (authored by kp).
pf tests: check packet reassembly with nat64
Dec 17 2024, 10:11 AM
kp committed rG7cae58a44955: pf: handle fragmentation for nat64 (authored by kp).
pf: handle fragmentation for nat64
Dec 17 2024, 10:11 AM
kp committed rG6c5c91a039c7: pf: update pd->tot_len after reassembly (authored by kp).
pf: update pd->tot_len after reassembly
Dec 17 2024, 10:10 AM
kp closed D47799: pf: add forgotten fixup for icmp6 id's when translating.
Dec 17 2024, 10:10 AM