pf.4/pf.conf.5: Remove unused sysctl
ClosedPublic
Actions

Authored by ziaee on Jun 14 2025, 9:16 PM.

Details

Reviewers

kp
ivy
carlavilla
mhorne

Group Reviewers

manpages

Commits

rGd16b1904d1ee: pf.4/pf.conf.5: Remove unused sysctl

Summary

"We never actually added the sysctl. The limit was implemented, and the sysctl to tune it was documented but never added (so the limit is there, but is always 16 and cannot be changed)." ~kp

Reported by: kp
Fixes: 339a1977c324 (pf: Add a systl to limit work)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ziaee created this revision.Jun 14 2025, 9:16 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 14 2025, 9:16 PM

ziaee requested review of this revision.Jun 14 2025, 9:16 PM

Harbormaster completed remote builds in B64876: Diff 157047.Jun 14 2025, 9:16 PM

ziaee added a child revision: D50856: pf.4/pfsync.4: Separate sysctl/tunables >> SYNOPSIS.Jun 14 2025, 9:19 PM

The change is good, but I'd rephrase the commit message slightly. We never actually added the sysctl. The limit was implemented, and the sysctl to tune it was documented but never added (so the limit is there, but is always 16 and cannot be changed).

This revision is now accepted and ready to land.Jun 16 2025, 11:42 AM

ziaee edited the summary of this revision. (Show Details)Jun 16 2025, 12:03 PM

Oh sure, blame me for the commit message ;)

LGTM.

Rofl, I just couldn't have said it better!

Closed by commit rGd16b1904d1ee: pf.4/pf.conf.5: Remove unused sysctl (authored by ziaee). · Explain WhyJun 25 2025, 11:22 PM

This revision was automatically updated to reflect the committed changes.

ziaee added a commit: rGd16b1904d1ee: pf.4/pf.conf.5: Remove unused sysctl.