Adding USERS and GROUPS names to be created

Changed %%LOCALBASE%% to %%PREFIX%% in rc file

In D48883#1119113, @diizzy wrote:

Thanks for confirming, this information should be in commit message

Updated commit message to include the information about opensearch (Sven Ruediger <admin@hackacad.net>) approbatiion.
Updating of %%JAVA_HOME%%, %%SEARCHUSER%% and %%SEARCHGROUP%% in rc script.

Suggestion for examples has been done (changed also plist, and the way to install examples into ${EXAMPLESDIR}).
Aslo updated pkg-message.in to reflect this change, and removed the "experimental" line.
Updated ${DISTNAME} as suggested.

All suggestion has been updated

Remove unused comment.

Updated port with suggestions from 0mp
Fixed distfile name that have changed on master site
Updated pkg-plist as well

All suggestion are done. See updates

In D49044#1118258, @allanjude wrote:

silly GNU getopt

Seems that this revision is not needed for the project I supposed to work on it. And I totally forgot that python is a flavor too.
Closing it. Sorry for the noise !

In D48886#1117828, @diizzy wrote:

In that case it should be referenced in commit message and from what I can tell there's no request anywhere? There's only one commit prior to this one regarding this port so I'm not sure what you're referring to.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274149

In D48886#1115064, @diizzy wrote:

Additionally why was this committed without maintainer consent (or maintainer timeout)?

All requested bits has been done !

Use DISTVERSION
Added missing dot at end of pkg-descr

Fix PLIST_SUB add SUB_LIST as well

Removing unneeded PORTREVISION

Since 0mp approved I Approve as well

In D48458#1113797, @mikael wrote:

Personally, I don't like it when a service downloads / installs things at launch, isn't there another way?

Seems ok for me.

• Using static pkg-plist instead of dynamic one
• pkg-message
• add suggested changes into home-assistant.in

Will be done in next diff (after a little test on poudriere).

Added Approved by: joneum (maintainer) in commit message

In D48658#1110416, @diizzy wrote:

Subject and desc are incorrect, refers to talloc instead of libtevent

Removed DOCSDIRS

Removed

In D48431#1105468, @0mp wrote:

One more question before we land it :)

I have no reasons to not approve this revision, but @garga as maintainer will have the last word

Updated commit message

In D48522#1107149, @0mp wrote:

Suggestions to the commit message:

www/apache24: Allow for overriding USERS and GROUPS via make.conf

It is a welcome addition for those building their own apache24 package
with custom UID/GID.

While here, use WWWOWN/WWWGRP instead of hardcoded www/www.

Also, please make sure to receive an approval from the maintainer before committing. Let me know when you get an approval from apache@freebsd.org.

In D48522#1107150, @0mp wrote:

BTW, please make sure that the www values are not hardcoded somewhere else as well:

1. Check the files/ directory.
2. Check the source code of apache for any obvious hardcoded user/group values for FreeBSD.