If others from samba team are ok, then this is ok for me.

Fixed RUN and BUILD_DEPENDS as pointed by 0mp

This port is consummer of pkgconfig
Backported detection fix with pkgconfig of picojson
Fixed the path of picojson.h in the header files
Make portlint and portclippy happy

In D50656#1186258, @diizzy wrote:

Ping and you probably also want to backport, https://github.com/Thalhammer/jwt-cpp/commit/cf0dab12633bb6c39ae7a7fe147b3d2fb7b3f047

Well I see no (bad) reasons to not accept that.

In D52160#1192409, @mandree wrote:

Please stop that. sudo may not even be my preferred tool to escalate privileges. I might prefer doas or su. Adding USES support for such a feature endorses it, and we'll see creeping changes to move the entire ports tree and user community towards SUDO.

Addedd suggestions from 0mp

Removed PORTREVISION as @kevans suggested.

Use PATCHES_SITES and PATCHFILES as suggested. Added some LOCALBASE for rsyslog.aug (like other patches).

rsyslog.aug has been cleaned (no more CRLF).

In D51104#1166467, @0mp wrote:

LGTM.

Also, you may consider something along those lines for the commit message:

net/samba420: Fix missing build dependency of bison

Bison is no longer an optional dependency in Samba 4.20,
so enable it by default. The bison dependency comes from
the Windows Search support implemented in Samba 4.20.

In D50656#1156650, @diizzy wrote:

Regarding picojson...
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=287277

In D50656#1156650, @diizzy wrote:

Regarding picojson...
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=287277

Hello
Great you are working on upstreaming your sssd patches :)

The change seems ok, I am surprised I didn't see any problems in my deployments or poudriere. Was a bug reported on Bugzilla for this ?

Added suggestions from @0mp

Removed uneeded comment.

In D50530#1153434, @0mp wrote:

Approved!

You will also need Approved by: maintainer timeout

In D50373#1149532, @0mp wrote:

Hey, just an idea: if you do not need to modify the patches, then you may consider PATCH_SITES instead of adding a copy of the patches to files/.

For example:

PATCH_SITES=	https://patch-diff.githubusercontent.com/raw/domoticz/domoticz/pull/
PATCHFILES+=	6252.patch:-p1 # https://github.com/domoticz/domoticz/pull/6252

Grep the ports tree for more examples. multimedia/gmmlib/Makefile is one of them.

Let's pushing this into ports !

In D49871#1137139, @diizzy wrote:

This should be upstreamed and pull from there.
Commit message is poor at best, explain what it fixes.

In D49871#1137054, @jlduran wrote:

PR number should be 284417.

Suggestion has been merged. Testing the port...

Fixed typo detected by @0mp

@acm has pushed some better modifications :)

Adding USERS and GROUPS names to be created

Changed %%LOCALBASE%% to %%PREFIX%% in rc file

In D48883#1119113, @diizzy wrote:

Thanks for confirming, this information should be in commit message

Updated commit message to include the information about opensearch (Sven Ruediger <admin@hackacad.net>) approbatiion.
Updating of %%JAVA_HOME%%, %%SEARCHUSER%% and %%SEARCHGROUP%% in rc script.

Suggestion for examples has been done (changed also plist, and the way to install examples into ${EXAMPLESDIR}).
Aslo updated pkg-message.in to reflect this change, and removed the "experimental" line.
Updated ${DISTNAME} as suggested.

All suggestion has been updated

Remove unused comment.