[PATCH] net/samba420: fix missing build dependency of bison

[kiwi]

Summary

net/samba420: fix missing build dependency of bison


Bison is no longer an optional dependency in Samba 4.20,
so enable it by default. The bison dependency comes from
the Windows Search support implemented in Samba 4.20.

PR:     285180
Approved by:    0mp (mentor)
Sponsored by:   Klara, Inc.

Test Plan

• Built with poudriere with base option and with : OPTIONS_FILE_UNSET+=GSSAPI_BUILTIN OPTIONS_FILE_SET+=GSSAPI_MIT in make.conf

[0mp]

LGTM.

Also, you may consider something along those lines for the commit message:

net/samba420: Fix missing build dependency of bison

Bison is no longer an optional dependency in Samba 4.20,
so enable it by default. The bison dependency comes from
the Windows Search support implemented in Samba 4.20.

net/samba420/Makefile

104

It's a minor thing, but I'd put bison at the beginning of the list to keep the list alphabetically sorted. (portfmt might be able to do that automatically, but it could be that it'll touch a lot of other parts in this file.)

[kiwi]

In D51104#1166467, @0mp wrote:

LGTM.

Also, you may consider something along those lines for the commit message:

net/samba420: Fix missing build dependency of bison

Bison is no longer an optional dependency in Samba 4.20,
so enable it by default. The bison dependency comes from
the Windows Search support implemented in Samba 4.20.

Thanks ! Good idea