Page MenuHomeFreeBSD

[PATCH] net/samba420: fix missing build dependency of bison
ClosedPublic

Authored by kiwi on Jul 1 2025, 1:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 10, 1:32 AM
Unknown Object (File)
Thu, Oct 2, 11:32 PM
Unknown Object (File)
Tue, Sep 30, 10:57 PM
Unknown Object (File)
Fri, Sep 26, 9:23 AM
Unknown Object (File)
Sep 12 2025, 8:29 PM
Unknown Object (File)
Sep 12 2025, 12:21 PM
Unknown Object (File)
Sep 12 2025, 8:58 AM
Unknown Object (File)
Sep 7 2025, 7:21 AM
Subscribers
None

Details

Summary
net/samba420: fix missing build dependency of bison


Bison is no longer an optional dependency in Samba 4.20,
so enable it by default. The bison dependency comes from
the Windows Search support implemented in Samba 4.20.

PR:     285180
Approved by:    0mp (mentor)
Sponsored by:   Klara, Inc.
Test Plan
  • Built with poudriere with base option and with : OPTIONS_FILE_UNSET+=GSSAPI_BUILTIN OPTIONS_FILE_SET+=GSSAPI_MIT in make.conf

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kiwi requested review of this revision.Jul 1 2025, 1:08 PM
kiwi created this revision.

LGTM.

Also, you may consider something along those lines for the commit message:

net/samba420: Fix missing build dependency of bison

Bison is no longer an optional dependency in Samba 4.20,
so enable it by default. The bison dependency comes from
the Windows Search support implemented in Samba 4.20.
net/samba420/Makefile
104

It's a minor thing, but I'd put bison at the beginning of the list to keep the list alphabetically sorted. (portfmt might be able to do that automatically, but it could be that it'll touch a lot of other parts in this file.)

This revision is now accepted and ready to land.Jul 1 2025, 1:16 PM
In D51104#1166467, @0mp wrote:

LGTM.

Also, you may consider something along those lines for the commit message:

net/samba420: Fix missing build dependency of bison

Bison is no longer an optional dependency in Samba 4.20,
so enable it by default. The bison dependency comes from
the Windows Search support implemented in Samba 4.20.

Thanks ! Good idea

kiwi marked an inline comment as done.