Page MenuHomeFreeBSD

[PATCH] www/apache24: Allow for overriding USERS and GROUPS via make.conf
ClosedPublic

Authored by kiwi on Jan 20 2025, 3:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 7, 5:17 AM
Unknown Object (File)
Fri, Oct 3, 9:53 AM
Unknown Object (File)
Tue, Sep 23, 1:33 PM
Unknown Object (File)
Sun, Sep 21, 8:24 AM
Unknown Object (File)
Thu, Sep 18, 7:58 PM
Unknown Object (File)
Thu, Sep 18, 5:20 AM
Unknown Object (File)
Wed, Sep 17, 6:34 AM
Unknown Object (File)
Sep 10 2025, 7:29 AM
Subscribers
None

Details

Summary
www/apache24: Allow for overriding USERS and GROUPS via make.conf

It is a welcome addition for those building their own apache24 package
with custom UID/GID.

PR:    284194
Sponsored by:   Klara, Inc.
Approved By:    0mp (mentor)

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kiwi requested review of this revision.Jan 20 2025, 3:26 PM
kiwi created this revision.
kiwi edited the summary of this revision. (Show Details)

Suggestions to the commit message:

www/apache24: Allow for overriding USERS and GROUPS via make.conf

It is a welcome addition for those building their own apache24 package
with custom UID/GID.

While here, use WWWOWN/WWWGRP instead of hardcoded www/www.

Also, please make sure to receive an approval from the maintainer before committing. Let me know when you get an approval from apache@freebsd.org.

BTW, please make sure that the www values are not hardcoded somewhere else as well:

  1. Check the files/ directory.
  2. Check the source code of apache for any obvious hardcoded user/group values for FreeBSD.
In D48522#1107150, @0mp wrote:

BTW, please make sure that the www values are not hardcoded somewhere else as well:

  1. Check the files/ directory.
  2. Check the source code of apache for any obvious hardcoded user/group values for FreeBSD.

Nothing found in the port (grep is my friend)

In D48522#1107149, @0mp wrote:

Suggestions to the commit message:

www/apache24: Allow for overriding USERS and GROUPS via make.conf

It is a welcome addition for those building their own apache24 package
with custom UID/GID.

While here, use WWWOWN/WWWGRP instead of hardcoded www/www.

Also, please make sure to receive an approval from the maintainer before committing. Let me know when you get an approval from apache@freebsd.org.

Thanks, applied. Will make a PR to be sure apache@ will approve that before commit

kiwi retitled this revision from [PATCH] www/apache24: use WWWOWN/WWWGRP instead of hardcoded www/www to [PATCH] www/apache24: Allow for overriding USERS and GROUPS via make.conf.
kiwi edited the summary of this revision. (Show Details)

Updated commit message

In D48522#1107150, @0mp wrote:

BTW, please make sure that the www values are not hardcoded somewhere else as well:

  1. Check the files/ directory.
  2. Check the source code of apache for any obvious hardcoded user/group values for FreeBSD.

Nothing found in the port (grep is my friend)

Great, thanks!

The patch looks good to me. Now we need to wait to Apache (although it'd probably be alright to commit this now under the portmgr blanket as you are basically improving the ports infrastructure here).

This revision was not accepted when it landed; it landed in state Needs Review.Jun 27 2025, 2:11 PM
This revision was automatically updated to reflect the committed changes.