Page MenuHomeFreeBSD

[PATCH] www/apache24: Allow for overriding USERS and GROUPS via make.conf
Needs ReviewPublic

Authored by kiwi on Mon, Jan 20, 3:26 PM.

Details

Reviewers
0mp
Summary
www/apache24: Allow for overriding USERS and GROUPS via make.conf

It is a welcome addition for those building their own apache24 package
with custom UID/GID.

PR:    284194
Sponsored by:   Klara, Inc.
Approved By:    0mp (mentor)

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kiwi requested review of this revision.Mon, Jan 20, 3:26 PM
kiwi created this revision.
kiwi edited the summary of this revision. (Show Details)

Suggestions to the commit message:

www/apache24: Allow for overriding USERS and GROUPS via make.conf

It is a welcome addition for those building their own apache24 package
with custom UID/GID.

While here, use WWWOWN/WWWGRP instead of hardcoded www/www.

Also, please make sure to receive an approval from the maintainer before committing. Let me know when you get an approval from apache@freebsd.org.

BTW, please make sure that the www values are not hardcoded somewhere else as well:

  1. Check the files/ directory.
  2. Check the source code of apache for any obvious hardcoded user/group values for FreeBSD.
In D48522#1107150, @0mp wrote:

BTW, please make sure that the www values are not hardcoded somewhere else as well:

  1. Check the files/ directory.
  2. Check the source code of apache for any obvious hardcoded user/group values for FreeBSD.

Nothing found in the port (grep is my friend)

In D48522#1107149, @0mp wrote:

Suggestions to the commit message:

www/apache24: Allow for overriding USERS and GROUPS via make.conf

It is a welcome addition for those building their own apache24 package
with custom UID/GID.

While here, use WWWOWN/WWWGRP instead of hardcoded www/www.

Also, please make sure to receive an approval from the maintainer before committing. Let me know when you get an approval from apache@freebsd.org.

Thanks, applied. Will make a PR to be sure apache@ will approve that before commit

kiwi retitled this revision from [PATCH] www/apache24: use WWWOWN/WWWGRP instead of hardcoded www/www to [PATCH] www/apache24: Allow for overriding USERS and GROUPS via make.conf.
kiwi edited the summary of this revision. (Show Details)

Updated commit message