[PATCH] www/apache24: Allow for overriding USERS and GROUPS via make.conf

[kiwi]

Summary

www/apache24: Allow for overriding USERS and GROUPS via make.conf

It is a welcome addition for those building their own apache24 package
with custom UID/GID.

PR:    284194
Sponsored by:   Klara, Inc.
Approved By:    0mp (mentor)

[0mp]

Suggestions to the commit message:

www/apache24: Allow for overriding USERS and GROUPS via make.conf

It is a welcome addition for those building their own apache24 package
with custom UID/GID.

While here, use WWWOWN/WWWGRP instead of hardcoded www/www.

Also, please make sure to receive an approval from the maintainer before committing. Let me know when you get an approval from [e-mail].

[0mp]

BTW, please make sure that the www values are not hardcoded somewhere else as well:

1. Check the files/ directory.
2. Check the source code of apache for any obvious hardcoded user/group values for FreeBSD.

[kiwi]

In D48522#1107150, @0mp wrote:

BTW, please make sure that the www values are not hardcoded somewhere else as well:

1. Check the files/ directory.
2. Check the source code of apache for any obvious hardcoded user/group values for FreeBSD.

Nothing found in the port (grep is my friend)

[kiwi]

In D48522#1107149, @0mp wrote:

Suggestions to the commit message:

www/apache24: Allow for overriding USERS and GROUPS via make.conf

It is a welcome addition for those building their own apache24 package
with custom UID/GID.

While here, use WWWOWN/WWWGRP instead of hardcoded www/www.

Also, please make sure to receive an approval from the maintainer before committing. Let me know when you get an approval from [e-mail].

Thanks, applied. Will make a PR to be sure apache@ will approve that before commit

[kiwi]

Updated commit message

[0mp]

In D48522#1107151, @kiwi wrote:

In D48522#1107150, @0mp wrote:

BTW, please make sure that the www values are not hardcoded somewhere else as well:

1. Check the files/ directory.
2. Check the source code of apache for any obvious hardcoded user/group values for FreeBSD.

Nothing found in the port (grep is my friend)

Great, thanks!

The patch looks good to me. Now we need to wait to Apache (although it'd probably be alright to commit this now under the portmgr blanket as you are basically improving the ports infrastructure here).