textproc/augeas: Fix rsyslog lense This integrate the PR863 that fixes parsing of rsyslogd.conf files with "if xxx then {}". PR: 287586 Approved by: 0mp (mentor) Approved by: maintainer timeout Sponsored by: Klara, Inc. Obtained from: https://github.com/hercules-team/augeas/pull/863
Details
Details
- Reviewers
0mp - Commits
- R11:cf6482319cf7: textproc/augeas: Fix rsyslog lense
- Tested successfully in production environment
- Port update checked by portclippy
- Package building successfully built using poudriere on 14.2-RELEAS
Diff Detail
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Looks great. Some notes about the commit message:
- Drop [PATCH].
- I'd use Obtained from instead of Pull Request. FreeBSD uses Pull Request for PRs from FreeBSD's GitHub. It's a GitHub equivalent of Phabricator's Differential Revision. We'd use that to point to a patch for the ports tree. We do not use it to point to a patch that inspired the change that we now apply to the ports tree.
- Add Approved by: maintainer timeout
Also, would it be better to use:
PATCH_SITES= https://github.com/hercules-team/augeas/pull/ PATCHFILES= 863.patch:-p1
but if that is not an option, then vendoring the patch is also fine.
textproc/augeas/files/patch-lenses_rsyslog.aug | ||
---|---|---|
41 | Side note: this should probably include directories and configuration files in LOCALBASE as well, right? This is out of scope for this patch but I just wanted to note that. |
Comment Actions
Use PATCHES_SITES and PATCHFILES as suggested. Added some LOCALBASE for rsyslog.aug (like other patches).
textproc/augeas/files/patch-lenses_rsyslog.aug | ||
---|---|---|
41 | Added such patch as it is done on others patches for lenses (see atch-lenses_pg__hba.aug for example). |