= 1.87
ClosedPublic
Actions

Authored by kiwi on May 16 2025, 11:41 AM.

Details

Reviewers

0mp

Commits

R11:2265bb7f1054: www/domoticz*: Fix build for boost >= 1.87

Summary

www/domoticz*: Fix build for boost >= 1.87

With boost >= 1.87, domoticz cannot be built. This has been
handled by PR 6252 on domoticz github.

I'm adding the patches to files/ because they do not apply
cleanly unfortunately when managed via PATCH_SITES.
The problem is that the upstream patch modifies the
msbuild-related parts of the build system. Those parts are
not relevant on FreeBSD and has been already removed in
previous updates. So adding modified version of the patches
from the GitHub PR to files/ seems to be the right approach.

PR:     286076
Reported by:    <erwin.freebsd-bugzilla@bk3.nl>
Approved by:    0mp (mentor)

Test Plan

Tested on poudriere on 14.1 and 14.2.

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kiwi requested review of this revision.May 16 2025, 11:41 AM

kiwi created this revision.

Hey, just an idea: if you do not need to modify the patches, then you may consider PATCH_SITES instead of adding a copy of the patches to files/.

For example:

PATCH_SITES=	https://patch-diff.githubusercontent.com/raw/domoticz/domoticz/pull/
PATCHFILES+=	6252.patch:-p1 # https://github.com/domoticz/domoticz/pull/6252

Grep the ports tree for more examples. multimedia/gmmlib/Makefile is one of them.

www/domoticz-devel/files/patch-pr6252
8	BTW, this link is broken.
www/domoticz/files/patch-pr6252
8	This link is broken as well.

In D50373#1149532, @0mp wrote:
Hey, just an idea: if you do not need to modify the patches, then you may consider PATCH_SITES instead of adding a copy of the patches to files/.

For example:
PATCH_SITES=	https://patch-diff.githubusercontent.com/raw/domoticz/domoticz/pull/
PATCHFILES+=	6252.patch:-p1 # https://github.com/domoticz/domoticz/pull/6252
Grep the ports tree for more examples. multimedia/gmmlib/Makefile is one of them.

Well the issue is the PR patch don't apply correctly so the author of bugzilla decided to reroll the patch.

kiwi edited the summary of this revision. (Show Details)May 16 2025, 1:47 PM

0mp accepted this revision.May 16 2025, 1:55 PM

This revision is now accepted and ready to land.May 16 2025, 1:55 PM

Closed by commit R11:2265bb7f1054: www/domoticz*: Fix build for boost >= 1.87 (authored by erwin freebsd <erwin.freebsd-bugzilla@bk3.nl>, committed by kiwi). · Explain WhyMay 16 2025, 2:03 PM

This revision was automatically updated to reflect the committed changes.

kiwi added a commit: R11:2265bb7f1054: www/domoticz*: Fix build for boost >= 1.87.