[PATCH] devel/jwt-cpp: Use release assets and other fixes

[kiwi]

Summary

devel/jwt-cpp: Use release assets and other fixes

After the nice suggestion from @diizzy and @mat, this port
will use the release assets instead.
LICENSE_FILE has been added and remove the picojson.h install.

Approved by:    0mp (mentor)
Approved by:    diizzy

Test Plan

Double checked with poudriere and futur consummers ports.

[0mp]

devel/jwt-cpp/Makefile

23

Why was COVERAGE and FUZZING on before and now it's gone? Could you add a note about that to the commit message?

24

What is the role of picojson here? I've heard it is a bundled dependecy. If this is true then if you disable it, don't you need to add picojson to RUN_DEPENDS or so?

25

I've heard that nlohmann-json is only necessary for example. Please note in the commit message that this is the reason why this dependency and related variables are removed.

26

Was it buggy before? It used to be an absolute path and now it is a relative one. Could you explain this part in the commit message?

[kiwi]

devel/jwt-cpp/Makefile

23

COVERAGE and FUZZING are not enabled per default. And are used to testing (according to CMakeFiles.txt)

24

Do you think only add RUN_DEPENDS can be ok ?
Because PICOJSON is lacking of cmake file and cannot be correctly detected when it is installed. So I am not sure it is really usefull to add RUN_DEPENDS in this case.

25

Ok

26

Thanks ! Will fix that

[diizzy]

Regarding picojson...
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=287277

[kiwi]

In D50656#1156650, @diizzy wrote:

Regarding picojson...
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=287277

Oh nice. Thanks !

[kiwi]

In D50656#1156650, @diizzy wrote:

Regarding picojson...
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=287277

Hello @diizzy, if you have some time, can you push this Bugzilla ? To permit me to reroll, and fix jwt-cpp port ?
Thanks

[diizzy]

Done, https://cgit.freebsd.org/ports/commit/?id=b125360a0b37b795731ed50ec2cbaf68c902e19c :-)

[diizzy]

Ping and you probably also want to backport, https://github.com/Thalhammer/jwt-cpp/commit/cf0dab12633bb6c39ae7a7fe147b3d2fb7b3f047

[kiwi]

In D50656#1186258, @diizzy wrote:

Ping and you probably also want to backport, https://github.com/Thalhammer/jwt-cpp/commit/cf0dab12633bb6c39ae7a7fe147b3d2fb7b3f047

Thanks just backported this other things related to pkgconfig and so.

[kiwi]

This port is consummer of pkgconfig
Backported detection fix with pkgconfig of picojson
Fixed the path of picojson.h in the header files
Make portlint and portclippy happy

[0mp]

devel/jwt-cpp/Makefile

16

This is not correct usually.

You could have this instead:

BUILD_DEPENDS= ${_BUILD_RUN_DEPENDS}
RUN_DEPENDS= ${_BUILD_RUN_DEPENDS}
_BUILD_RUN_DEPENDS= ${LOCALBASE}/include/picojson.h:devel/picojson

but to be honest in this case I'd just:

BUILD_DEPENDS=${LOCALBASE}/include/picojson.h:devel/picojson
RUN_DEPENDS=${LOCALBASE}/include/picojson.h:devel/picojson

because it's just a single dependency.

The reason why RUN_DEPENDS= ${BUILD_DEPENDS} is incorrect is that the ports framework appends extra dependencies to BUILD_DEPENDS. I suspect that USES=cmake add CMake to BUILD_DEPENDS at some point. As a result, if you set RUN_DEPENDS= ${BUILD_DEPENDS} you end up with CMake in RUN_DEPENDS.

[kiwi]

devel/jwt-cpp/Makefile

16

Oh thanks for the hint. I will use the honest way. But I keep in mind the BUILD_DEPEND have cmake as dependency because of the USES=.

[kiwi]

Fixed RUN and BUILD_DEPENDS as pointed by 0mp