Page MenuHomeFreeBSD
People kib

kib (Konstantin Belousov)
User

Projects

User Details

User Since
May 16 2014, 7:35 PM (606 w, 5 d)

Recent Activity
View All

Yesterday

kib committed rG353ba3bf08fd: vm_object_coalesce(): do not account holes twice (authored by kib).
vm_object_coalesce(): do not account holes twice
Tue, Dec 30, 3:26 AM
kib committed rG7685aaea8850: vm_object_coalesce(): return swap reservation back if overcharged (authored by kib).
vm_object_coalesce(): return swap reservation back if overcharged
Tue, Dec 30, 3:26 AM
kib committed rGe7053d9a126a: vm_object_coalesce(): simplify common expression (authored by kib).
vm_object_coalesce(): simplify common expression
Tue, Dec 30, 3:26 AM
kib committed rGefcb109940ca: vm_object_coalesce(): remove commented out code (authored by kib).
vm_object_coalesce(): remove commented out code
Tue, Dec 30, 3:26 AM
kib closed D54338: vm_object_coalesce(): return swap reservation back if overcharged.
Tue, Dec 30, 3:26 AM
kib closed D54263: vm_object_coalesce(): do not account holes twice.
Tue, Dec 30, 3:26 AM

Mon, Dec 29

kib updated the diff for D54338: vm_object_coalesce(): return swap reservation back if overcharged.

Re-upload the latest version

Mon, Dec 29, 6:50 PM
kib updated the diff for D54263: vm_object_coalesce(): do not account holes twice.

Re-upload the latest version

Mon, Dec 29, 6:49 PM
kib committed rG3204c097fd08: tdestroy(3): add tests (authored by kib).
tdestroy(3): add tests
Mon, Dec 29, 5:19 PM
kib committed rGb0d4b059cf84: tdestroy(3) man page (authored by kib).
tdestroy(3) man page
Mon, Dec 29, 5:19 PM
kib committed rG04a664d87607: libc/stdlib/Makefile: one line for each source file name (authored by kib).
libc/stdlib/Makefile: one line for each source file name
Mon, Dec 29, 5:19 PM
kib committed rGb8c99e7d912f: libc: add glibc-compatible tdestroy(3) (authored by kib).
libc: add glibc-compatible tdestroy(3)
Mon, Dec 29, 5:19 PM
kib closed D54365: libc: add glibc-compatible tdestroy(3).
Mon, Dec 29, 5:19 PM
kib updated the diff for D54365: libc: add glibc-compatible tdestroy(3).

Go back to the simpler solution.

Mon, Dec 29, 4:43 PM
kib added a comment to D54338: vm_object_coalesce(): return swap reservation back if overcharged.
In D54338#1243197, @markj wrote:
In D54338#1243187, @kib wrote:

Ping? This is a follow-up fix after D54263, and I want to commit them together.

Sorry, I am catching up on reviews today.

Does the patch need to be rebased? I can't apply it to main, the last two hunks in vm_object.c don't apply.

Mon, Dec 29, 4:23 PM
kib added a comment to D54365: libc: add glibc-compatible tdestroy(3).

Ping?
This function is needed to cleanly port the modern rdma-core userspace infiniband libraries pack. If there is consensus that the code is correct as is, but possibly not optimal, I want to get the function in. Then Doug could optimize it further (also giving the proper credit in the commit author).

Mon, Dec 29, 4:10 PM
kib added a comment to D54338: vm_object_coalesce(): return swap reservation back if overcharged.

Ping? This is a follow-up fix after D54263, and I want to commit them together.

Mon, Dec 29, 4:08 PM
kib committed rG3088263177da: man pages: provide some description for extended errors (authored by kib).
man pages: provide some description for extended errors
Mon, Dec 29, 1:17 AM
kib committed rG3ef25acf3600: Add a script to auto-generate mapping from exterr category to source file (authored by kib).
Add a script to auto-generate mapping from exterr category to source file
Mon, Dec 29, 1:17 AM
kib committed rG5685c07b5a8e: Add automatically generated file libc/gen/exterr_cat_filenames.h (authored by kib).
Add automatically generated file libc/gen/exterr_cat_filenames.h
Mon, Dec 29, 1:17 AM
kib committed rG874cdf6af695: exterr: in verbose mode, print the source file name (authored by kib).
exterr: in verbose mode, print the source file name
Mon, Dec 29, 1:17 AM
kib committed rG54b52f655e0f: fs/fuse: use dedicated category per source file (authored by kib).
fs/fuse: use dedicated category per source file
Mon, Dec 29, 1:17 AM
kib committed rG543c86636f73: exterr_test: loosen the error string pattern (authored by kib).
exterr_test: loosen the error string pattern
Mon, Dec 29, 1:17 AM
kib committed rG14bd57d0a78d: exterror.9: describe formatting of optional arguments (authored by kib).
exterror.9: describe formatting of optional arguments
Mon, Dec 29, 1:17 AM
kib committed rG42210fe8dcd4: exterror: Add EXTERROR_VERBOSE env variable to control verbosity (authored by kib).
exterror: Add EXTERROR_VERBOSE env variable to control verbosity
Mon, Dec 29, 1:17 AM
kib committed rG2904edaf2f09: vm/vm_mmap.c: inline erronous argument values for extended errors (authored by kib).
vm/vm_mmap.c: inline erronous argument values for extended errors
Mon, Dec 29, 1:17 AM
kib committed rG8bff95f3ce03: exterror: add support for the format specifiers in the extended error msg (authored by kib).
exterror: add support for the format specifiers in the extended error msg
Mon, Dec 29, 1:17 AM
kib committed rG37ddbbe5535c: libc/gen/err.c: remove 'extended error' herald from extended error output (authored by kib).
libc/gen/err.c: remove 'extended error' herald from extended error output
Mon, Dec 29, 1:17 AM
kib closed D54380: exterror: support %d in error messages.
Mon, Dec 29, 1:16 AM
kib committed rGb86fc3284bf8: sys/netipsec: ensure sah stability during input callback processing (authored by kib).
sys/netipsec: ensure sah stability during input callback processing
Mon, Dec 29, 1:02 AM

Sun, Dec 28

kib updated the diff for D54380: exterror: support %d in error messages.

Add the sys/ prefix.
Fix grammar in err.3.

Sun, Dec 28, 9:58 PM
kib added inline comments to D54380: exterror: support %d in error messages.
Sun, Dec 28, 8:45 PM
kib updated the diff for D54380: exterror: support %d in error messages.

Remove extra slash in comment.
Add some documentation to err.3 and environment.7.

Sun, Dec 28, 8:45 PM
kib updated the diff for D54380: exterror: support %d in error messages.

Avoid literal @generated in the script.

Sun, Dec 28, 6:34 PM
kib updated the diff for D54380: exterror: support %d in error messages.

Tag the generated file with "@generated"

Sun, Dec 28, 4:19 PM
kib updated the diff for D54380: exterror: support %d in error messages.

Print the source file name for verbose exterror output.

Sun, Dec 28, 2:27 PM
kib added inline comments to D54365: libc: add glibc-compatible tdestroy(3).
Sun, Dec 28, 1:18 AM
kib added inline comments to D54380: exterror: support %d in error messages.
Sun, Dec 28, 12:54 AM
kib updated the diff for D54380: exterror: support %d in error messages.

EXTERROR_VERBOSE

Sun, Dec 28, 12:40 AM

Sat, Dec 27

kib updated the diff for D54365: libc: add glibc-compatible tdestroy(3).

Remove duplicate assignment, update comment.

Sat, Dec 27, 10:38 PM
kib updated the diff for D54365: libc: add glibc-compatible tdestroy(3).

Generate diff from the right branch.

Sat, Dec 27, 10:14 PM
kib updated the diff for D54365: libc: add glibc-compatible tdestroy(3).

Doug' version, with a fix to re-check for xtn != NULL.

Sat, Dec 27, 9:58 PM
kib updated the diff for D54380: exterror: support %d in error messages.

Update man page.

Sat, Dec 27, 4:23 PM
kib requested review of D54380: exterror: support %d in error messages.
Sat, Dec 27, 3:49 PM
kib updated the diff for D54365: libc: add glibc-compatible tdestroy(3).

Fix test

Sat, Dec 27, 1:25 PM
kib added inline comments to D54365: libc: add glibc-compatible tdestroy(3).
Sat, Dec 27, 1:24 PM

Fri, Dec 26

kib updated the diff for D54365: libc: add glibc-compatible tdestroy(3).

Tweak the license block.

Fri, Dec 26, 11:19 PM
kib updated the diff for D54365: libc: add glibc-compatible tdestroy(3).

Add test

Fri, Dec 26, 10:01 PM
kib updated the diff for D54365: libc: add glibc-compatible tdestroy(3).

Switch back to start left downwalk with tn_leftmost.
Add SPDF/copyright comment.

Fri, Dec 26, 9:54 PM
kib added a comment to D54365: libc: add glibc-compatible tdestroy(3).
In D54365#1242661, @ziaee wrote:

Relnotes: yes?

Fri, Dec 26, 9:53 PM
kib added inline comments to D54365: libc: add glibc-compatible tdestroy(3).
Fri, Dec 26, 8:52 PM
kib added inline comments to D54365: libc: add glibc-compatible tdestroy(3).
Fri, Dec 26, 6:29 PM
kib updated the diff for D54365: libc: add glibc-compatible tdestroy(3).

Handle code suggestions by alc.
Add man page.

Fri, Dec 26, 6:29 PM
kib updated the diff for D54365: libc: add glibc-compatible tdestroy(3).

s/tn_last/tn_leftmost/

Fri, Dec 26, 2:41 PM
kib added a comment to D54365: libc: add glibc-compatible tdestroy(3).
In D54365#1242424, @alc wrote:

Curiously, the blogger's previous post contains a link to this page

https://codegolf.stackexchange.com/questions/478/free-a-binary-tree/489#489P

which contains almost the same code as the 3rd ranked solution.

Fri, Dec 26, 2:41 PM
kib added inline comments to D54365: libc: add glibc-compatible tdestroy(3).
Fri, Dec 26, 2:38 PM
kib added a comment to D54365: libc: add glibc-compatible tdestroy(3).

Ed, could you please advise, is it feasible to take this implementation into our libc for licensing considerations? E.g., could I put the 2bsd license on it, since I read the algorithm on the web page and then wrote the code for our posix_tnode binary tree.

Fri, Dec 26, 4:26 AM
kib requested review of D54365: libc: add glibc-compatible tdestroy(3).
Fri, Dec 26, 4:23 AM

Thu, Dec 25

kib accepted D54353: vnode_pager: clean up undirty_pages().
Thu, Dec 25, 6:25 PM
kib added inline comments to D54353: vnode_pager: clean up undirty_pages().
Thu, Dec 25, 10:40 AM

Wed, Dec 24

kib accepted D54279: nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup.
Wed, Dec 24, 3:21 AM
kib added a comment to D54279: nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup.

Thank you.

Wed, Dec 24, 2:24 AM
kib committed rGe6bdbc17bec4: vm_fault_trap(): fix comments grammar (authored by kib).
vm_fault_trap(): fix comments grammar
Wed, Dec 24, 12:47 AM
kib committed rGb29fb0b5259c: devfs: make destroy_dev() a release barrier for cdevpriv destructors runs (authored by kib).
devfs: make destroy_dev() a release barrier for cdevpriv destructors runs
Wed, Dec 24, 12:47 AM
kib committed rG478098563e21: vm_fault_trap(): fix comments grammar (authored by kib).
vm_fault_trap(): fix comments grammar
Wed, Dec 24, 12:42 AM
kib committed rGd7bc2ee3dedd: vm_object_coalesce(): check that coalescing does not revive stale pages (authored by kib).
vm_object_coalesce(): check that coalescing does not revive stale pages
Wed, Dec 24, 12:42 AM
kib committed rG7dc87eef4695: swap_pager_seek_data(): move the clipping at the object size to consumers (authored by kib).
swap_pager_seek_data(): move the clipping at the object size to consumers
Wed, Dec 24, 12:42 AM
kib committed rG6397c1478ac2: swap_pager_seek_data(): improve assertions (authored by kib).
swap_pager_seek_data(): improve assertions
Wed, Dec 24, 12:42 AM

Tue, Dec 23

kib added a comment to D54279: nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup.

Still, the mail that was sent and contained the exact instructions was useful. This patch just repeats the description from rc.conf.5. Without the exact recipes as was done in the mail, it is probably not useful.

Tue, Dec 23, 11:10 PM
kib abandoned D53891: Fixes for dreaded assert in jemalloc page allocator AKA mmap(MAP_ANON) providing non-zeroed pages.
Tue, Dec 23, 4:47 AM

Mon, Dec 22

kib accepted D49330: vnode_pager: use ptoa(), atop().
Mon, Dec 22, 11:12 PM
kib added a comment to D54338: vm_object_coalesce(): return swap reservation back if overcharged.

NB: this is still being tested by Peter, I decided to go ahead and publish the review as an early exposure

Mon, Dec 22, 12:52 PM
kib requested review of D54338: vm_object_coalesce(): return swap reservation back if overcharged.
Mon, Dec 22, 12:51 PM
kib committed rG183513d15f22: sys/netipsec: ensure sah stability during input callback processing (authored by kib).
sys/netipsec: ensure sah stability during input callback processing
Mon, Dec 22, 12:34 PM
kib closed D54325: sys/netipsec: ensure sah stability during input callback processing.
Mon, Dec 22, 12:34 PM

Sun, Dec 21

kib added inline comments to D49330: vnode_pager: use ptoa(), atop().
Sun, Dec 21, 11:40 PM
kib accepted D54327: geom(9): struct bio KBI fix.

I suppose this is for stable/15, right?

Sun, Dec 21, 10:26 PM
kib closed D52567: vm/vm_fault.c: update and split comments for vm_fault() and vm_fault_trap().
Sun, Dec 21, 10:25 PM
kib committed rG95788a851deb: vm_fault_trap(): fix comments grammar (authored by kib).
vm_fault_trap(): fix comments grammar
Sun, Dec 21, 10:06 PM
kib closed D54335: vm_fault_trap(): fix comments grammar.
Sun, Dec 21, 10:06 PM
kib added inline comments to D54327: geom(9): struct bio KBI fix.
Sun, Dec 21, 10:04 PM
kib added a comment to D52567: vm/vm_fault.c: update and split comments for vm_fault() and vm_fault_trap().

D54335

Sun, Dec 21, 9:24 PM
kib requested review of D54335: vm_fault_trap(): fix comments grammar.
Sun, Dec 21, 9:24 PM
kib accepted D49330: vnode_pager: use ptoa(), atop().
Sun, Dec 21, 8:47 PM
kib abandoned D53965: vm_object_coalesce(): do not account holes twice.
Sun, Dec 21, 6:11 PM
kib added a comment to D53965: vm_object_coalesce(): do not account holes twice.
In D53965#1241683, @alc wrote:

This change is now similar to D43263. Abandon this one?

Sun, Dec 21, 6:10 PM
kib added inline comments to D54327: geom(9): struct bio KBI fix.
Sun, Dec 21, 12:47 PM
kib committed rG84a265d9ace3: vmem.9: provide a reference to libuvmem(3) (authored by kib).
vmem.9: provide a reference to libuvmem(3)
Sun, Dec 21, 3:57 AM

Sat, Dec 20

kib added inline comments to D54323: krb5: Expose missing symbols.
Sat, Dec 20, 6:14 PM
kib added a comment to D54325: sys/netipsec: ensure sah stability during input callback processing.

I have to keep sah tree rlocked much deeper, right until the if_input is called finally. Also, the same problem exists for all ESP/AH/IPCOMP processing callbacks.

Sat, Dec 20, 12:07 PM
kib requested review of D54325: sys/netipsec: ensure sah stability during input callback processing.
Sat, Dec 20, 12:06 PM
kib added a comment to D54323: krb5: Expose missing symbols.

Also the ports:misc/compat15x needs to be updated.

Sat, Dec 20, 11:44 AM
kib added a comment to D54296: PR 291774: expand range of errors reported by libusb_open(3).

I have no idea about USB code

Sat, Dec 20, 11:33 AM · USB
kib added a comment to D54323: krb5: Expose missing symbols.

Can you pleas explain

  1. how the list of missed symbols was obtained
  2. why do we need the internallib for krb5profile now
Sat, Dec 20, 10:31 AM

Thu, Dec 18

kib updated the diff for D54263: vm_object_coalesce(): do not account holes twice.

Use next_end

Thu, Dec 18, 10:17 PM
kib committed rG5c1d9df10b78: vmem.9: provide a reference to libuvmem(3) (authored by kib).
vmem.9: provide a reference to libuvmem(3)
Thu, Dec 18, 8:15 PM
kib updated subscribers of D54263: vm_object_coalesce(): do not account holes twice.
Thu, Dec 18, 7:41 PM
kib added inline comments to D54279: nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup.
Thu, Dec 18, 3:27 AM

Wed, Dec 17

kib added a comment to D54229: unionfs: Support renaming symbolic links.
In D54229#1240206, @des wrote:

Can I please get a decision on this?

Wed, Dec 17, 6:35 PM
kib added reviewers for D54270: libc/stdlib: port illumos#15365: strtonumx() would be a useful companion to strtonum(): des, emaste.
Wed, Dec 17, 4:30 PM