Page MenuHomeFreeBSD

kib (Konstantin Belousov)
User

Projects

User Details

User Since
May 16 2014, 7:35 PM (613 w, 6 d)

Recent Activity

Yesterday

kib committed rGe334b70a2b5b: x86: provide extended description for x86_msr_op(9) (authored by kib).
x86: provide extended description for x86_msr_op(9)
Thu, Feb 19, 10:09 PM
kib committed rGb0bc769c363e: x86_msr_op(9): consistently return the value read from MSR (authored by kib).
x86_msr_op(9): consistently return the value read from MSR
Thu, Feb 19, 10:09 PM
kib committed rG0558fa8f5596: x86: add a safe variant of MSR_OP_SCHED* operations for x86_msr_op(9) (authored by kib).
x86: add a safe variant of MSR_OP_SCHED* operations for x86_msr_op(9)
Thu, Feb 19, 10:09 PM
kib added a comment to D55378: pipe: Avoid unnecessary priv_check() calls in pipespace_new().
In D55378#1266686, @kib wrote:

You could divide by 128 if this is so important.

Could you please explain the motivation for the changes?

I was looking at sources of frequent priv_check() calls from unprivileged processes, trying to see if any are avoidable. These calls might do some non-trivial work if MAC hooks are installed.

Thu, Feb 19, 5:53 PM
kib accepted D55377: sysctl: Avoid calling priv_check() unnecessarily.
Thu, Feb 19, 5:37 PM
kib accepted D55378: pipe: Avoid unnecessary priv_check() calls in pipespace_new().

You could divide by 128 if this is so important.

Thu, Feb 19, 5:37 PM
kib added a comment to D55365: ed: add unicode support for the l (list) command.

https://reviews.freebsd.org/D55364 now has your tests and they pass

Thu, Feb 19, 5:35 PM
kib added a comment to D55365: ed: add unicode support for the l (list) command.
In D55365#1266404, @kib wrote:

I may be missing some idea on what to test

Might be add some tests for e.g. ru_RU.UTF-8? What do you need for this?

In D55365#1266404, @kib wrote:

I may be missing some idea on what to test

Might be add some tests for e.g. ru_RU.UTF-8? What do you need for this?

juste provide me a set of command you would expect to work in ru_RU.UTF-8 and and expected output and I will add it to the test suite.

Thu, Feb 19, 12:27 PM
kib added a comment to D55365: ed: add unicode support for the l (list) command.

I may be missing some idea on what to test

Thu, Feb 19, 11:14 AM
kib added a comment to D55365: ed: add unicode support for the l (list) command.

Do regexps addresses and commands like 's' correctly operate on mb strings?

Thu, Feb 19, 10:28 AM

Wed, Feb 18

kib accepted D55348: kqueue: Make kn_sfflags unsigned.
Wed, Feb 18, 3:43 PM
kib accepted D55348: kqueue: Make kn_sfflags unsigned.
Wed, Feb 18, 3:13 PM
kib accepted D55281: mitigations.7: Describe LASS.
Wed, Feb 18, 3:12 PM
kib added inline comments to D55281: mitigations.7: Describe LASS.
Wed, Feb 18, 3:01 PM
kib accepted D55307: stddef.h: centralize definition of offsetof().
Wed, Feb 18, 2:58 PM
kib updated the diff for D55341: procctl(PROC_REAP_KILL): align error reporting with pgkill(2).

Add comment.

Wed, Feb 18, 2:20 PM
kib updated the diff for D55341: procctl(PROC_REAP_KILL): align error reporting with pgkill(2).

Return on any error, not excluding ESRCH.

Wed, Feb 18, 1:00 PM
kib added inline comments to D44454: intelhfi - Intel TD/HFI driver - Part2: Enable thermal interrupt handler for Local APIC's..
Wed, Feb 18, 11:09 AM · Contributor Reviews (src)
kib added inline comments to D55288: procctl(PROC_REAP_KILL): use pgrp pg_killsx sx to sync with fork.
Wed, Feb 18, 8:27 AM
kib requested review of D55341: procctl(PROC_REAP_KILL): align error reporting with pgkill(2).
Wed, Feb 18, 8:26 AM
kib committed rG48aeff4df8e7: open.2: grammar improvements (authored by kib).
open.2: grammar improvements
Wed, Feb 18, 8:05 AM
kib committed rG4338c437910b: open.2: stop making impression that fd must be directory (authored by kib).
open.2: stop making impression that fd must be directory
Wed, Feb 18, 8:05 AM
kib committed rG532c8d3f90b9: amd64: add LASS support (authored by kib).
amd64: add LASS support
Wed, Feb 18, 8:05 AM
kib committed rG1443a455a96e: libc: improve include usage for exterror sources (authored by kib).
libc: improve include usage for exterror sources
Wed, Feb 18, 7:56 AM
kib committed rGa03f285afafa: libc: add man page for uexterr_gettext(3) (authored by kib).
libc: add man page for uexterr_gettext(3)
Wed, Feb 18, 7:56 AM
kib closed D55337: libc: improve include usage for exterror sources.
Wed, Feb 18, 7:56 AM
kib closed D55336: libc: add man page for uexterr_gettext(3).
Wed, Feb 18, 7:56 AM
kib updated the diff for D55336: libc: add man page for uexterr_gettext(3).

Fix grammar.

Wed, Feb 18, 7:54 AM

Tue, Feb 17

kib abandoned D55319: sys/cdefs.h: tweak compat definition of __builtin_align_down().
Tue, Feb 17, 9:15 PM
kib accepted D55161: __builtin_align_down: Cast value to __uintptr_t in the fallback.
Tue, Feb 17, 9:10 PM
kib requested review of D55337: libc: improve include usage for exterror sources.
Tue, Feb 17, 9:01 PM
kib requested review of D55336: libc: add man page for uexterr_gettext(3).
Tue, Feb 17, 8:47 PM
kib committed rGffbf95907039: libc: print extended errors from warn(3) and vwarn(3) (authored by kib).
libc: print extended errors from warn(3) and vwarn(3)
Tue, Feb 17, 8:05 PM
kib closed D55327: libc: print extended errors from warn(3) and vwarn(3).
Tue, Feb 17, 8:04 PM
kib accepted D55326: iommu_gas: fix assertion.
Tue, Feb 17, 5:41 PM
kib updated the diff for D55288: procctl(PROC_REAP_KILL): use pgrp pg_killsx sx to sync with fork.

Grammar.
Drop ESRCH comment.

Tue, Feb 17, 3:58 PM
kib added inline comments to D55288: procctl(PROC_REAP_KILL): use pgrp pg_killsx sx to sync with fork.
Tue, Feb 17, 3:58 PM
kib updated the diff for D55288: procctl(PROC_REAP_KILL): use pgrp pg_killsx sx to sync with fork.

Add comments about P_WEXIT2 and ESRCH.

Tue, Feb 17, 3:08 PM
kib updated the diff for D55288: procctl(PROC_REAP_KILL): use pgrp pg_killsx sx to sync with fork.

s/error1/error/
Drop _work() suffix.

Tue, Feb 17, 2:52 PM
kib added inline comments to D55288: procctl(PROC_REAP_KILL): use pgrp pg_killsx sx to sync with fork.
Tue, Feb 17, 2:51 PM
kib accepted D55318: vfs_mount.c: Don't call VFS_MOUNT() if only exports are being updated.
Tue, Feb 17, 2:34 PM
kib accepted D55308: build: add stddef.h to define ptraddr_t as required.
Tue, Feb 17, 11:24 AM
kib requested review of D55327: libc: print extended errors from warn(3) and vwarn(3).
Tue, Feb 17, 11:13 AM
kib updated the diff for D55288: procctl(PROC_REAP_KILL): use pgrp pg_killsx sx to sync with fork.

Restore useful comment.

Tue, Feb 17, 5:25 AM
kib added a comment to D55323: <sys/extattr.h>: use designated initializers for EXTATTR_NAMESPACE_NAMES.

gcc might need -pedantic or something like this.

Tue, Feb 17, 5:24 AM
kib accepted D55323: <sys/extattr.h>: use designated initializers for EXTATTR_NAMESPACE_NAMES.

AFAIR this is not a valid C++, if anybody cares.

Tue, Feb 17, 5:13 AM
kib accepted D55286: find: add -xattr and -xttrname.
Tue, Feb 17, 5:09 AM
kib added inline comments to D55318: vfs_mount.c: Don't call VFS_MOUNT() if only exports are being updated.
Tue, Feb 17, 3:40 AM
kib accepted D55316: witness: report a thread that can't sleep in WITNESS_WARN.
Tue, Feb 17, 2:53 AM
kib added a comment to D55319: sys/cdefs.h: tweak compat definition of __builtin_align_down().

The theory is that it should fix https://ci.freebsd.org/job/FreeBSD-main-amd64-gcc14_build/2893/console

Tue, Feb 17, 2:44 AM
kib requested review of D55319: sys/cdefs.h: tweak compat definition of __builtin_align_down().
Tue, Feb 17, 2:43 AM

Mon, Feb 16

kib committed rG793e891f4ad1: pdrfork(2) tests: enable on x86 (authored by kib).
pdrfork(2) tests: enable on x86
Mon, Feb 16, 5:59 PM
kib committed rGf90ee665d035: pdrfork(2) tests: should wait for the child to exit (authored by kib).
pdrfork(2) tests: should wait for the child to exit
Mon, Feb 16, 5:59 PM
kib committed rG94e4de77dec8: pdrfork(2) tests: split basic_usage (authored by kib).
pdrfork(2) tests: split basic_usage
Mon, Feb 16, 5:59 PM
kib committed rG44843695bc4e: pdrfork(2) tests: catch runaway child for EFAULT test (authored by kib).
pdrfork(2) tests: catch runaway child for EFAULT test
Mon, Feb 16, 5:59 PM
kib committed rGd6bf2d14a941: pdrfork(2) tests: do not rely on (int *)-1 being invalid address (authored by kib).
pdrfork(2) tests: do not rely on (int *)-1 being invalid address
Mon, Feb 16, 5:59 PM
kib committed rG68ba270f4fc7: pdrfork(2) tests: RFPROCDESC|RFPROC are required (authored by kib).
pdrfork(2) tests: RFPROCDESC|RFPROC are required
Mon, Feb 16, 5:59 PM
kib committed rGdb80ea9b8862: pdfork.2: add EFAULT as possible error, explain some consequences of it (authored by kib).
pdfork.2: add EFAULT as possible error, explain some consequences of it
Mon, Feb 16, 5:58 PM
kib committed rGb05be03ceea0: pdrfork(2): do require RFPROCDESC | RFPROC (authored by kib).
pdrfork(2): do require RFPROCDESC | RFPROC
Mon, Feb 16, 5:58 PM
kib closed D55306: Fixes for pdrfork(2) and tests.
Mon, Feb 16, 5:58 PM
kib updated the diff for D55306: Fixes for pdrfork(2) and tests.

Remove munmap(guard).
Fix comments.
Fix style.

Mon, Feb 16, 5:18 PM
kib committed rGf1f142c01db4: open.2: grammar improvements (authored by kib).
open.2: grammar improvements
Mon, Feb 16, 3:37 PM
kib committed rG5bcccc702b29: open.2: stop making impression that fd must be directory (authored by kib).
open.2: stop making impression that fd must be directory
Mon, Feb 16, 3:26 PM
kib closed D55302: open.2: stop making impression that fd must be directory.
Mon, Feb 16, 3:26 PM
kib updated the diff for D55288: procctl(PROC_REAP_KILL): use pgrp pg_killsx sx to sync with fork.

pg_killsx is before proctree_lock, handle this.
Add a fix for a pre-existing problem of unsafe iteration over p_reapsiblings list.

Mon, Feb 16, 3:24 PM
kib accepted D55307: stddef.h: centralize definition of offsetof().

The change by itself is fine.

Mon, Feb 16, 2:32 PM
kib accepted D55305: stddef.h: add ptraddr_t.
Mon, Feb 16, 2:27 PM
kib accepted D55309: sys/syscallsubr.h: assorted tidying.
Mon, Feb 16, 2:25 PM
kib requested review of D55306: Fixes for pdrfork(2) and tests.
Mon, Feb 16, 1:48 PM
kib added a reviewer for D55288: procctl(PROC_REAP_KILL): use pgrp pg_killsx sx to sync with fork: markj.
Mon, Feb 16, 1:44 PM
kib requested review of D55302: open.2: stop making impression that fd must be directory.
Mon, Feb 16, 7:30 AM
kib committed rG00095a089604: kern/vfs_unmount.c: promote flags to uint64_t (authored by kib).
kern/vfs_unmount.c: promote flags to uint64_t
Mon, Feb 16, 6:23 AM
kib committed rGa893e8463ab2: unmount(2): do not allow MNT_DEFERRED or MNT_RECURSE flags from userspace (authored by kib).
unmount(2): do not allow MNT_DEFERRED or MNT_RECURSE flags from userspace
Mon, Feb 16, 6:23 AM
kib committed rGcf941029dd02: kqtimer_proc_continue(): correct calculation of 'now' (authored by kib).
kqtimer_proc_continue(): correct calculation of 'now'
Mon, Feb 16, 6:23 AM
kib committed rG119af90d483a: filt_timerexpire_l(): re-insert restarted timer into head instead of tail (authored by kib).
filt_timerexpire_l(): re-insert restarted timer into head instead of tail
Mon, Feb 16, 6:23 AM
kib committed rG203819ee8407: x86: Note that trapframe is used by kernel debuggers (authored by minsoochoo0122_proton.me).
x86: Note that trapframe is used by kernel debuggers
Mon, Feb 16, 6:19 AM
kib committed rG71cc31c18d1e: kqtimer_proc_continue(): correct calculation of 'now' (authored by kib).
kqtimer_proc_continue(): correct calculation of 'now'
Mon, Feb 16, 6:19 AM
kib committed rG22bf122dceb7: filt_timerexpire_l(): re-insert restarted timer into head instead of tail (authored by kib).
filt_timerexpire_l(): re-insert restarted timer into head instead of tail
Mon, Feb 16, 6:19 AM
kib committed rGdaa5f78c691b: kern/vfs_unmount.c: promote flags to uint64_t (authored by kib).
kern/vfs_unmount.c: promote flags to uint64_t
Mon, Feb 16, 6:19 AM
kib committed rGa6c0d8bf434a: amd64/acpica/acpi_wakeup.c: do not store to WARMBOOT_OFF in efi_boot case (authored by kib).
amd64/acpica/acpi_wakeup.c: do not store to WARMBOOT_OFF in efi_boot case
Mon, Feb 16, 6:19 AM

Sun, Feb 15

kib updated the diff for D55288: procctl(PROC_REAP_KILL): use pgrp pg_killsx sx to sync with fork.

Simplify more: no need to single-thread itself, pg_killsx should be enough there as well.

Sun, Feb 15, 2:13 PM
kib updated subscribers of D55288: procctl(PROC_REAP_KILL): use pgrp pg_killsx sx to sync with fork.
Sun, Feb 15, 12:29 PM
kib requested review of D55288: procctl(PROC_REAP_KILL): use pgrp pg_killsx sx to sync with fork.
Sun, Feb 15, 11:16 AM
kib added a comment to D55286: find: add -xattr and -xttrname.

Do we want to accept e.g. 'random_garbage:aaa' as the xattr name? I.e., if user put non-existing namespace before ':' should we silently do not find anything?

Sun, Feb 15, 4:16 AM
kib committed rG7786840a0bb0: lib/libc/net/sockatmark.3: fix groff mdoc warning (authored by kib).
lib/libc/net/sockatmark.3: fix groff mdoc warning
Sun, Feb 15, 3:15 AM
kib committed rGc838c3f2062b: sbin/setkey/setkey.8: cleanup groff mdoc warnings (authored by kib).
sbin/setkey/setkey.8: cleanup groff mdoc warnings
Sun, Feb 15, 3:15 AM

Sat, Feb 14

kib accepted D55281: mitigations.7: Describe LASS.
Sat, Feb 14, 2:11 PM
kib accepted D55283: sys/abi_types.h: time32_t is 64-bit on non-x86 architectures.

Ok, lets see how it goes. If it starts break again, I will put if SIZEOF_LONG==8 around the code in sys/event.h and kern/kern_umtx.c etc.

Sat, Feb 14, 11:45 AM
kib accepted D55282: sys/compat/freebsd32: FF clock struct: Don't pack, use 'ffcounter32'.
Sat, Feb 14, 5:00 AM
kib added a comment to D55283: sys/abi_types.h: time32_t is 64-bit on non-x86 architectures.

What should it fix? Why it matter?

Sat, Feb 14, 4:57 AM
kib added inline comments to D55281: mitigations.7: Describe LASS.
Sat, Feb 14, 4:56 AM

Fri, Feb 13

kib committed rG4cf6925e9a18: ktrace: do not enqueue request if the process' ktrioparams are freed (authored by kib).
ktrace: do not enqueue request if the process' ktrioparams are freed
Fri, Feb 13, 6:20 PM
kib added inline comments to D55264: filt_timerexpire_l(): re-insert restarted timer into head instead of tail.
Fri, Feb 13, 3:48 PM
kib closed D55264: filt_timerexpire_l(): re-insert restarted timer into head instead of tail.
Fri, Feb 13, 3:47 PM
kib committed rGe7f86f8b1383: kqtimer_proc_continue(): correct calculation of 'now' (authored by kib).
kqtimer_proc_continue(): correct calculation of 'now'
Fri, Feb 13, 3:47 PM
kib committed rG75a30ea09f4e: filt_timerexpire_l(): re-insert restarted timer into head instead of tail (authored by kib).
filt_timerexpire_l(): re-insert restarted timer into head instead of tail
Fri, Feb 13, 3:47 PM
kib updated the diff for D55264: filt_timerexpire_l(): re-insert restarted timer into head instead of tail.

Correct the 'now' calculation for kqtimer_proc_continue()

Fri, Feb 13, 3:35 PM
kib added inline comments to D55264: filt_timerexpire_l(): re-insert restarted timer into head instead of tail.
Fri, Feb 13, 3:27 PM
kib committed rGcb81a9c18db9: x86: provide extended description for x86_msr_op(9) (authored by kib).
x86: provide extended description for x86_msr_op(9)
Fri, Feb 13, 8:19 AM
kib committed rG36ceb5509d01: x86_msr_op(9): consistently return the value read from MSR (authored by kib).
x86_msr_op(9): consistently return the value read from MSR
Fri, Feb 13, 8:18 AM