It is really eventfd data, so might be slightly better to call it eventfd_data. I do not object to proposal to rename the FreeBSD own structure,

Switch to macros.

This cannot work, alloca result is only valid for the duration of the current frame.
The functions can be moved to string.h as __always_inline, but I suspect that this would cause compat issues with weird compilers.

strndupa is from glibc as well

Thanks.

In D54033#1234654, @markj wrote:

In D54033#1234624, @kib wrote:

Indeed, the explicitly stated motivation, at least in the commit message, would be quite useful.

BTW, should LD_BIND_NOW be marked as unsecure, it potentially changes the bindings of the image?

I'm not sure, what happens if we perform lazy binding and the application dlopens a DSO which provides a duplicate symbol? How else can LD_BIND_NOW change the bindings of the image?

Indeed, the explicitly stated motivation, at least in the commit message, would be quite useful.

The 'no additional handling required' part of knote_triv_copy is somewhat useful info, since if f_copy is not NULL, the 'shallow copy' part is done by the kqueue code itself always. So knote_triv_copy does not do any work, it is simply a placeholder to provide non-NULL value.

Some tweaks to the man page

Any progress with testing?

Switch to m_needs_zeroing

In D53965#1233222, @markj wrote:

vm_map_entry_delete() only subtracts from the object's charge when we shrink the size of the object.

Isn't that the bug? That is, shouldn't vm_map_entry_delete() subtract the size of the hole from the charge if the object has only one mapping?

Completely rework the patch: instead of clearing PG_ZERO, track the page source in the fault state.

May be define some inline function in libc/include/libc_private.h, like

static inline ptrdiff_t
misalign_val(void *p)
{
   return (_ALIGN(p) - p);
}

and use it in all places.

Slightly more clarity for normal libs.

INTERNALLIB: s/pic/pie/; only state that the result is suitable for linking into binaries. This sounds like a bug to me: we should build pic version instead of pie.
PRIVATELIB: headers go into include/private/<name>

In D53831#1229841, @markj wrote:

This looks like it's really testing the host's (cross-)build environment. That seems useful, but it's not the same as testing the installation itself, e.g., a test could invoke cc to compile this file or something similar and verify that it succeeded. Should we do both? Is there some reason this test on its own is sufficient?

The difference now is in order in which dependencies are reported for unload.

Move vm_check_pg_zero code from vm_map_insert() into vm_object_coalesce().