Page MenuHomeFreeBSD

kib (Konstantin Belousov)
User

Projects

User Details

User Since
May 16 2014, 7:35 PM (581 w, 1 d)

Recent Activity

Today

kib accepted D51175: pathconf.2: Document the _PC_HAS_HIDDENSYSTEM name.
Sun, Jul 6, 3:11 PM
kib added a comment to D51175: pathconf.2: Document the _PC_HAS_HIDDENSYSTEM name.

Put .Dv before UF_HIDDEN and UF_SYSTEM as suggested
by ziaee@ and replaced va_flags with flags as suggested
by kib@. (I did not put .Ar in front of flags, since it is not
an argument to pathconf. Should I?)

Sun, Jul 6, 3:11 PM
kib accepted D51173: amd64: fix physmap entry addition logic.
Sun, Jul 6, 1:23 PM
kib added a comment to D51174: uexterr_gettext: add tests.

Loading module which is not configured against the same kernel config as current kernel is dangerous. It does not guarantee that the KBI of module and kernel match, and then all bets are off.

Sun, Jul 6, 11:44 AM
kib added inline comments to D51175: pathconf.2: Document the _PC_HAS_HIDDENSYSTEM name.
Sun, Jul 6, 11:12 AM

Yesterday

kib committed rGc44439942cdb: aio: make aio_init_aioinfo() and aio_aqueue() static (authored by kib).
aio: make aio_init_aioinfo() and aio_aqueue() static
Sat, Jul 5, 9:19 PM
kib committed rG4685fa8e4bef: aio: handle errors from fork (authored by kib).
aio: handle errors from fork
Sat, Jul 5, 9:19 PM
kib accepted D51172: unistd.h: Add a new pathconf variable for UF_HIDDEN/UF_SYSTEM.

The var should be added to libsys/pathconf.2

Sat, Jul 5, 9:03 PM
kib accepted D51091: amd64 pmap: demotion changes for kib@.
Sat, Jul 5, 9:01 PM
kib accepted D51060: pctrie: move the root to the latest search node.
In D51060#1167241, @kib wrote:

The name pt_root and the term root is confusing IMO. At least it is worth adding a comment explaining the pt_root is some node, not necessary root.

I don't mind changing the name from 'root' to ... what? 'start'? 'cursor'? Any suggestions are welcome.

Sat, Jul 5, 4:22 PM
kib accepted D51164: kern: add some extra metadata to the coredump devctl notification.
Sat, Jul 5, 3:53 PM
kib added inline comments to D51141: Use extended errors for err(3) and warn(3).
Sat, Jul 5, 9:44 AM
kib added a comment to D51091: amd64 pmap: demotion changes for kib@.

Do you want me to rebase the changes?

Sat, Jul 5, 9:44 AM
kib committed rG476d2d8f290f: amd64 pmap: do not panic on inability to insert ptp into trie (authored by kib).
amd64 pmap: do not panic on inability to insert ptp into trie
Sat, Jul 5, 8:37 AM
kib committed rGee502c853183: amd64 pmap: update comment in pmap_demote_DMAP() explaining the len<NBPDP check (authored by kib).
amd64 pmap: update comment in pmap_demote_DMAP() explaining the len<NBPDP check
Sat, Jul 5, 8:37 AM
kib committed rG6eb141a2c473: amd64 pmap: preallocate pt page for pmap_demote_pdpe() in pmap_demote_DMAP() (authored by kib).
amd64 pmap: preallocate pt page for pmap_demote_pdpe() in pmap_demote_DMAP()
Sat, Jul 5, 8:37 AM
kib committed rGca554a7dea3f: dev/mem: use sx instead of rw lock (authored by kib).
dev/mem: use sx instead of rw lock
Sat, Jul 5, 8:37 AM
kib closed D50970: amd64 pmap: eliminate two explicit panics on low mem conditions.
Sat, Jul 5, 8:37 AM
kib added inline comments to D51164: kern: add some extra metadata to the coredump devctl notification.
Sat, Jul 5, 8:32 AM
kib added inline comments to D51164: kern: add some extra metadata to the coredump devctl notification.
Sat, Jul 5, 8:31 AM

Fri, Jul 4

kib accepted D51153: kern: adopt the cr_gid macro for cr_groups[0] more widely.

Did you considered writing a coccinelle script to do the transformation? We even have the place for it, tools/coccinelle.

Fri, Jul 4, 9:09 PM
kib updated the diff for D51141: Use extended errors for err(3) and warn(3).

Exclude errc() from extended error printing.

Fri, Jul 4, 8:59 PM
kib added inline comments to D51141: Use extended errors for err(3) and warn(3).
Fri, Jul 4, 8:59 PM
kib accepted D51146: amd64: allow the mapping of other regions for efirt.
Fri, Jul 4, 7:54 PM
kib committed rG3b1c4cb1bfff: sys_generic.c: convert EINVALs to EXTERROR(EINVAL) (authored by kib).
sys_generic.c: convert EINVALs to EXTERROR(EINVAL)
Fri, Jul 4, 7:25 PM
kib accepted D51147: amd64/efirt: always map the first page.
Fri, Jul 4, 6:01 PM
kib added inline comments to D51146: amd64: allow the mapping of other regions for efirt.
Fri, Jul 4, 5:59 PM
kib committed rG2f60984053e5: namei dotdot tracker: take mnt_renamelock shared to prevent parallel renames (authored by kib).
namei dotdot tracker: take mnt_renamelock shared to prevent parallel renames
Fri, Jul 4, 3:24 PM
kib committed rG2ffee9aef7c2: vfs_lookup: split NDRESTART (authored by kib).
vfs_lookup: split NDRESTART
Fri, Jul 4, 3:24 PM
kib committed rG369a2542caa9: msdosfs: remove pm_checkpath_lock (authored by kib).
msdosfs: remove pm_checkpath_lock
Fri, Jul 4, 3:24 PM
kib committed rGef6ea91593eb: VOP_RENAME: add mp-global lock (authored by kib).
VOP_RENAME: add mp-global lock
Fri, Jul 4, 3:24 PM
kib committed rG2c17429915f2: ufs: remove um_checkpath_lock (authored by kib).
ufs: remove um_checkpath_lock
Fri, Jul 4, 3:24 PM
kib closed D50648: mnt_renamelock.
Fri, Jul 4, 3:24 PM
kib added inline comments to D51147: amd64/efirt: always map the first page.
Fri, Jul 4, 7:42 AM
kib added inline comments to D51146: amd64: allow the mapping of other regions for efirt.
Fri, Jul 4, 7:35 AM
kib added inline comments to D51085: amd64 pmap: move DMAP out of kernel pml4 table for LA57..
Fri, Jul 4, 5:17 AM
kib committed rG3a2e1feea91e: amd64 ddb 'show pte': print both pte VA in recursive map and pte content (authored by kib).
amd64 ddb 'show pte': print both pte VA in recursive map and pte content
Fri, Jul 4, 5:00 AM
kib committed rG0f62297dd1f2: amd64: switch to la57 mode before creating kernel page tables (authored by kib).
amd64: switch to la57 mode before creating kernel page tables
Fri, Jul 4, 5:00 AM
kib committed rG0e33dd60f617: amd64: eliminate asm symbols DMAP_MIN/MAX_ADDRESS (authored by kib).
amd64: eliminate asm symbols DMAP_MIN/MAX_ADDRESS
Fri, Jul 4, 5:00 AM
kib committed rGb6fb125330dd: amd64: express KV4ADDR() using KV5ADDR() (authored by kib).
amd64: express KV4ADDR() using KV5ADDR()
Fri, Jul 4, 5:00 AM
kib committed rG9f685f4f2f93: amd64: remove dmapbase, dmapend symbols (authored by kib).
amd64: remove dmapbase, dmapend symbols
Fri, Jul 4, 5:00 AM
kib updated the diff for D51141: Use extended errors for err(3) and warn(3).

Add vexterr() helper.

Fri, Jul 4, 4:53 AM

Thu, Jul 3

kib added inline comments to D51141: Use extended errors for err(3) and warn(3).
Thu, Jul 3, 6:20 PM
kib updated the diff for D51143: sysctl net.inet.tcp.ktlslist: allow snd_tag_status_str() to sleep.

Rework retry.
Relock sx between retries.
Check for pending signals.

Thu, Jul 3, 6:18 PM
kib added inline comments to D51143: sysctl net.inet.tcp.ktlslist: allow snd_tag_status_str() to sleep.
Thu, Jul 3, 6:17 PM
kib updated the diff for D51085: amd64 pmap: move DMAP out of kernel pml4 table for LA57..

Update comments.

Thu, Jul 3, 6:14 PM
kib added inline comments to D51085: amd64 pmap: move DMAP out of kernel pml4 table for LA57..
Thu, Jul 3, 6:14 PM
kib accepted D50315: inotify: Initial revision.

I believe I already agreed with note 1.

Thu, Jul 3, 6:11 PM
kib updated the diff for D51143: sysctl net.inet.tcp.ktlslist: allow snd_tag_status_str() to sleep.

Mention the owned reference in the comment.
Limit the number of restarts for sysctl handler.

Thu, Jul 3, 2:27 PM
kib added inline comments to D51143: sysctl net.inet.tcp.ktlslist: allow snd_tag_status_str() to sleep.
Thu, Jul 3, 2:26 PM
kib updated the diff for D51085: amd64 pmap: move DMAP out of kernel pml4 table for LA57..

Add KVA map.
Use loops instead of memcpy/memset.

Thu, Jul 3, 2:17 PM
kib added inline comments to D51085: amd64 pmap: move DMAP out of kernel pml4 table for LA57..
Thu, Jul 3, 2:17 PM
kib accepted D51145: md: Restore guards in mddestroy().
Thu, Jul 3, 1:19 PM
kib updated the diff for D51143: sysctl net.inet.tcp.ktlslist: allow snd_tag_status_str() to sleep.

Instead of exposing INP_FREED, add in_pcbrele_rlock().

Thu, Jul 3, 11:17 AM
kib requested review of D51143: sysctl net.inet.tcp.ktlslist: allow snd_tag_status_str() to sleep.
Thu, Jul 3, 10:46 AM
kib added a comment to D51060: pctrie: move the root to the latest search node.

The name pt_root and the term root is confusing IMO. At least it is worth adding a comment explaining the pt_root is some node, not necessary root.

Thu, Jul 3, 10:13 AM
kib added a comment to D51055: Document si_code values for sigaction(2).

I suggest to split the diff into two.
One for doing something with the signal list, if you decide to move it (or rather merge with the list in signal(3)).
And second for the .Tn removal etc (BTW why?). There is also .St macro, which might be appropriate in some places.

Thu, Jul 3, 5:56 AM
kib added a comment to D51060: pctrie: move the root to the latest search node.

Beg me pardon please for the naive question.
What this revision basically does is changing the semantic of the pt_root. Instead being a real root of the trie, it becomes the starting point for search. The argument for not needed the real root is that we can always climb up to it from any node, following pn_parent. Am I right?

Thu, Jul 3, 4:11 AM
kib added a comment to D51095: Add sched_getaffinity.3 to document sched_getaffinity and sched_setaffinity .

Why the man page added to libsys? It must go into libc/gen.

Thu, Jul 3, 3:43 AM
kib requested review of D51141: Use extended errors for err(3) and warn(3).
Thu, Jul 3, 3:08 AM

Wed, Jul 2

kib committed rGe91022168101: md(4): move type-specific data under union (authored by kib).
md(4): move type-specific data under union
Wed, Jul 2, 3:33 PM
kib closed D51127: md(4): move type-specific data under union.
Wed, Jul 2, 3:33 PM
kib accepted D51131: files: Fix builds without options UFS_ACL.
Wed, Jul 2, 2:21 PM
kib updated the diff for D51085: amd64 pmap: move DMAP out of kernel pml4 table for LA57..

Use vm_offset_t for kva_layout members

Wed, Jul 2, 2:19 PM
kib added inline comments to D51085: amd64 pmap: move DMAP out of kernel pml4 table for LA57..
Wed, Jul 2, 2:19 PM
kib updated the diff for D51128: md(4): add support for unmapped preloaded images.

Rebase.

Wed, Jul 2, 2:11 PM
kib updated the diff for D51127: md(4): move type-specific data under union.

Correct diff, with all 's.' eliminated.

Wed, Jul 2, 2:10 PM
kib updated the diff for D51128: md(4): add support for unmapped preloaded images.

Track D51127

Wed, Jul 2, 2:07 PM
kib updated the diff for D51127: md(4): move type-specific data under union.

Drop internal union member name.
Handle MD_PRELOAD in mddestroy().

Wed, Jul 2, 2:06 PM
kib added inline comments to D51127: md(4): move type-specific data under union.
Wed, Jul 2, 2:05 PM
kib added a reviewer for D51127: md(4): move type-specific data under union: markj.
Wed, Jul 2, 1:19 PM
kib added a comment to D45404: biosboot: Detect memory disks from PXE.

I proposed the patch to support unmapped preloaded images in D51128, untested.
This patch would require a trivial adaptation, in particular, remove the pmap_map() line, and pass paddr as the second arg to md_preloaded():

md_preloaded(0, paddr, len, scratch, false);
Wed, Jul 2, 1:18 PM
kib requested review of D51128: md(4): add support for unmapped preloaded images.
Wed, Jul 2, 1:15 PM
kib requested review of D51127: md(4): move type-specific data under union.
Wed, Jul 2, 1:14 PM
kib added inline comments to D45404: biosboot: Detect memory disks from PXE.
Wed, Jul 2, 11:37 AM

Tue, Jul 1

kib updated the diff for D50648: mnt_renamelock.

Fix assert.

Tue, Jul 1, 3:30 PM
kib updated the diff for D50970: amd64 pmap: eliminate two explicit panics on low mem conditions.

Properly handle freeing of the allocated pt page.

Tue, Jul 1, 9:50 AM
kib accepted D40466: Hardware Trace (HWT) framework.

I only read the sys/kern bits.

Tue, Jul 1, 9:49 AM
kib added inline comments to D40466: Hardware Trace (HWT) framework.
Tue, Jul 1, 5:08 AM
kib added inline comments to D51095: Add sched_getaffinity.3 to document sched_getaffinity and sched_setaffinity .
Tue, Jul 1, 3:29 AM
kib added inline comments to D51095: Add sched_getaffinity.3 to document sched_getaffinity and sched_setaffinity .
Tue, Jul 1, 3:18 AM
kib added a comment to D37885: vfs: add vn_getsize.
In D37885#1166278, @des wrote:

Well then what was the point of adding vn_getsize() if it wasn't eventually going to be backed by a VOP?

Tue, Jul 1, 3:08 AM
kib accepted D51099: fcntl.h: Add O_XATTR for Solaris compatibility.
Tue, Jul 1, 3:05 AM
kib accepted D51093: amd64: enable EFER.TCE.

It would be useful to provide a reasoning why the setting is safe.

Tue, Jul 1, 3:02 AM
kib added inline comments to D51091: amd64 pmap: demotion changes for kib@.
Tue, Jul 1, 1:31 AM
kib updated the diff for D50970: amd64 pmap: eliminate two explicit panics on low mem conditions.

pmap_demote_PDEP(): Add WITNESS_WARN, contain operations with m into global if.

Tue, Jul 1, 1:21 AM

Mon, Jun 30

kib added a comment to D51091: amd64 pmap: demotion changes for kib@.

Or, do you want me to integrate this into the series of patches for D50970?

Mon, Jun 30, 10:41 AM
kib updated the diff for D50970: amd64 pmap: eliminate two explicit panics on low mem conditions.

Pass vm_page instead of &vm_page as pt to pmap_demote_pdpe().

Mon, Jun 30, 10:40 AM
kib accepted D51091: amd64 pmap: demotion changes for kib@.
Mon, Jun 30, 10:38 AM

Sun, Jun 29

kib committed rGe0c9d85cab83: libc: expose __getosreldate in private version (authored by kib).
libc: expose __getosreldate in private version
Sun, Jun 29, 1:16 AM
kib committed rG4b8788dd08f1: amd64 locore: fix typo in comment (authored by kib).
amd64 locore: fix typo in comment
Sun, Jun 29, 12:30 AM
kib committed rG7db7118976b5: libthr/amd64: do not set THR_C_RUNTIME for thr_new() if the main thread did… (authored by kib).
libthr/amd64: do not set THR_C_RUNTIME for thr_new() if the main thread did…
Sun, Jun 29, 12:30 AM
kib committed rG3131e7a41725: csu: C standard requires errno on main() entry (authored by kib).
csu: C standard requires errno on main() entry
Sun, Jun 29, 12:30 AM
kib updated the diff for D50648: mnt_renamelock.

Update KASSERT message.
Remove redundant MPASS().

Sun, Jun 29, 12:19 AM

Sat, Jun 28

kib updated the summary of D51085: amd64 pmap: move DMAP out of kernel pml4 table for LA57..
Sat, Jun 28, 11:21 PM
kib added a comment to D51085: amd64 pmap: move DMAP out of kernel pml4 table for LA57..

This effectively allows to boot on >4Tb machines. I tried it on qemu with 8TB configured, the machine boot, but eventually qemu dies on my 64GB w/s due to OOM (really out of swap space).
The sysctl vm.vmtotal looks funny:

System wide totals computed every five seconds: (values in kilobytes)
===============================================
Processes:		(RUNQ: 1 Disk Wait: 0 Page Wait: 0 Sleep: 1)
Virtual Memory:		(Total: 4295023404K Active: 4295023404K)
Real Memory:		(Total: 6192K Active: 6192K)
Shared Virtual Memory:	(Total: 2704K Active: 2704K)
Shared Real Memory:	(Total: 2224K Active: 2224K)
Free Memory:	8402748544K

and top memory usage line cannot display the free memory size.

Sat, Jun 28, 11:20 PM
kib requested review of D51085: amd64 pmap: move DMAP out of kernel pml4 table for LA57..
Sat, Jun 28, 11:18 PM
kib added a comment to D37885: vfs: add vn_getsize.
In D37885#1165729, @des wrote:

Hi @mjg & @kib, if the plan was to eventually add a VOP_GETSIZE(), I would suggest getting it done in the next few weeks, before we branch stable/15. Do you have something planned already or would you like me to cook up a patch?

Sat, Jun 28, 10:18 PM
kib accepted D51059: pctrie: correct iter node after node allocation.
Sat, Jun 28, 6:01 AM
kib added a comment to D50920: rtld-elf: Track allocated TCBs internally and use for distribute_static_tls.
In D50920#1165848, @kib wrote:

Consider increasing RTLD_STATIC_TLS_EXTRA, we now use 16 bytes there unconditionally.

This is done before allocate_initial_tls so before we fix the size of the static TLS block, like any initially loaded object. RTLD_STATIC_TLS_EXTRA remains entirely free for dlopened objects.

Sat, Jun 28, 5:47 AM