User Details
- User Since
- May 16 2014, 7:35 PM (581 w, 1 d)
Today
Loading module which is not configured against the same kernel config as current kernel is dangerous. It does not guarantee that the KBI of module and kernel match, and then all bets are off.
Yesterday
The var should be added to libsys/pathconf.2
Do you want me to rebase the changes?
Fri, Jul 4
Did you considered writing a coccinelle script to do the transformation? We even have the place for it, tools/coccinelle.
Exclude errc() from extended error printing.
Add vexterr() helper.
Thu, Jul 3
Rework retry.
Relock sx between retries.
Check for pending signals.
Update comments.
I believe I already agreed with note 1.
Mention the owned reference in the comment.
Limit the number of restarts for sysctl handler.
Add KVA map.
Use loops instead of memcpy/memset.
Instead of exposing INP_FREED, add in_pcbrele_rlock().
The name pt_root and the term root is confusing IMO. At least it is worth adding a comment explaining the pt_root is some node, not necessary root.
I suggest to split the diff into two.
One for doing something with the signal list, if you decide to move it (or rather merge with the list in signal(3)).
And second for the .Tn removal etc (BTW why?). There is also .St macro, which might be appropriate in some places.
Beg me pardon please for the naive question.
What this revision basically does is changing the semantic of the pt_root. Instead being a real root of the trie, it becomes the starting point for search. The argument for not needed the real root is that we can always climb up to it from any node, following pn_parent. Am I right?
Why the man page added to libsys? It must go into libc/gen.
Wed, Jul 2
Use vm_offset_t for kva_layout members
Rebase.
Correct diff, with all 's.' eliminated.
Track D51127
Drop internal union member name.
Handle MD_PRELOAD in mddestroy().
I proposed the patch to support unmapped preloaded images in D51128, untested.
This patch would require a trivial adaptation, in particular, remove the pmap_map() line, and pass paddr as the second arg to md_preloaded():
md_preloaded(0, paddr, len, scratch, false);
Tue, Jul 1
Properly handle freeing of the allocated pt page.
I only read the sys/kern bits.
It would be useful to provide a reasoning why the setting is safe.
pmap_demote_PDEP(): Add WITNESS_WARN, contain operations with m into global if.
Mon, Jun 30
Or, do you want me to integrate this into the series of patches for D50970?
Pass vm_page instead of &vm_page as pt to pmap_demote_pdpe().
Sun, Jun 29
Update KASSERT message.
Remove redundant MPASS().
Sat, Jun 28
This effectively allows to boot on >4Tb machines. I tried it on qemu with 8TB configured, the machine boot, but eventually qemu dies on my 64GB w/s due to OOM (really out of swap space).
The sysctl vm.vmtotal looks funny:
System wide totals computed every five seconds: (values in kilobytes) =============================================== Processes: (RUNQ: 1 Disk Wait: 0 Page Wait: 0 Sleep: 1) Virtual Memory: (Total: 4295023404K Active: 4295023404K) Real Memory: (Total: 6192K Active: 6192K) Shared Virtual Memory: (Total: 2704K Active: 2704K) Shared Real Memory: (Total: 2224K Active: 2224K) Free Memory: 8402748544K
and top memory usage line cannot display the free memory size.