Page MenuHomeFreeBSD

kib (Konstantin Belousov)
User

Projects

User Details

User Since
May 16 2014, 7:35 PM (633 w, 3 d)

Recent Activity

Today

kib updated the diff for D57163: pddupfd(2).

Rebase after pdopenpid() tests committed.

Tue, Jul 7, 2:50 PM
kib accepted D58061: linux/futex: Don't load a timeout when try-locking a mutex.
Tue, Jul 7, 2:49 PM
kib committed rG07f780cb7f8e: mlx5: propagate the DEVX uid through SRQ create and destroy (authored by aehrenberg_nvidia.com).
mlx5: propagate the DEVX uid through SRQ create and destroy
Tue, Jul 7, 11:31 AM
kib committed rG284e06dec78f: mlx5: guard against a NULL CQ event handler in mlx5_cq_event() (authored by aehrenberg_nvidia.com).
mlx5: guard against a NULL CQ event handler in mlx5_cq_event()
Tue, Jul 7, 11:31 AM
kib committed rG0e9bbbdcbea8: mlx5: pass the full EQE to the DEVX event notifier (authored by aehrenberg_nvidia.com).
mlx5: pass the full EQE to the DEVX event notifier
Tue, Jul 7, 11:31 AM
kib committed rGa7298669cd53: ofed/ib_uverbs: release rdma_user_mmap entry ref in rdma_umap_close() (authored by aehrenberg_nvidia.com).
ofed/ib_uverbs: release rdma_user_mmap entry ref in rdma_umap_close()
Tue, Jul 7, 11:31 AM
kib committed rG80902b8b7cd4: mlx5ib: advertise write-combining support for dynamic BlueFlame UARs (authored by aehrenberg_nvidia.com).
mlx5ib: advertise write-combining support for dynamic BlueFlame UARs
Tue, Jul 7, 11:31 AM
kib committed rG631e57d54c13: mlx5ib: encode dynamic UAR mmap offsets in the reserved command range (authored by aehrenberg_nvidia.com).
mlx5ib: encode dynamic UAR mmap offsets in the reserved command range
Tue, Jul 7, 11:31 AM
kib committed rG412aa220aeb9: mlx5ib: allocate IB queue counters as a shared resource (authored by aehrenberg_nvidia.com).
mlx5ib: allocate IB queue counters as a shared resource
Tue, Jul 7, 11:31 AM
kib committed rGbfe14bfeb8dc: mlx5: mark completion EQs as a shared resource for DEVX uids (authored by aehrenberg_nvidia.com).
mlx5: mark completion EQs as a shared resource for DEVX uids
Tue, Jul 7, 11:31 AM
kib committed rGb7ca46b161d8: mlx5ib: implement the MLX5_IB_OBJECT_UAR ioctl object (authored by aehrenberg_nvidia.com).
mlx5ib: implement the MLX5_IB_OBJECT_UAR ioctl object
Tue, Jul 7, 11:31 AM
kib committed rG705d6cf4bf25: mlx5_ib: register DEVX objects in the uverbs ioctl parse tree (authored by aehrenberg_nvidia.com).
mlx5_ib: register DEVX objects in the uverbs ioctl parse tree
Tue, Jul 7, 11:31 AM
kib committed rG2e3b3ce88149: mlx5_ib: do not consume CMD/PAGE_REQUEST events in the DEVX notifier (authored by aehrenberg_nvidia.com).
mlx5_ib: do not consume CMD/PAGE_REQUEST events in the DEVX notifier
Tue, Jul 7, 11:30 AM
kib committed rG716bb8d3d402: mlx5: extend mlx5_ib_create_cq struct with fields from the current Linux ABI (authored by kib).
mlx5: extend mlx5_ib_create_cq struct with fields from the current Linux ABI
Tue, Jul 7, 11:30 AM
kib committed rG849a51ac8371: pdfork.2: grammar (authored by kib).
pdfork.2: grammar
Tue, Jul 7, 8:07 AM
kib updated the diff for D57163: pddupfd(2).

Add pddupfd test

Tue, Jul 7, 6:08 AM
kib added a comment to D57658: Implement AT_RENAME_EXCHANGE flag for VFS and tmpfs.

Since some time, all renames on the specific mount point are serialized. I added the mp->mnt_renamelock a year ago. So it is really not even a journal but just a storage for two dirents, and theirs locationss in the directory blocks. It can be done synchronously to avoid storing more that one exchange entry.

Tue, Jul 7, 4:11 AM
kib accepted D58063: kern: imgact: fix imgp->interpreted.
Tue, Jul 7, 3:25 AM
kib added inline comments to D58058: exterr: relax format restrictions.
Tue, Jul 7, 2:52 AM
kib added inline comments to D58059: runtime: add uexterr_set(3) to set errors in userspace.
Tue, Jul 7, 2:50 AM
kib updated the diff for D57163: pddupfd(2).

Re-upload pddupfd() diff after pdopenpid() commit.

Tue, Jul 7, 2:06 AM
kib committed rG3e8b68c26e2b: pdfork.2: document pdopenpid(2) (authored by kib).
pdfork.2: document pdopenpid(2)
Tue, Jul 7, 1:58 AM
kib committed rGf7675fab2084: Regen (authored by kib).
Regen
Tue, Jul 7, 1:58 AM
kib committed rG5a5affd457eb: pdfork.2: clarify that PD_DAEMON acts on current file (authored by kib).
pdfork.2: clarify that PD_DAEMON acts on current file
Tue, Jul 7, 1:58 AM
kib committed rGd6ff3bb3de91: libsys: export pdopenpid(2) (authored by kib).
libsys: export pdopenpid(2)
Tue, Jul 7, 1:58 AM
kib committed rG1cced4932899: pdfork.2: document EINVAL for pdwait(2) (authored by kib).
pdfork.2: document EINVAL for pdwait(2)
Tue, Jul 7, 1:58 AM
kib committed rG606061ea463d: sys: add AUE_PDOPENPID (authored by kib).
sys: add AUE_PDOPENPID
Tue, Jul 7, 1:58 AM
kib committed rG5c32aa785184: kern: add pdopenpid(2) (authored by kib).
kern: add pdopenpid(2)
Tue, Jul 7, 1:58 AM
kib committed rGc0e1201aaba8: procdesc: make PD_DAEMON per-file (authored by kib).
procdesc: make PD_DAEMON per-file
Tue, Jul 7, 1:58 AM
kib committed rG18b6bb5231bf: procdesc: track count of open files (authored by kib).
procdesc: track count of open files
Tue, Jul 7, 1:58 AM
kib committed rG90b560f7bae6: sys_procdesc: extract procdesc_destroy() (authored by kib).
sys_procdesc: extract procdesc_destroy()
Tue, Jul 7, 1:57 AM
kib committed rG974770199877: sys_procdesc: extract pdtofdflags() (authored by kib).
sys_procdesc: extract pdtofdflags()
Tue, Jul 7, 1:57 AM
kib committed rGaa1694e23401: procdesc_exit(): assert that _exit() was called (authored by kib).
procdesc_exit(): assert that _exit() was called
Tue, Jul 7, 1:57 AM
kib committed rG599d021224f2: sys_procdesc: extract procdesc_alloc() (authored by kib).
sys_procdesc: extract procdesc_alloc()
Tue, Jul 7, 1:57 AM
kib closed D57124: sys: add pdopenpid(2).
Tue, Jul 7, 1:57 AM
kib accepted D58056: exterr: allow exterr to fit pointers on CHERI targets.
Tue, Jul 7, 1:55 AM
kib accepted D58055: exterrctl(2): add kern_exterrctl.
Tue, Jul 7, 1:54 AM
kib added inline comments to D58061: linux/futex: Don't load a timeout when try-locking a mutex.
Tue, Jul 7, 1:50 AM

Yesterday

kib accepted D58023: tests/procdesc: Add some test cases for pdopenpid().
Mon, Jul 6, 2:29 PM
kib added inline comments to D58023: tests/procdesc: Add some test cases for pdopenpid().
Mon, Jul 6, 2:12 PM
kib accepted D58053: vfs: Fix resource leaks in kern_symlinkat().
Mon, Jul 6, 1:45 PM
kib committed rGb125b736eaf7: ibcore: Fix GID sysctl fallback formatting (authored by slavash).
ibcore: Fix GID sysctl fallback formatting
Mon, Jul 6, 10:19 AM
kib closed D58042: ibcore: Fix GID sysctl fallback formatting.
Mon, Jul 6, 10:18 AM
kib added inline comments to D58023: tests/procdesc: Add some test cases for pdopenpid().
Mon, Jul 6, 7:16 AM
kib added a comment to D57658: Implement AT_RENAME_EXCHANGE flag for VFS and tmpfs.

This cannot be implemented in UFS since a requirement of its consistency model is that the on-disk image is always consistent. If the directory entries being swapped are in two different disk blocks, then there is no order of writing that will have a consistent filesystem. The only way to ensure consistency is to have a journal that can correct the unwritten directory name with its updated inode number.

Mon, Jul 6, 5:42 AM
kib committed rG806f0b4b8a9a: bnxt: Report actual link speed, rather than hard-coded 100Gbs (authored by gallatin).
bnxt: Report actual link speed, rather than hard-coded 100Gbs
Mon, Jul 6, 1:44 AM
kib committed rG0dc46fba9359: lacp: Simplify lacp_compose_key() (authored by gallatin).
lacp: Simplify lacp_compose_key()
Mon, Jul 6, 1:44 AM
kib committed rG020f7f6cf1ff: lacp: fix link state with multiple aggregators (authored by gallatin).
lacp: fix link state with multiple aggregators
Mon, Jul 6, 1:44 AM
kib committed rGb86eb36f28db: lacp: Sort port map by interface index (authored by gallatin).
lacp: Sort port map by interface index
Mon, Jul 6, 1:44 AM
kib committed rG60bb6c368e3c: mlx5en: guard against empty eth_proto_oper mask (authored by slavash).
mlx5en: guard against empty eth_proto_oper mask
Mon, Jul 6, 1:44 AM
kib committed rGd4793552bded: mlx5: Add missing speeds translation (authored by slavash).
mlx5: Add missing speeds translation
Mon, Jul 6, 1:44 AM
kib committed rG2bdcf05c89dd: libmlx5: sync PCI device allowlist with mlx5_core_pci_table (authored by slavash).
libmlx5: sync PCI device allowlist with mlx5_core_pci_table
Mon, Jul 6, 1:44 AM
kib committed rG69a8bf9e58bc: mlx5: Add PCI IDs for ConnectX-9. (authored by slavash).
mlx5: Add PCI IDs for ConnectX-9.
Mon, Jul 6, 1:44 AM
kib committed rG3ab9e202117b: mlx5: Add support for 800Gbit/s and 400Gbit/s with 2 lanes (authored by slavash).
mlx5: Add support for 800Gbit/s and 400Gbit/s with 2 lanes
Mon, Jul 6, 1:44 AM
kib committed rG05bd1cecc7e9: ibcore: Add support for XDR link speed. (authored by slavash).
ibcore: Add support for XDR link speed.
Mon, Jul 6, 1:43 AM
kib committed rG5d044e4b9f33: RDMA: Fix link active_speed size (authored by slavash).
RDMA: Fix link active_speed size
Mon, Jul 6, 1:43 AM
kib committed rGf71aaa2b10ce: net/if_media.h: Add 800GBase-X and 200Gbit/s per lane support (authored by slavash).
net/if_media.h: Add 800GBase-X and 200Gbit/s per lane support
Mon, Jul 6, 1:43 AM
kib committed rGd1f7902fda83: sys/systm.h: include sys/limits.h for SSIZE_MAX (authored by kib).
sys/systm.h: include sys/limits.h for SSIZE_MAX
Mon, Jul 6, 1:07 AM
kib committed rG5ed7b34469d1: x86: add CPUID bits for SHA512/SM3/SM4 (authored by kib).
x86: add CPUID bits for SHA512/SM3/SM4
Mon, Jul 6, 1:07 AM
kib committed rG10ed74b1b94e: posix_spawn(3): create a guard page below the stack for rfork_thread on x86 (authored by kib).
posix_spawn(3): create a guard page below the stack for rfork_thread on x86
Mon, Jul 6, 1:07 AM
kib committed rGb9ff22f3a27c: do_posix_spawn(): use bool (authored by kib).
do_posix_spawn(): use bool
Mon, Jul 6, 1:07 AM
kib committed rGb3ce127cc330: rtld: unify the return path for map_object() (authored by kib).
rtld: unify the return path for map_object()
Mon, Jul 6, 1:07 AM
kib committed rGe8658b2c5046: rtld: add spinlock around the crt malloc calls (authored by kib).
rtld: add spinlock around the crt malloc calls
Mon, Jul 6, 1:06 AM
kib committed rG682ebe10032d: rtld: stop using unbound alloca() (authored by kib).
rtld: stop using unbound alloca()
Mon, Jul 6, 1:06 AM

Sun, Jul 5

kib added a comment to D58023: tests/procdesc: Add some test cases for pdopenpid().

Do we want some test to ensure that pdopenpid() has no effect on the target? I mean, ptrace(PT_ATTACH) might cause spurious wakeups (partially mitigated now).

Sun, Jul 5, 7:38 PM
kib added a comment to D58035: sendfile: stop abusing kern_writev().
In D58035#1330852, @kib wrote:

atomic_store_int(comm, -1);

What is this from?

Sun, Jul 5, 7:31 PM
kib added a comment to D58042: ibcore: Fix GID sysctl fallback formatting.

Please pass the -U999999 argument to the git diff command you used to generate the uploaded patch, for the next time.

Sun, Jul 5, 8:36 AM
kib accepted D58042: ibcore: Fix GID sysctl fallback formatting.
Sun, Jul 5, 8:35 AM
kib committed rG4efbcf36a0d4: libc locale/localeconv.c: use release semantic when clearing locale_changed (authored by kib).
libc locale/localeconv.c: use release semantic when clearing locale_changed
Sun, Jul 5, 3:19 AM
kib updated the diff for D58018: vm: add vm_object' page insertion and removal events hooks.

Rename hooks->events and move into vm_object.h

Sun, Jul 5, 1:51 AM
kib added a comment to D58018: vm: add vm_object' page insertion and removal events hooks.
In D58018#1330488, @kib wrote:

We already have pager methods for page insertion and removal, why aren't they sufficient?

I want the hooks to be set on per-object basis, not globally for all pagers of some type. My use case is having objects backing the IOMMU-managed DMA to be swap objects. This is not too useful for busdma, but I believe is doable and might be not even too hard for bhyve pass-through, assuming I land the iommu/bhyve integration.

At least for now I suggest renaming the hooks to remove the use of "pager".

Done.

Sun, Jul 5, 1:50 AM

Sat, Jul 4

kib added a comment to D58035: sendfile: stop abusing kern_writev().

atomic_store_int(comm, -1);

Sat, Jul 4, 5:54 PM
kib updated the diff for D58035: sendfile: stop abusing kern_writev().

Update the comment.

Sat, Jul 4, 4:26 PM
kib added inline comments to D58035: sendfile: stop abusing kern_writev().
Sat, Jul 4, 4:23 PM
kib requested review of D58035: sendfile: stop abusing kern_writev().
Sat, Jul 4, 2:32 AM
kib committed rGbcb471cfb499: sys/systm.h: include sys/limits.h for SSIZE_MAX (authored by kib).
sys/systm.h: include sys/limits.h for SSIZE_MAX
Sat, Jul 4, 1:27 AM

Fri, Jul 3

kib updated the diff for D57124: sys: add pdopenpid(2).

Do not reap on finstall() error.
Man page editing.

Fri, Jul 3, 3:35 PM
kib added inline comments to D57124: sys: add pdopenpid(2).
Fri, Jul 3, 3:34 PM
kib added a comment to D58023: tests/procdesc: Add some test cases for pdopenpid().

i will check this against my branch later. Could you please mail me the git-format patch?

Fri, Jul 3, 3:34 PM
kib added a comment to D58018: vm: add vm_object' page insertion and removal events hooks.

We already have pager methods for page insertion and removal, why aren't they sufficient?

Fri, Jul 3, 3:01 PM
kib accepted D57857: autofs: enable witness for autofs node lock.
Fri, Jul 3, 2:05 AM
kib added a comment to D58018: vm: add vm_object' page insertion and removal events hooks.
In D58018#1330420, @bz wrote:

Would you mind adding a note what this will be good for in the future to the proposed commit message?

Fri, Jul 3, 1:24 AM
kib committed rGc041b82c59e8: ffs: do not return ESTALE on attempt to ffs_unotovp() on unlinked inode (authored by kib).
ffs: do not return ESTALE on attempt to ffs_unotovp() on unlinked inode
Fri, Jul 3, 12:29 AM
kib closed D57982: ffs: do not return ESTALE on attempt to ffs_unotovp() on unlinked inode.
Fri, Jul 3, 12:29 AM
kib committed rG0cff90f802fd: VOP_VPUT_PAIR(): handle the case when dvp == vp (authored by kib).
VOP_VPUT_PAIR(): handle the case when dvp == vp
Fri, Jul 3, 12:27 AM
kib added a comment to D55957: vm: Support swapping arm64 MTE tags.
In D55957#1329686, @kib wrote:

i object against this code structure on principle.

  • swp_pager_meta_archXXX should go into the arm64/arm64/somewhere.c. All of them should become arch hooks that do not add any #ifdefs to the sys/vm sources.
  • If you absolutely need the extension of the struct swblk, it should be done in a way similar to how struct vm_page gets it MD members.

The space required to store tags is quite large, and we do not want to impose that on all platforms, so this would need to be done with some indirection.

That said, I believe there was some idea circulating about adding hooks to the page lifetime. The motivation for it was e.g. support for demand-paging and page fault events from IOMMUs. Did you considered defining the KPI for hooks on page insertion and removal from the objects, that would allow you to do this stuff without such pollution of the VM code?

Do you mean that the tag metadata should be associated with the VM object, rather than the swap block?

Fri, Jul 3, 12:23 AM
kib updated subscribers of D58018: vm: add vm_object' page insertion and removal events hooks.
Fri, Jul 3, 12:23 AM
kib added a comment to D58018: vm: add vm_object' page insertion and removal events hooks.

Right now both hooks are called with the object locked, and the 'before_removal' is called with the page xbusied.
I am not sure that this is what needed for the callers: for instance, we might consider xbusying the page for 'after_insert' unconditionally regardless of the vm_page_alloc() mode. Then hooks are allowed to unlock the object if needed.

Fri, Jul 3, 12:23 AM
kib updated the summary of D58018: vm: add vm_object' page insertion and removal events hooks.
Fri, Jul 3, 12:19 AM
kib updated the diff for D58018: vm: add vm_object' page insertion and removal events hooks.

initialize pgh on object creation.

Fri, Jul 3, 12:18 AM
kib requested review of D58018: vm: add vm_object' page insertion and removal events hooks.
Fri, Jul 3, 12:16 AM

Thu, Jul 2

kib updated subscribers of D57163: pddupfd(2).
Thu, Jul 2, 11:51 PM
kib updated subscribers of D57124: sys: add pdopenpid(2).
Thu, Jul 2, 11:50 PM
kib updated subscribers of D57658: Implement AT_RENAME_EXCHANGE flag for VFS and tmpfs.
Thu, Jul 2, 11:50 PM
kib added a comment to D57658: Implement AT_RENAME_EXCHANGE flag for VFS and tmpfs.
In D57658#1325551, @kib wrote:

Set WILLBEDIR for fromnd of tvp is VDIR.

Thu, Jul 2, 11:50 PM
kib committed rGf27c1da74aab: ntsync.4: be explicit about the effect of automatic vs manual event on waiters (authored by kib).
ntsync.4: be explicit about the effect of automatic vs manual event on waiters
Thu, Jul 2, 12:24 AM

Wed, Jul 1

kib accepted D57858: Prevent a jail_attach race between threads.
Wed, Jul 1, 11:59 PM
kib added inline comments to D55956: arm64: Add PROT_MTE to mmap.
Wed, Jul 1, 11:57 PM
kib added inline comments to D57858: Prevent a jail_attach race between threads.
Wed, Jul 1, 11:41 PM
kib committed rGcf851111b02f: x86: add CPUID bits for SHA512/SM3/SM4 (authored by kib).
x86: add CPUID bits for SHA512/SM3/SM4
Wed, Jul 1, 11:38 PM