Page MenuHomeFreeBSD
Differential D53624

kern_thread: thread_suspend_check(1) must never suspend
ClosedPublic
Actions

Authored by kib on Nov 6 2025, 7:28 PM.
Tags
None
Referenced Files
F145746961: D53624.diff
Mon, Feb 23, 9:55 PM
F145746910: D53624.diff
Mon, Feb 23, 9:55 PM
Unknown Object (File)
Fri, Feb 20, 5:58 AM
Unknown Object (File)
Thu, Feb 19, 6:36 AM
Unknown Object (File)
Tue, Feb 17, 12:34 AM
Unknown Object (File)
Sun, Feb 15, 2:27 PM
Unknown Object (File)
Wed, Feb 11, 11:31 PM
Unknown Object (File)
Fri, Jan 30, 6:14 PM
View All 41 Files
Subscribers
bdrewery
emaste
imp
olce
pho

Details

Reviewers
markj
bdrewery
Commits
rGe1c6f4cb9bd2: kern_thread: thread_suspend_check(1) must never suspend
Summary
Reported by:    bdrewery
PR:     290843

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Nov 6 2025, 7:28 PM
Herald added subscribers: olce, imp. · View Herald TranscriptNov 6 2025, 7:28 PM
kib requested review of this revision.Nov 6 2025, 7:28 PM
bdrewery added a comment.Nov 6 2025, 7:34 PM

Testing this now.

bdrewery added a comment.Nov 6 2025, 9:10 PM

Thanks for the quick fix! It passes my repro.

sys/kern/kern_thread.c
1491–1494

This branch is now always true.

kib updated this revision to Diff 165983.Nov 6 2025, 9:15 PM

Assert always true condition, instead of checking for it.

markj accepted this revision.Nov 7 2025, 2:25 PM
This revision is now accepted and ready to land.Nov 7 2025, 2:25 PM
emaste added a subscriber: emaste.Nov 8 2025, 6:07 PM
emaste added inline comments.
sys/kern/kern_thread.c
1450
kib marked an inline comment as done.Nov 8 2025, 7:58 PM
kib marked an inline comment as done.
bdrewery accepted this revision.Nov 10 2025, 4:51 PM

I have not reviewed each case but have been running it without problems and it looks reasonable.

Closed by commit rGe1c6f4cb9bd2: kern_thread: thread_suspend_check(1) must never suspend (authored by kib). · Explain WhyNov 11 2025, 8:54 AM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rGe1c6f4cb9bd2: kern_thread: thread_suspend_check(1) must never suspend.

Revision Contents
Changeset List

PathSize
sys/
kern/
15 lines

Diff 166198

View Options

sys/kern/kern_thread.c

Loading...