Page MenuHomeFreeBSD
Differential D53624

kern_thread: thread_suspend_check(1) must never suspend
ClosedPublic
Actions

Authored by kib on Thu, Nov 6, 7:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 11, 9:56 AM
Unknown Object (File)
Sat, Nov 8, 10:03 PM
Unknown Object (File)
Fri, Nov 7, 12:12 PM
Unknown Object (File)
Fri, Nov 7, 12:12 PM
Unknown Object (File)
Fri, Nov 7, 12:12 PM
Unknown Object (File)
Fri, Nov 7, 11:48 AM
Unknown Object (File)
Fri, Nov 7, 10:43 AM
Unknown Object (File)
Fri, Nov 7, 6:52 AM
View All 13 Files
Subscribers
bdrewery
emaste
imp
olce
pho

Details

Reviewers
markj
bdrewery
Commits
rGe1c6f4cb9bd2: kern_thread: thread_suspend_check(1) must never suspend
Summary
Reported by:    bdrewery
PR:     290843

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Thu, Nov 6, 7:28 PM
Herald added subscribers: olce, imp. · View Herald TranscriptThu, Nov 6, 7:28 PM
kib requested review of this revision.Thu, Nov 6, 7:28 PM
bdrewery added a comment.Thu, Nov 6, 7:34 PM

Testing this now.

bdrewery added a comment.Thu, Nov 6, 9:10 PM

Thanks for the quick fix! It passes my repro.

sys/kern/kern_thread.c
1491–1494

This branch is now always true.

kib updated this revision to Diff 165983.Thu, Nov 6, 9:15 PM

Assert always true condition, instead of checking for it.

markj accepted this revision.Fri, Nov 7, 2:25 PM
This revision is now accepted and ready to land.Fri, Nov 7, 2:25 PM
emaste added a subscriber: emaste.Sat, Nov 8, 6:07 PM
emaste added inline comments.
sys/kern/kern_thread.c
1450
kib marked an inline comment as done.Sat, Nov 8, 7:58 PM
kib marked an inline comment as done.
bdrewery accepted this revision.Mon, Nov 10, 4:51 PM

I have not reviewed each case but have been running it without problems and it looks reasonable.

Closed by commit rGe1c6f4cb9bd2: kern_thread: thread_suspend_check(1) must never suspend (authored by kib). · Explain WhyTue, Nov 11, 8:54 AM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rGe1c6f4cb9bd2: kern_thread: thread_suspend_check(1) must never suspend.

Revision Contents
Changeset List

PathSize
sys/
kern/
15 lines

Diff 166198

View Options

sys/kern/kern_thread.c

Loading...