Page MenuHomeFreeBSD

kern_thread: thread_suspend_check(1) must never suspend
ClosedPublic

Authored by kib on Thu, Nov 6, 7:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 11, 9:56 AM
Unknown Object (File)
Sat, Nov 8, 10:03 PM
Unknown Object (File)
Fri, Nov 7, 12:12 PM
Unknown Object (File)
Fri, Nov 7, 12:12 PM
Unknown Object (File)
Fri, Nov 7, 12:12 PM
Unknown Object (File)
Fri, Nov 7, 11:48 AM
Unknown Object (File)
Fri, Nov 7, 10:43 AM
Unknown Object (File)
Fri, Nov 7, 6:52 AM

Details

Summary
Reported by:    bdrewery
PR:     290843

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib requested review of this revision.Thu, Nov 6, 7:28 PM

Thanks for the quick fix! It passes my repro.

sys/kern/kern_thread.c
1491–1494

This branch is now always true.

Assert always true condition, instead of checking for it.

This revision is now accepted and ready to land.Fri, Nov 7, 2:25 PM
emaste added inline comments.
sys/kern/kern_thread.c
1450
kib marked an inline comment as done.Sat, Nov 8, 7:58 PM
kib marked an inline comment as done.

I have not reviewed each case but have been running it without problems and it looks reasonable.