Page MenuHomeFreeBSD

syscalls: if ptrace(PT_SETREG) occured during syscall, do not do set_syscall_retval()
Needs ReviewPublic

Authored by kib on Thu, Oct 30, 6:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 24, 5:24 PM
Unknown Object (File)
Mon, Nov 24, 9:22 AM
Unknown Object (File)
Thu, Nov 20, 8:26 PM
Unknown Object (File)
Thu, Nov 13, 4:46 AM
Unknown Object (File)
Tue, Nov 11, 10:38 PM
Unknown Object (File)
Tue, Nov 11, 8:26 PM
Unknown Object (File)
Tue, Nov 11, 8:00 PM
Unknown Object (File)
Tue, Nov 11, 7:55 PM
Subscribers

Details

Summary
to preserve the register state enforced by debugger.  This is only
relevant for transparent attach to the slow syscalls where sleeps are
not interrupted.

PR:     290008


kern/subr_syscalls.c: declare 'traced' local variables boolean

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib requested review of this revision.Thu, Oct 30, 6:41 PM

That said, I disagree that this is a kernel bug at all.

sys/kern/subr_syscall.c
119

Don't we need the proc lock here?

kib marked an inline comment as done.

Clear TDB_USERWR under proc lock. Do it earlier.

I'm not sure if we should make such a change, but it looks ok to me.

This revision is now accepted and ready to land.Sun, Nov 2, 5:48 PM
kib updated this revision to Diff 165700.

Rebase