Differential D53536

nfs_clvnops: standardize on EOPNOTSUPP for posix_fallocate(2)
ClosedPublic
Actions

Authored by kevans on Nov 2 2025, 3:20 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 13, 6:14 PM

	Unknown Object (File)
	Wed, May 13, 3:38 PM

	Unknown Object (File)
	Tue, May 12, 6:44 AM

	Unknown Object (File)
	Wed, May 6, 12:55 PM

	Unknown Object (File)
	Fri, May 1, 1:35 PM

	Unknown Object (File)
	Fri, May 1, 11:44 AM

	Unknown Object (File)
	Thu, Apr 30, 7:55 PM

	Unknown Object (File)
	Wed, Apr 29, 10:42 AM

View All 57 Files

Subscribers

Details

Reviewers

asomers
rmacklem
emaste
kib
imp

Commits

rGb87436d8be8e: nfs_clvnops: standardize on EOPNOTSUPP for posix_fallocate(2)

Summary

POSIX Issue 7 had allowed EINVAL for this case, but issue 8 moves it
to ENOTSUP instead. ZFS uses the latter and we have some software in
ports already that's wanting to use that to detect the filesystem not
supporting it, so let's standardize on it.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Nov 2 2025, 3:20 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 2 2025, 3:20 PM

Harbormaster completed remote builds in B68353: Diff 165678.Nov 2 2025, 3:20 PM

kevans requested review of this revision.Nov 2 2025, 3:20 PM

kevans added a parent revision: D53535: fusefs: standardize on OPNOTSUPP for posix_fallocate(2).

kevans added a child revision: D53537: posix_fallocate(2): move unsupported case to EOPNOTSUPP.

imp accepted this revision.Nov 2 2025, 3:26 PM

This revision is now accepted and ready to land.Nov 2 2025, 3:26 PM

rmacklem accepted this revision.Nov 2 2025, 3:40 PM

kib accepted this revision.Nov 2 2025, 8:22 PM

Closed by commit rGb87436d8be8e: nfs_clvnops: standardize on EOPNOTSUPP for posix_fallocate(2) (authored by kevans). · Explain WhyNov 5 2025, 12:31 AM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rGb87436d8be8e: nfs_clvnops: standardize on EOPNOTSUPP for posix_fallocate(2).

Revision Contents
Changeset List

Path

Size

sys/

fs/

nfsclient/

8 lines

Diff 165856

sys/fs/nfsclient/nfs_clvnops.c

Loading...