Page MenuHomeFreeBSD

posix_fallocate(2): move unsupported case to EOPNOTSUPP
ClosedPublic

Authored by kevans on Sun, Nov 2, 3:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 2, 10:14 PM
Unknown Object (File)
Sun, Nov 2, 9:54 PM
Unknown Object (File)
Sun, Nov 2, 9:53 PM
Unknown Object (File)
Sun, Nov 2, 9:53 PM
Unknown Object (File)
Sun, Nov 2, 9:53 PM
Unknown Object (File)
Sun, Nov 2, 8:54 PM
Unknown Object (File)
Sun, Nov 2, 8:52 PM
Unknown Object (File)
Sun, Nov 2, 8:51 PM
Subscribers

Details

Summary

ZFS has since been changed to use EOPNOTSUPP instead of EINVAL, and
fusefs/nfs are following suit. POSIX Issue 8 had also made this move,
so it makes sense for us to standardize on EOPNOTSUPP.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans requested review of this revision.Sun, Nov 2, 3:20 PM

Worth an issue 8 note in the history standards section?

This revision is now accepted and ready to land.Sun, Nov 2, 3:27 PM
In D53537#1222227, @imp wrote:

Worth an issue 8 note in the history standards section?

Might be, indeed, add such note plus note that previous versions of zfs returned EINVAL.

Describe the switch a little more in HISTORY and update the STANDARDS; the
notable changes since -2004 are this different error return and clarification
of EFBIG to surface if the file size limit is exceeded (with generation of a
SIGXFSZ).

This revision now requires review to proceed.Tue, Nov 4, 3:32 PM
This revision is now accepted and ready to land.Tue, Nov 4, 4:16 PM