Page MenuHomeFreeBSD
Differential D53351

exterror(9): add infra for bufs and bios
ClosedPublic
Actions

Authored by kib on Oct 25 2025, 9:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 3, 6:34 PM
Unknown Object (File)
Nov 13 2025, 4:21 AM
Unknown Object (File)
Nov 9 2025, 5:08 PM
Unknown Object (File)
Nov 6 2025, 9:45 PM
Unknown Object (File)
Oct 31 2025, 1:14 PM
Unknown Object (File)
Oct 31 2025, 6:51 AM
Unknown Object (File)
Oct 30 2025, 2:16 PM
Unknown Object (File)
Oct 28 2025, 11:18 PM
View All 19 Files
Subscribers
dab
olce

Details

Reviewers
imp
mav
mckusick
Commits
rG515fa5ff2e4d: geom/geom_vfs.c: use EXTERROR_KE() in g_vfs_strategy for ENXIOs
rG6c406b5b9312: exterror(9): add infra for bufs and bios
rG069e2fb5506f: exterror(9): add two helpers
rG7746b51dae12: exterror(9): add SETEXTERROR_KE() macro
rG58e5f3b84df0: sys/: rename bio_error variable to abio_error
Summary
The extended error can be stored in either struct bio or struct buf,
indicated by BIO_EXTERR bio_flag.  At some strategic places, it is
copied into the current thread extended error.

This structure is required because io request from the top might pass
down through several io threads and the context that can report meaningful
extended error does not belong to the thread that initiated the io.

WIP: more geom providers should handle BIO_EXTERR when passing cloned
bios down and then handling completions.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Oct 25 2025, 9:24 AM
Herald added subscribers: olce, dab, imp. · View Herald TranscriptOct 25 2025, 9:24 AM
kib requested review of this revision.Oct 25 2025, 9:24 AM
kib updated this revision to Diff 165234.Oct 28 2025, 6:56 PM
kib edited the summary of this revision. (Show Details)
kib added reviewers: imp, mav.
kib removed a subscriber: imp.

Debugged version. Worked for me with the artificial random errors returned from md(4) start_swap() on BIO_READ.

mckusick added a subscriber: mckusick.Oct 28 2025, 7:06 PM

This approach seems like the right way to get the extended errors back from the underlying devices.

kib added a reviewer: mckusick.Oct 29 2025, 7:30 AM
kib removed a subscriber: mckusick.
mckusick accepted this revision.Nov 3 2025, 10:30 PM

Tried it out and had no problems and got expected errors.

This revision is now accepted and ready to land.Nov 3 2025, 10:30 PM
Closed by commit rG58e5f3b84df0: sys/: rename bio_error variable to abio_error (authored by kib). · Explain WhyNov 4 2025, 4:12 AM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG58e5f3b84df0: sys/: rename bio_error variable to abio_error.
kib added a commit: rG7746b51dae12: exterror(9): add SETEXTERROR_KE() macro.
kib added a commit: rG069e2fb5506f: exterror(9): add two helpers.
kib added a commit: rG6c406b5b9312: exterror(9): add infra for bufs and bios.
kib added a commit: rG515fa5ff2e4d: geom/geom_vfs.c: use EXTERROR_KE() in g_vfs_strategy for ENXIOs.
imp added a comment.Nov 4 2025, 2:45 PM

the ddb commands that display bio and buf need to be updated.

Revision Contents
Changeset List

PathSize
sys/
dev/
mmc/
8 lines
nvme/
14 lines
kern/
10 lines

Diff 165786

View Options

sys/dev/mmc/mmcsd.c

Loading...
View Options

sys/dev/nvme/nvme_ns.c

Loading...
View Options

sys/kern/vfs_aio.c

Loading...