HomeFreeBSD

ifconfig: Fix invalid free() in ifbridge

Description

ifconfig: Fix invalid free() in ifbridge

parse_vlans() does 's = strdup(str)', then calls strsep(&s, ...), then
attempts to free(s) at the end of the function. For the success case,
this is fine (s is NULL, so it's a trivial memory leak), but in the
error case, we will attempt to free an invalid pointer.

Fix this by storing the original return value from strdup() and freeing
that instead.

MFC after: 3 seconds
Reported by: David Gwynne <dlg@openbsd.org>
Reviewed by: zlei, kevans
Sponsored by: https://www.patreon.com/bsdivy
Differential Revision: https://reviews.freebsd.org/D53545

Details

Provenance
ivyAuthored on Nov 4 2025, 12:53 AM
Reviewer
zlei
Differential Revision
D53545: ifconfig: Fix invalid free() in ifbridge
Parents
rG8234c1899b30: release: Make fetch happen in GCE images
Branches
Unknown
Tags
Unknown