Page MenuHomeFreeBSD

fabient (Fabien Thomas)
User

Projects

User Details

User Since
Feb 9 2015, 1:21 PM (228 w, 2 d)

Recent Activity

May 22 2018

fabient closed D15050: Add a SPD cache to speed up lookups.
May 22 2018, 3:54 PM · network
fabient committed rS334054: Add a SPD cache to speed up lookups..
Add a SPD cache to speed up lookups.
May 22 2018, 3:54 PM

Feb 16 2018

fabient added a comment to D13980: Fix ixl driver performance issue.

What appears like a bug is that return code for rxeof is checked to start the taskqueue.
If it is an optimization not to call the taskqueue it is at least better to do it in the callers ?
The other point is why coding the taskqueue if it is never scheduled (except for more_tx maybe) ?

Feb 16 2018, 8:23 AM

Jan 17 2018

fabient committed rS328088: Only call flush in pipe mode..
Only call flush in pipe mode.
Jan 17 2018, 4:56 PM
fabient committed rS328087: Fix pmcstat exit from kernel introduced by r325275..
Fix pmcstat exit from kernel introduced by r325275.
Jan 17 2018, 4:41 PM

Jan 8 2018

fabient committed rS327696: Fix uninitialized crp_retw_id when using asynchronous crypto drivers.
Fix uninitialized crp_retw_id when using asynchronous crypto drivers
Jan 8 2018, 1:43 PM

Nov 30 2017

fabient committed rS326390: Update man page for r325354..
Update man page for r325354.
Nov 30 2017, 8:28 AM

Nov 3 2017

fabient committed rS325354: crypto(9) is called from ipsec in CRYPTO_F_CBIFSYNC mode. This is working.
crypto(9) is called from ipsec in CRYPTO_F_CBIFSYNC mode. This is working
Nov 3 2017, 10:27 AM
fabient closed D10680: IPSec performance increase in single flow mode by making crypto(9) multi thread.
Nov 3 2017, 10:27 AM

Jul 28 2017

fabient accepted D10680: IPSec performance increase in single flow mode by making crypto(9) multi thread.

I'm planning to commit the dev on behalf of emeric 08/21, please make any comments before. :)

Jul 28 2017, 8:31 AM

Jul 3 2017

fabient added inline comments to D10680: IPSec performance increase in single flow mode by making crypto(9) multi thread.
Jul 3 2017, 4:19 PM

Mar 14 2017

fabient committed rS315270: Fix arm stack frame walking support:.
Fix arm stack frame walking support:
Mar 14 2017, 4:07 PM
fabient closed D7396: HWPMC: Fix clang stack frame parsing by committing rS315270: Fix arm stack frame walking support:.
Mar 14 2017, 4:07 PM

Feb 23 2017

fabient added a comment to D7396: HWPMC: Fix clang stack frame parsing.

Any news on the review ?

Feb 23 2017, 4:36 PM

Jan 31 2017

fabient added a comment to D7396: HWPMC: Fix clang stack frame parsing.

Any news on the review ?

Jan 31 2017, 1:53 PM
fabient added a comment to D9246: hwpmc module log with full path.

Le 27 janv. 2017 à 20:05, jhb (John Baldwin) <phabric-noreply@FreeBSD.org> a écrit :
jhb added inline comments.
INLINE COMMENTS

fabient wrote in link_elf_obj.c:561
Do you mean it is better to resolve filename at upper level even if we need to open file again ?

So do you have a use case where the filename isn't already the full path? linker_load_module() in kern_linker.c already passes the pathname (not the basename) to this function.

Jan 31 2017, 8:58 AM

Jan 25 2017

fabient added inline comments to D9246: hwpmc module log with full path.
Jan 25 2017, 9:53 AM

Jan 20 2017

fabient updated the diff for D7396: HWPMC: Fix clang stack frame parsing.

Correctly generated from head.
Added a fix support callchains for software events.

Jan 20 2017, 10:09 AM

Jan 19 2017

fabient retitled D9246: hwpmc module log with full path from to hwpmc module log with full path.
Jan 19 2017, 5:46 PM

Jan 4 2017

fabient committed rS311289: MFC r308216:.
MFC r308216:
Jan 4 2017, 4:37 PM

Nov 25 2016

fabient committed rS309146: Update r309143 to prevent false sharing..
Update r309143 to prevent false sharing.
Nov 25 2016, 5:20 PM
fabient committed rS309144: IPsec RFC6479 support for replay window sizes up to 2^32 - 32 packets..
IPsec RFC6479 support for replay window sizes up to 2^32 - 32 packets.
Nov 25 2016, 2:45 PM
fabient closed D8468: IPSec: support for large replay windows by committing rS309144: IPsec RFC6479 support for replay window sizes up to 2^32 - 32 packets..
Nov 25 2016, 2:45 PM
fabient committed rS309143: In a dual processor system (2*6 cores) during IPSec throughput tests,.
In a dual processor system (2*6 cores) during IPSec throughput tests,
Nov 25 2016, 1:49 PM
fabient closed D8130: Split arc4random mutexes to improve performance on IPSec traffic by committing rS309143: In a dual processor system (2*6 cores) during IPSec throughput tests,.
Nov 25 2016, 1:49 PM · Core Team

Nov 2 2016

fabient committed rS308216: In rtadvd, interface lookup calls if_indextoname() many times in a loop,.
In rtadvd, interface lookup calls if_indextoname() many times in a loop,
Nov 2 2016, 3:11 PM
fabient closed D6979: [usr.sbin/rtadvd] optimize and secure interface lookup by committing rS308216: In rtadvd, interface lookup calls if_indextoname() many times in a loop,.
Nov 2 2016, 3:11 PM · network

Aug 3 2016

fabient added a comment to D7396: HWPMC: Fix clang stack frame parsing.

We should be using the EABI unwinding function. The location of any given register on the EABI stack is compiler specific so we shouldn't hard code it.

Aug 3 2016, 8:24 AM

Aug 2 2016

fabient added reviewers for D7396: HWPMC: Fix clang stack frame parsing: gnn, imp, andrew, ian.
Aug 2 2016, 4:16 PM
fabient retitled D7396: HWPMC: Fix clang stack frame parsing from to HWPMC: Fix clang stack frame parsing.
Aug 2 2016, 4:14 PM

Dec 2 2015

fabient committed rS291652: MFC r291301:.
MFC r291301:
Dec 2 2015, 5:26 PM

Nov 25 2015

fabient committed rS291301: The r241129 description was wrong that the scenario is possible.
The r241129 description was wrong that the scenario is possible
Nov 25 2015, 2:45 PM

Nov 17 2015

fabient closed D3960: IPsec SP priority support.

Commited as r290982

Nov 17 2015, 2:42 PM
fabient committed rS290982: Implement the sadb_x_policy_priority field as it is done in Linux:.
Implement the sadb_x_policy_priority field as it is done in Linux:
Nov 17 2015, 2:39 PM

Oct 26 2015

fabient updated the diff for D3960: IPsec SP priority support.

From internal review: Adding missing priority field when notifying acquire to userland.

Oct 26 2015, 3:19 PM

Oct 21 2015

fabient retitled D3960: IPsec SP priority support from to IPsec SP priority support.
Oct 21 2015, 10:23 AM

Oct 15 2015

fabient added a comment to D2970: Undo the increase in sequence number by 1 due to the FIN flag in case of a transient error..

Is there any more comment to fix it ?
lstewart@ do you prefer the no rollback in case of error (will do the same as packet loss) ?
both solution is are better than keeping the code like this.

Oct 15 2015, 3:30 PM
fabient abandoned D3186: Add ichwd TCO version 3 support (Bay Trail / Rangeley...).

commited as r286890

Oct 15 2015, 3:25 PM
fabient closed D2141: Fix ip_id concurrent access.

Commited as r280759

Oct 15 2015, 3:24 PM
fabient closed D3783: Fix r283120.

Commited as r289025

Oct 15 2015, 3:24 PM
fabient closed D3785: Fix handling .debug file instead of .symbols.

commited as r289023

Oct 15 2015, 3:23 PM

Oct 8 2015

fabient committed rS289025: Fix r283120 which use class size larger than 8bits..
Fix r283120 which use class size larger than 8bits.
Oct 8 2015, 10:01 AM
fabient committed rS289024: Fix r283998 that broke mapin events for hwpmc..
Fix r283998 that broke mapin events for hwpmc.
Oct 8 2015, 9:54 AM
fabient committed rS289023: Fix for r288176 changes related to debug symbols move..
Fix for r288176 changes related to debug symbols move.
Oct 8 2015, 9:46 AM

Oct 2 2015

fabient added inline comments to D3783: Fix r283120.
Oct 2 2015, 9:11 PM
fabient added a comment to D3783: Fix r283120.
In D3783#78030, @jhb wrote:

I guess we are using non-char types to store these values in other places? Otherwise I imagine the compiler would have complained about storing too-large values. Would be nice if that's the case to find the places that are storing this in a larger value and fix those as well to catch this in the future.

Oct 2 2015, 8:54 PM
fabient updated the diff for D3785: Fix handling .debug file instead of .symbols.

Fix emaste@ comments

Oct 2 2015, 2:32 PM
fabient updated D3785: Fix handling .debug file instead of .symbols.
Oct 2 2015, 1:52 PM
fabient retitled D3785: Fix handling .debug file instead of .symbols from to Fix handling .debug file instead of .symbols.
Oct 2 2015, 1:50 PM
fabient retitled D3783: Fix r283120 from to Fix r283120.
Oct 2 2015, 1:27 PM

Aug 26 2015

fabient added a comment to D2970: Undo the increase in sequence number by 1 due to the FIN flag in case of a transient error..

This change seems inadequate given that we would have set TF_SENTFIN and updated snd_max. I haven't followed through all the implications of not reverting those changes, but if we're going to attempt a state rollback we'd better make sure we get it right. I'm also a bit unclear on some details in the original report given that an RTO would reset snd_nxt to snd_una and get us out of any permanent pickle. I'm not a fan of rollbacks in general as they're fragile. What's the use case where a rollback here matters?

Aug 26 2015, 8:00 AM

Aug 18 2015

fabient committed rS286890: Add ichwd TCO version 3 support (Bay Trail / Rangeley...).
Add ichwd TCO version 3 support (Bay Trail / Rangeley...)
Aug 18 2015, 2:54 PM

Jul 24 2015

fabient added reviewers for D3186: Add ichwd TCO version 3 support (Bay Trail / Rangeley...): imp, jfv, des.
Jul 24 2015, 3:27 PM
fabient retitled D3186: Add ichwd TCO version 3 support (Bay Trail / Rangeley...) from Add TCO version 3 support for the watchdog (Bay Trail / Rangeley...) to Add ichwd TCO version 3 support (Bay Trail / Rangeley...).
Jul 24 2015, 3:26 PM
fabient retitled D3186: Add ichwd TCO version 3 support (Bay Trail / Rangeley...) from to Add TCO version 3 support for the watchdog (Bay Trail / Rangeley...).
Jul 24 2015, 3:25 PM

Mar 26 2015

fabient added a comment to D2141: Fix ip_id concurrent access.

() added before commit

Mar 26 2015, 8:56 AM

Mar 25 2015

fabient retitled D2141: Fix ip_id concurrent access from to Fix ip_id concurrent access.
Mar 25 2015, 5:21 PM