Page MenuHomeFreeBSD

Add ichwd TCO version 3 support (Bay Trail / Rangeley...)
AbandonedPublic

Authored by fabient on Jul 24 2015, 3:25 PM.

Details

Reviewers
jfv
imp
des
Summary

Patch from Cas-well to add support for

Test Plan

Tested on Rangeley / Baytrail and on ICH10 for regression.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

fabient retitled this revision from to Add TCO version 3 support for the watchdog (Bay Trail / Rangeley...).
fabient updated this object.
fabient edited the test plan for this revision. (Show Details)
fabient set the repository for this revision to rS FreeBSD src repository - subversion.
fabient retitled this revision from Add TCO version 3 support for the watchdog (Bay Trail / Rangeley...) to Add ichwd TCO version 3 support (Bay Trail / Rangeley...).Jul 24 2015, 3:26 PM
fabient added reviewers: imp, jfv, des.

I think this mostly looks fine. Just have one suggestion.

sys/dev/ichwd/ichwd.c
311

I would actually suggest that you leave the gcs macros with their existing names and add new ones for pmc that have a comment like this:

/* NB: TCO version 3 devices use the gcs_reg resource for the PMC register. */
#define ichwd_read_pmc_4(sc, off) \
        bus_read_4((sc)->gcs_res, (off))

And the same for ichwd_write_pmc_4(). I would then use the _gcs macros for TCO 2 devices and the _pmc macros for TCO 3 devices.