Fix ip_id concurrent access
ClosedPublic
Actions

Authored by fabient on Mar 25 2015, 5:21 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 22, 12:42 PM

	Unknown Object (File)
	Mar 4 2023, 12:24 AM

	Unknown Object (File)
	Feb 22 2023, 1:46 AM

	Unknown Object (File)
	Feb 7 2023, 8:47 PM

	Unknown Object (File)
	Jan 4 2023, 7:00 PM

	Unknown Object (File)
	Dec 5 2022, 5:37 PM

	Unknown Object (File)
	Apr 15 2017, 5:07 PM

	Unknown Object (File)
	Nov 20 2016, 8:51 PM

View All 22 Files

Subscribers

None

Details

Reviewers

hselasky
adrian

Summary

On multi cpu systems, we may emit successive packets with the same id.

Test Plan

No performance penalty has been observed on a multi cpu system running IPsec benchmarks at high PPS rates.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

fabient updated this revision to Diff 4409.Mar 25 2015, 5:21 PM

fabient retitled this revision from to Fix ip_id concurrent access.

fabient updated this object.

fabient edited the test plan for this revision. (Show Details)

fabient added reviewers: adrian, hselasky.

hselasky accepted this revision.Mar 25 2015, 10:02 PM

hselasky edited edge metadata.

hselasky added inline comments.

netinet/ip_var.h
317	Looks good. Maybe put a pair of ()'s around the return argument due to FreeBSD style.

This revision is now accepted and ready to land.Mar 25 2015, 10:02 PM

Looks fine as a first stage fix. Thanks!

() added before commit

Also uint32_t and uint16_t is more common than u_int32_t and u_int16_t .

Commited as r280759

Revision Contents
Changeset List

Path

Size

netinet/

ip_output.c

2 lines

ip_var.h

16 lines

Diff 4409

View Options

netinet/ip_output.c