Page MenuHomeFreeBSD

Fix ip_id concurrent access
ClosedPublic

Authored by fabient on Mar 25 2015, 5:21 PM.

Details

Reviewers
hselasky
adrian
Summary

On multi cpu systems, we may emit successive packets with the same id.

Test Plan

No performance penalty has been observed on a multi cpu system running IPsec benchmarks at high PPS rates.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

fabient retitled this revision from to Fix ip_id concurrent access.
fabient updated this object.
fabient edited the test plan for this revision. (Show Details)
fabient added reviewers: adrian, hselasky.
hselasky edited edge metadata.
hselasky added inline comments.
netinet/ip_var.h
317

Looks good. Maybe put a pair of ()'s around the return argument due to FreeBSD style.

This revision is now accepted and ready to land.Mar 25 2015, 10:02 PM
adrian edited edge metadata.

Looks fine as a first stage fix. Thanks!

Also uint32_t and uint16_t is more common than u_int32_t and u_int16_t .