Page MenuHomeFreeBSD
Differential D2141

Fix ip_id concurrent access
ClosedPublic
Actions

Authored by fabient on Mar 25 2015, 5:21 PM.
Tags
None
Referenced Files
F125012986: D2141.diff
Sat, Aug 2, 9:55 AM
Unknown Object (File)
Jun 20 2025, 9:35 PM
Unknown Object (File)
Jun 13 2025, 6:17 AM
Unknown Object (File)
Jun 12 2025, 9:00 PM
Unknown Object (File)
Jun 12 2025, 6:17 AM
Unknown Object (File)
May 30 2025, 4:38 PM
Unknown Object (File)
May 15 2025, 11:14 PM
Unknown Object (File)
May 12 2025, 11:12 PM
View All 91 Files
Subscribers
None

Details

Reviewers
• hselasky
adrian
Summary

On multi cpu systems, we may emit successive packets with the same id.

Test Plan

No performance penalty has been observed on a multi cpu system running IPsec benchmarks at high PPS rates.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

fabient updated this revision to Diff 4409.Mar 25 2015, 5:21 PM
fabient retitled this revision from to Fix ip_id concurrent access.
fabient updated this object.
fabient edited the test plan for this revision. (Show Details)
fabient added reviewers: adrian, • hselasky.
• hselasky accepted this revision.Mar 25 2015, 10:02 PM
• hselasky edited edge metadata.
• hselasky added inline comments.
netinet/ip_var.h
317

Looks good. Maybe put a pair of ()'s around the return argument due to FreeBSD style.

This revision is now accepted and ready to land.Mar 25 2015, 10:02 PM
adrian accepted this revision.Mar 26 2015, 2:17 AM
adrian edited edge metadata.

Looks fine as a first stage fix. Thanks!

fabient added a comment.Mar 26 2015, 8:56 AM

() added before commit

• hselasky added a comment.Mar 26 2015, 9:03 AM

Also uint32_t and uint16_t is more common than u_int32_t and u_int16_t .

fabient closed this revision.Oct 15 2015, 3:24 PM

Commited as r280759

Revision Contents
Changeset List

PathSize
netinet/
2 lines
16 lines

Diff 4409

View Options

netinet/ip_output.c

Loading...
View Options

netinet/ip_var.h

Loading...