Fix ip_id concurrent access
ClosedPublic
Actions

Authored by fabient on Mar 25 2015, 5:21 PM.

Tags

None

Referenced Files

	F168260740: D2141.id4409.diff
	Thu, Aug 27, 6:02 AM

	F168234541: D2141.diff
	Thu, Aug 27, 2:25 AM

	Unknown Object (File)
	Tue, Aug 25, 7:55 PM

	Unknown Object (File)
	Tue, Aug 25, 5:20 AM

	Unknown Object (File)
	Tue, Aug 25, 12:46 AM

	Unknown Object (File)
	Thu, Aug 20, 12:11 AM

	Unknown Object (File)
	Tue, Aug 18, 6:16 PM

	Unknown Object (File)
	Sun, Aug 9, 5:39 PM

View All Files

Subscribers

None

Details

Reviewers

• hselasky
adrian

Summary

On multi cpu systems, we may emit successive packets with the same id.

Test Plan

No performance penalty has been observed on a multi cpu system running IPsec benchmarks at high PPS rates.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

fabient updated this revision to Diff 4409.Mar 25 2015, 5:21 PM

fabient retitled this revision from to Fix ip_id concurrent access.

fabient updated this object.

fabient edited the test plan for this revision. (Show Details)

fabient added reviewers: adrian, • hselasky.

• hselasky accepted this revision.Mar 25 2015, 10:02 PM

• hselasky edited edge metadata.

• hselasky added inline comments.

netinet/ip_var.h
317	Looks good. Maybe put a pair of ()'s around the return argument due to FreeBSD style.

This revision is now accepted and ready to land.Mar 25 2015, 10:02 PM

Looks fine as a first stage fix. Thanks!

() added before commit

Also uint32_t and uint16_t is more common than u_int32_t and u_int16_t .

Commited as r280759

Revision Contents
Changeset List

Path

Size

netinet/

ip_output.c

2 lines

ip_var.h

16 lines

Diff 4409

View Options

netinet/ip_output.c