Page MenuHomeFreeBSD
Differential D6979

[usr.sbin/rtadvd] optimize and secure interface lookup
ClosedPublic
Actions

Authored by maryse.levavasseur_stormshield.eu on Jun 27 2016, 8:47 AM.
Tags
Referenced Files
Unknown Object (File)
Thu, Apr 18, 5:11 PM
Unknown Object (File)
Fri, Apr 5, 8:21 PM
Unknown Object (File)
Fri, Apr 5, 3:28 PM
Unknown Object (File)
Mar 12 2024, 6:43 PM
Unknown Object (File)
Mar 12 2024, 6:43 PM
Unknown Object (File)
Mar 12 2024, 4:00 PM
Unknown Object (File)
Mar 8 2024, 1:09 PM
Unknown Object (File)
Mar 8 2024, 1:09 PM
View All 53 Files
Subscribers
fabient
imp

Details

Reviewers
cem
truckman
Commits
rS308216: In rtadvd, interface lookup calls if_indextoname() many times in a loop,
Summary

In rtadvd, interface lookup calls if_indextoname() many times in a loop,
(it takes a long time on systems with many interfaces)
without reason and without checking its return value.

This is fixed by this patch.

Test Plan

Our automated tests show no regression.
This patch is already included in Stormshield Network products.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

maryse.levavasseur_stormshield.eu updated this revision to Diff 17916.Jun 27 2016, 8:47 AM
maryse.levavasseur_stormshield.eu retitled this revision from to [usr.sbin/rtadvd] optimize and secure interface lookup.
maryse.levavasseur_stormshield.eu updated this object.
maryse.levavasseur_stormshield.eu edited the test plan for this revision. (Show Details)
maryse.levavasseur_stormshield.eu added reviewers: truckman, cem.
maryse.levavasseur_stormshield.eu set the repository for this revision to rS FreeBSD src repository - subversion.
maryse.levavasseur_stormshield.eu added a project: network.
maryse.levavasseur_stormshield.eu added a subscriber: fabient.
Herald added a subscriber: imp. · View Herald TranscriptJun 27 2016, 8:47 AM
cem edited edge metadata.Jun 28 2016, 5:21 AM

Please upload diffs with full context (-U99999).

maryse.levavasseur_stormshield.eu updated this revision to Diff 17963.Jun 28 2016, 8:35 AM
maryse.levavasseur_stormshield.eu edited edge metadata.

diff with full context

cem accepted this revision.Jun 29 2016, 4:24 AM
cem edited edge metadata.
cem added inline comments.
usr.sbin/rtadvd/if.c
497 ↗(On Diff #17963)

This check was completely bogus, ugh. ifi_ifname is an array.

This revision is now accepted and ready to land.Jun 29 2016, 4:24 AM
Closed by commit rS308216: In rtadvd, interface lookup calls if_indextoname() many times in a loop, (authored by fabient). · Explain WhyNov 2 2016, 3:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
usr.sbin/
rtadvd/
19 lines

Diff 21946

View Options

head/usr.sbin/rtadvd/if.c

Loading...