Page MenuHomeFreeBSD

Fix handling .debug file instead of .symbols
ClosedPublic

Authored by fabient on Oct 2 2015, 1:50 PM.

Details

Summary

Look at new location first AND old location in case user like it.

There is another separate fix from Kai to handle addr2line pipe without leak.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

fabient retitled this revision from to Fix handling .debug file instead of .symbols.
fabient updated this object.
fabient edited the test plan for this revision. (Show Details)
fabient added reviewers: gnn, emaste, jhb, davide.
fabient set the repository for this revision to rS FreeBSD src repository - subversion.
usr.sbin/pmcstat/pmcstat_log.c
979

It should still use pi_fullpath -- the scheme is that debug data is stored in the same path under /usr/lib/debug/. So for example /boot/test-kernel/ will have debug data in /usr/lib/debug/boot/test-kernel/

997

whitespace change?

1024

remove this before checkin :)

emaste edited edge metadata.

Looks good to me with minor style(9) nits

usr.sbin/pmcstat/pmcstat_log.c
975

style(9) on the comment:
/* Try default debug file location. */

983

style(9)

This revision is now accepted and ready to land.Oct 2 2015, 3:00 PM

I believe this is now committed?

commited as r289023

usr.sbin/pmcstat/pmcstat_log.c
979

Good catch. :)