Fix handling .debug file instead of .symbols
ClosedPublic
Actions

Authored by fabient on Oct 2 2015, 1:50 PM.

Details

Reviewers

emaste
davide
jhb
gnn

Summary

Look at new location first AND old location in case user like it.

There is another separate fix from Kai to handle addr2line pipe without leak.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

fabient updated this revision to Diff 9054.Oct 2 2015, 1:50 PM

fabient retitled this revision from to Fix handling .debug file instead of .symbols.

fabient updated this object.

fabient edited the test plan for this revision. (Show Details)

fabient added reviewers: gnn, emaste, jhb, davide.

fabient set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptOct 2 2015, 1:50 PM

fabient updated this object.Oct 2 2015, 1:52 PM

emaste added inline comments.Oct 2 2015, 2:05 PM

usr.sbin/pmcstat/pmcstat_log.c
979	It should still use pi_fullpath -- the scheme is that debug data is stored in the same path under `/usr/lib/debug/`. So for example `/boot/test-kernel/` will have debug data in `/usr/lib/debug/boot/test-kernel/`
997	whitespace change?
1024	remove this before checkin :)

Fix emaste@ comments

Looks good to me with minor style(9) nits

usr.sbin/pmcstat/pmcstat_log.c
975	style(9) on the comment: `/* Try default debug file location. */`
983	style(9)

This revision is now accepted and ready to land.Oct 2 2015, 3:00 PM

I believe this is now committed?

commited as r289023

usr.sbin/pmcstat/pmcstat_log.c
979	Good catch. :)

Revision Contents
Changeset List

Path

Size

usr.sbin/

pmcstat/

pmcstat_log.c

26 lines

Diff 9054

View Options

usr.sbin/pmcstat/pmcstat_log.c

Fix handling .debug file instead of .symbolsClosedPublicActions