Page MenuHomeFreeBSD

davide (Davide Italiano)
User

Projects

User Details

User Since
Jun 5 2014, 2:54 AM (279 w, 4 d)

Recent Activity

May 5 2016

davide added a comment to D6164: Make this code position independent.

@delphij , @cperciva (or anybody else from security) can you please sign-off this one before it gets in?

May 5 2016, 4:55 PM

Apr 30 2016

davide added a reviewer for D6164: Make this code position independent: delphij.
Apr 30 2016, 10:39 PM
davide accepted D6164: Make this code position independent.
Apr 30 2016, 10:39 PM
davide added a comment to D6164: Make this code position independent.

LGTM. Colin?

Apr 30 2016, 10:39 PM

Jan 5 2016

davide accepted D4790: Switch GNU ld to be installed as ld.bfd and linked as ld.

looks good to me (in principle), and I like this approach. I'm not build system savvy so I'd like dim to sign-off this one.

Jan 5 2016, 1:25 AM

Nov 30 2015

davide added a comment to D4292: decouple maximum clock frequency from callout scheduling granularity.

The changes look good. I'd split them in multiple patches/commit, more or less following the structure you outlined in the summary, but thanks for sending out a single one so we can have the whole picture.
IIRC there were objections to change ticks from 32-bits to 64-bits so you may want to ask feedback from a more general audience.
Other than that, I'm fine with (a splitted version of this) getting in.

Nov 30 2015, 12:13 AM · transport

May 19 2015

davide accepted D2586: Use fixed enum values for PMC_CLASSES()..

Sounds sensible.

May 19 2015, 5:21 PM

May 13 2015

davide added a comment to D2534: Update GDB to handle 0x93 (DW_OP_piece) instead of emitting errors..

Can't comment on license issues and related tho.

May 13 2015, 3:55 PM
davide accepted D2534: Update GDB to handle 0x93 (DW_OP_piece) instead of emitting errors..

LGTM. Feel free to ship (maybe John wants to comment further as he's been touching gdb recently)

May 13 2015, 3:54 PM

May 8 2015

davide accepted D2487: Convert hwpmc(4) debug printfs over to KTR..
May 8 2015, 4:42 PM
davide added a comment to D2487: Convert hwpmc(4) debug printfs over to KTR..

The patch looks very good to me and thanks for undertaking this effort.
About SDT I don't disagree with them but *exclusively* seems a little bit too much, lots of people rely on KTR for tracing (me included) and it seems to be a more lighweight solution than Dtrace if you need limited capabilities.

May 8 2015, 4:42 PM

Feb 14 2015

davide closed D1805: [sockbuf] Don't access fields directly, use accessor functions.

In HEAD now.

Feb 14 2015, 8:01 PM

Feb 11 2015

davide added inline comments to D1809: [sockbuf] Don't expose lock details when isn't needed.
Feb 11 2015, 8:55 AM
davide added a comment to D1809: [sockbuf] Don't expose lock details when isn't needed.

Robert,
an added (somewhat related) note.
SCTP has already its own sockbuf(s) and this makes integration very hackish in the tree. IIRC glebius experienced this himself while working on sendfile(), and I'm pretty sure rrs@ is kind of familiar with the problem. Introducing a better abstraction for sockbuf might help with this.

Feb 11 2015, 8:54 AM
davide added a comment to D1809: [sockbuf] Don't expose lock details when isn't needed.

Mainly for consistency at this point with whatever else it's used in the stack.

Feb 11 2015, 8:22 AM
davide added a comment to D1805: [sockbuf] Don't access fields directly, use accessor functions.

I plan to commit this in two days or such, so if there are objections, please raise them.

Feb 11 2015, 5:50 AM
davide added a comment to D1809: [sockbuf] Don't expose lock details when isn't needed.

I plan to commit this in two days or such, so if there are objections, please raise them.

Feb 11 2015, 5:50 AM

Feb 9 2015

davide retitled D1809: [sockbuf] Don't expose lock details when isn't needed from to [sockbuf] Don't expose lock details when isn't needed.
Feb 9 2015, 2:34 AM
davide updated the diff for D1805: [sockbuf] Don't access fields directly, use accessor functions.

Updated removing the last place where this was used. I was not certain about it before so I previously left it as-is, but it looks like in this case order doesn't matter considering we're holding the socket buffer lock across the two calls.

Feb 9 2015, 12:04 AM

Feb 8 2015

davide updated the diff for D1805: [sockbuf] Don't access fields directly, use accessor functions.
Feb 8 2015, 10:26 PM
davide retitled D1805: [sockbuf] Don't access fields directly, use accessor functions from to [sockbuf] Don't access fields directly, use accessor functions.
Feb 8 2015, 10:24 PM

Nov 27 2014

davide abandoned D1238: Pre-Allocate pty devices in mod_event handler rather than using dev_clone.

Drop this revision after discussion on the mailing list.

Nov 27 2014, 8:43 PM
davide retitled D1238: Pre-Allocate pty devices in mod_event handler rather than using dev_clone from to Pre-Allocate pty devices in mod_event handler rather than using dev_clone.
Nov 27 2014, 12:40 AM
davide abandoned D659: Remove pty(4).

Abandoned in favour of a different approach

Nov 27 2014, 12:34 AM

Nov 14 2014

davide accepted D1157: Prevent overflow issues in timeout processing.
Nov 14 2014, 11:48 PM
davide added a comment to D1157: Prevent overflow issues in timeout processing.

This looks good to me modulo mav's last round of comments.

Nov 14 2014, 11:47 PM

Oct 21 2014

davide accepted D981: Coverity CID 1248848 - Leaked Storage Variable..
Oct 21 2014, 12:47 PM
davide added a comment to D981: Coverity CID 1248848 - Leaked Storage Variable..

LGTM

Oct 21 2014, 12:46 PM

Oct 17 2014

davide added a comment to D962: Update getenv(9) manpage to reflect the new world order.

unsetenv is not used anywhere in the kernel -- just in the loader. As you may see the loader code was unchanged.
Do you have an alternative to handle the whole thing in your mind?

Oct 17 2014, 6:54 PM
davide retitled D962: Update getenv(9) manpage to reflect the new world order from to Update getenv(9) manpage to reflect the new world order.
Oct 17 2014, 5:42 PM

Aug 20 2014

davide retitled D659: Remove pty(4) from to Remove pty(4).
Aug 20 2014, 5:47 PM
davide closed D434: Remove the LL abomination.

Committed (r270227)

Aug 20 2014, 5:31 PM
davide closed D441: Replace dev_clone with cdevpriv(9) in audit_pipe.

Committed (r270221)

Aug 20 2014, 4:05 PM
davide accepted D434: Remove the LL abomination.

bde@ accepted this revision privately.

Aug 20 2014, 3:52 PM
davide added a comment to D434: Remove the LL abomination.

Bruce Evans reviewed this privately.
Let's copy his comment here:

Aug 20 2014, 3:38 PM
davide closed D433: Fix getsockopt() timeout..
Aug 20 2014, 3:37 PM
davide accepted D433: Fix getsockopt() timeout..

committed

Aug 20 2014, 3:37 PM

Aug 12 2014

davide updated the diff for D441: Replace dev_clone with cdevpriv(9) in audit_pipe.

Updated after comments from Kostik/Robert.
Peter, do you mind to give this a spin before it gets in? I tested that a bit and found no issue -- but it would be great if the patch could be stress tested a bit more.

Aug 12 2014, 11:15 AM

Jul 21 2014

davide updated the diff for D441: Replace dev_clone with cdevpriv(9) in audit_pipe.
Jul 21 2014, 11:38 PM

Jul 19 2014

davide retitled D441: Replace dev_clone with cdevpriv(9) in audit_pipe from to Replace dev_clone with cdevpriv(9) in audit_pipe.
Jul 19 2014, 12:54 AM

Jul 18 2014

davide added a reviewer for D434: Remove the LL abomination: mav.
Jul 18 2014, 8:19 PM
davide added a reviewer for D433: Fix getsockopt() timeout.: adrian.
Jul 18 2014, 8:18 PM
davide added a reviewer for D433: Fix getsockopt() timeout.: jhb.
Jul 18 2014, 5:02 AM

Jul 17 2014

davide retitled D434: Remove the LL abomination from to Remove the LL abomination.
Jul 17 2014, 11:20 PM
davide retitled D433: Fix getsockopt() timeout. from to Fix getsockopt() timeout..
Jul 17 2014, 11:16 PM
davide edited P13 uipc socket fix.
Jul 17 2014, 3:56 AM