Page MenuHomeFreeBSD

Update GDB to handle 0x93 (DW_OP_piece) instead of emitting errors.
ClosedPublic

Authored by sbruno on May 13 2015, 2:53 PM.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sbruno updated this revision to Diff 5363.May 13 2015, 2:53 PM
sbruno retitled this revision from to Update GDB to handle 0x93 (DW_OP_piece) instead of emitting errors..
sbruno updated this object.
sbruno edited the test plan for this revision. (Show Details)
sbruno added reviewers: emaste, davide, jhb.
sbruno added a subscriber: peter.
emaste edited edge metadata.May 13 2015, 3:12 PM

For reference the switch to GPLv3 happened here:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;f=gdb/dwarf2loc.c;h=ec2655a6a75bc61d21e6f8ddc1e9f9027a8914dd

commit ec2655a6a75bc61d21e6f8ddc1e9f9027a8914dd
Author: Nick Clifton <nickc@redhat.com>
Date:   Tue Jul 3 11:01:12 2007 +0000

    Switch to GPLv3
In D2534#46786, @emaste wrote:

For reference the switch to GPLv3 happened here:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;f=gdb/dwarf2loc.c;h=ec2655a6a75bc61d21e6f8ddc1e9f9027a8914dd

commit ec2655a6a75bc61d21e6f8ddc1e9f9027a8914dd
Author: Nick Clifton <nickc@redhat.com>
Date:   Tue Jul 3 11:01:12 2007 +0000
    Switch to GPLv3

The newest commit is from "Fri, 18 May 2007 19:42:42 +0000 (19:42 +0000)"

davide accepted this revision.May 13 2015, 3:54 PM
davide edited edge metadata.

LGTM. Feel free to ship (maybe John wants to comment further as he's been touching gdb recently)

This revision is now accepted and ready to land.May 13 2015, 3:54 PM

Can't comment on license issues and related tho.

emaste accepted this revision.May 13 2015, 3:56 PM
emaste edited edge metadata.

Yep, this is fine with me as well. The old gdb 6.1.1 in base has a limited life expectancy, but I have no problem bringing in pre-GPLv3 patches while it remains.

jhb accepted this revision.May 13 2015, 5:02 PM
jhb edited edge metadata.

Agreed.

make universe started on Wed May 13 17:31:06 UTC 2015

I'll hold off until this completes, just because I'm touching things I'm not 100% comfortable with.

This revision was automatically updated to reflect the committed changes.