Convert hwpmc(4) debug printfs over to KTR.
ClosedPublic
Actions

Authored by jhb on May 8 2015, 4:14 PM.

Details

Reviewers

emaste
davide

Commits

rS282658: Convert hwpmc(4) debug printfs over to KTR.

Test Plan

I'm using this for debugging the issues in PR 198149

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb updated this revision to Diff 5287.May 8 2015, 4:14 PM

jhb retitled this revision from to Convert hwpmc(4) debug printfs over to KTR..

jhb updated this object.

jhb edited the test plan for this revision. (Show Details)

jhb added reviewers: emaste, davide.

Herald added subscribers: imp, gnn. · View Herald TranscriptMay 8 2015, 4:14 PM

Please do this as SDTs as well or exclusively. It's fine to remove the printfs, but we really need to move to DTrace as our all around
tracing tool.

Hmm, DTrace is always going to have more overhead than KTR and thus be less well suited for debugging traces and timing issues.

The patch looks very good to me and thanks for undertaking this effort.
About SDT I don't disagree with them but *exclusively* seems a little bit too much, lots of people rely on KTR for tracing (me included) and it seems to be a more lighweight solution than Dtrace if you need limited capabilities.

davide accepted this revision.May 8 2015, 4:42 PM

davide edited edge metadata.

This revision is now accepted and ready to land.May 8 2015, 4:42 PM

emaste accepted this revision.May 8 2015, 5:04 PM

emaste edited edge metadata.

Closed by commit rS282658: Convert hwpmc(4) debug printfs over to KTR. (authored by jhb). · Explain WhyMay 8 2015, 7:40 PM

This revision was automatically updated to reflect the committed changes.