Page MenuHomeFreeBSD

Convert hwpmc(4) debug printfs over to KTR.
ClosedPublic

Authored by jhb on May 8 2015, 4:14 PM.

Details

Test Plan
  • I'm using this for debugging the issues in PR 198149

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

jhb updated this revision to Diff 5287.May 8 2015, 4:14 PM
jhb retitled this revision from to Convert hwpmc(4) debug printfs over to KTR..
jhb updated this object.
jhb edited the test plan for this revision. (Show Details)
jhb added reviewers: emaste, davide.
gnn added a comment.May 8 2015, 4:17 PM

Please do this as SDTs as well or exclusively. It's fine to remove the printfs, but we really need to move to DTrace as our all around
tracing tool.

jhb added a comment.May 8 2015, 4:41 PM

Hmm, DTrace is always going to have more overhead than KTR and thus be less well suited for debugging traces and timing issues.

davide edited edge metadata.May 8 2015, 4:42 PM

The patch looks very good to me and thanks for undertaking this effort.
About SDT I don't disagree with them but *exclusively* seems a little bit too much, lots of people rely on KTR for tracing (me included) and it seems to be a more lighweight solution than Dtrace if you need limited capabilities.

davide accepted this revision.May 8 2015, 4:42 PM
davide edited edge metadata.
This revision is now accepted and ready to land.May 8 2015, 4:42 PM
emaste accepted this revision.May 8 2015, 5:04 PM
emaste edited edge metadata.
This revision was automatically updated to reflect the committed changes.