Page MenuHomeFreeBSD
Feed Advanced Search

Nov 18 2022

des committed rGcf325fda86ed: tftpd: type nit (authored by des).
tftpd: type nit
Nov 18 2022, 4:28 PM
des closed D37433: tftp: cleanup.
Nov 18 2022, 4:02 PM
des committed rGb9fabe997feb: tftp: cleanup (authored by des).
tftp: cleanup
Nov 18 2022, 4:02 PM
des closed D37423: tftpd: Plug memory leaks in option handling code..
Nov 18 2022, 4:01 PM
des committed rGb15e052e7415: tftpd: Plug memory leaks in option handling code. (authored by des).
tftpd: Plug memory leaks in option handling code.
Nov 18 2022, 4:01 PM
des requested review of D37433: tftp: cleanup.
Nov 18 2022, 3:41 PM
des updated the diff for D37423: tftpd: Plug memory leaks in option handling code..

Separate out the cleanup

Nov 18 2022, 3:28 PM

Nov 17 2022

des updated the diff for D37423: tftpd: Plug memory leaks in option handling code..

type nits

Nov 17 2022, 5:35 PM
des requested review of D37423: tftpd: Plug memory leaks in option handling code..
Nov 17 2022, 4:52 PM
des committed rGbacb00ab408a: tftpd: whitespace cleanup (authored by des).
tftpd: whitespace cleanup
Nov 17 2022, 4:43 PM
des committed rG9f9544fd92e6: tftp: Fix buffer overflow and fd leak in multi-file PUT. (authored by des).
tftp: Fix buffer overflow and fd leak in multi-file PUT.
Nov 17 2022, 4:42 PM
des closed D37422: tftp: Fix buffer overflow and fd leak in multi-file PUT..
Nov 17 2022, 4:41 PM
des added inline comments to D37422: tftp: Fix buffer overflow and fd leak in multi-file PUT..
Nov 17 2022, 4:40 PM
des updated the diff for D37422: tftp: Fix buffer overflow and fd leak in multi-file PUT..

Fix ':' case and leaks

Nov 17 2022, 4:26 PM
des added a comment to D37422: tftp: Fix buffer overflow and fd leak in multi-file PUT..
In D37422#850782, @imp wrote:

So in the case where it doesn't have a ':' in it, we're good. I'm 100% sure there's no way this code is different than the old, other than using freshly allocated memory.

Nov 17 2022, 4:24 PM
des closed D37398: libarchive: Add missing MLINK..
Nov 17 2022, 4:13 PM
des committed rGf1ad5e393199: libarchive: Add missing MLINK. (authored by des).
libarchive: Add missing MLINK.
Nov 17 2022, 4:13 PM
des requested review of D37422: tftp: Fix buffer overflow and fd leak in multi-file PUT..
Nov 17 2022, 3:19 PM

Nov 16 2022

des added a comment to D37319: libc: Disable debugging code in the resolver..

jfyi this is on hold pending discussions with a concerned third party

Nov 16 2022, 5:18 PM

Nov 15 2022

des committed rGeb0292d92974: tftpd: cleanup (authored by des).
tftpd: cleanup
Nov 15 2022, 10:39 PM
des requested review of D37398: libarchive: Add missing MLINK..
Nov 15 2022, 3:52 PM

Nov 14 2022

des committed rG48aa2fa71b2d: libc: Don't warn about RRSIG replies. (authored by des).
libc: Don't warn about RRSIG replies.
Nov 14 2022, 11:24 AM
des committed rGd488e8d0372d: getty: code cleanup, part 1 (authored by des).
getty: code cleanup, part 1
Nov 14 2022, 11:23 AM
des committed rG1854fb8fd8ba: ipfw: Spell PFIL_PASS correctly. (authored by des).
ipfw: Spell PFIL_PASS correctly.
Nov 14 2022, 11:21 AM
des closed D37375: ipfw: Spell PFIL_PASS correctly..
Nov 14 2022, 11:21 AM

Nov 12 2022

des requested review of D37375: ipfw: Spell PFIL_PASS correctly..
Nov 12 2022, 1:22 PM
des updated the diff for D37319: libc: Disable debugging code in the resolver..

comment rather than undef

Nov 12 2022, 1:17 PM
des added inline comments to D37319: libc: Disable debugging code in the resolver..
Nov 12 2022, 1:15 PM

Nov 9 2022

des requested review of D37319: libc: Disable debugging code in the resolver..
Nov 9 2022, 5:51 PM
des committed rG817f1f3064db: libc: Don't warn about RRSIG replies. (authored by des).
libc: Don't warn about RRSIG replies.
Nov 9 2022, 4:42 PM
des closed D37303: libc: Don't warn about RRSIG replies..
Nov 9 2022, 4:42 PM

Nov 7 2022

des added a reviewer for D37303: libc: Don't warn about RRSIG replies.: karels.
Nov 7 2022, 6:05 PM
des updated the diff for D37303: libc: Don't warn about RRSIG replies..

Be more consistent.

Nov 7 2022, 4:33 PM
des requested review of D37303: libc: Don't warn about RRSIG replies..
Nov 7 2022, 4:25 PM

Nov 4 2022

des abandoned D37267: getty: Don't use cfmakesane()..
Nov 4 2022, 3:42 PM
des requested review of D37267: getty: Don't use cfmakesane()..
Nov 4 2022, 3:38 PM
des committed rGeb4d86d529e2: getty: Avoid NULL deref if stdin is not a tty. (authored by des).
getty: Avoid NULL deref if stdin is not a tty.
Nov 4 2022, 3:32 PM
des closed D37265: getty: Avoid NULL deref if stdin is not a tty..
Nov 4 2022, 3:31 PM
des added inline comments to D37265: getty: Avoid NULL deref if stdin is not a tty..
Nov 4 2022, 2:48 PM
des requested review of D37265: getty: Avoid NULL deref if stdin is not a tty..
Nov 4 2022, 2:44 PM
des committed rGf285f41498eb: getty: code cleanup, part 2 (authored by des).
getty: code cleanup, part 2
Nov 4 2022, 2:23 PM
des committed rG8ad7a14ab49b: getty: code cleanup, part 1 (authored by des).
getty: code cleanup, part 1
Nov 4 2022, 2:22 PM
des closed D37263: getty: code cleanup, part 1.
Nov 4 2022, 2:21 PM
des updated the summary of D37263: getty: code cleanup, part 1.
Nov 4 2022, 2:19 PM
des updated the diff for D37263: getty: code cleanup, part 1.

Update commit message

Nov 4 2022, 2:18 PM
des added a reviewer for D37263: getty: code cleanup, part 1: Klara.
Nov 4 2022, 1:33 PM
des requested review of D37263: getty: code cleanup, part 1.
Nov 4 2022, 1:33 PM
des committed rGf9349d427431: gzip: Add support for decompressing zstd files. (authored by des).
gzip: Add support for decompressing zstd files.
Nov 4 2022, 1:02 PM
des closed D37236: gzip: Add support for decompressing zstd files..
Nov 4 2022, 1:02 PM

Nov 2 2022

des edited reviewers for D37236: gzip: Add support for decompressing zstd files., added: Klara; removed: allanjude, kevans, thj.
Nov 2 2022, 5:38 PM
des updated the diff for D37236: gzip: Add support for decompressing zstd files..

Incorporate feedback

Nov 2 2022, 5:29 PM
des committed rG73ab1c87c208: sh: read more profile files. (authored by des).
sh: read more profile files.
Nov 2 2022, 3:51 PM
des updated the diff for D37236: gzip: Add support for decompressing zstd files..

Correct SPDX tag.

Nov 2 2022, 1:57 PM
des requested review of D37236: gzip: Add support for decompressing zstd files..
Nov 2 2022, 1:54 PM
des committed rG4ea49af3afe1: sh: read more profile files. (authored by des).
sh: read more profile files.
Nov 2 2022, 1:43 PM
des committed rG9ba17e2d1c2f: script add -T fmt to print time-stamps (authored by sjg).
script add -T fmt to print time-stamps
Nov 2 2022, 12:37 PM
des committed rG7a254e64bf3d: script: Correct -F in man page and usage string. (authored by des).
script: Correct -F in man page and usage string.
Nov 2 2022, 12:36 PM
des committed rG7302f8697124: w: cosmetic fixes. (authored by des).
w: cosmetic fixes.
Nov 2 2022, 12:36 PM
des committed rGe3a294324944: pax: remove 4.4BSD compatibility (authored by des).
pax: remove 4.4BSD compatibility
Nov 2 2022, 12:36 PM
des committed rGd15dbed0deea: chown: see also chmod. (authored by des).
chown: see also chmod.
Nov 2 2022, 12:36 PM
des committed rG938ff8990d53: renice: support -- as per POSIX. (authored by des).
renice: support -- as per POSIX.
Nov 2 2022, 12:36 PM
des committed rG1b9c55cf9a3a: apply: clean up error handling. (authored by des).
apply: clean up error handling.
Nov 2 2022, 12:36 PM
des committed rG0ed86bcc0b2a: xinstall: fix dounpriv logic, add tests (authored by des).
xinstall: fix dounpriv logic, add tests
Nov 2 2022, 12:36 PM
des committed rG540add272df6: sh: read more profile files. (authored by des).
sh: read more profile files.
Nov 2 2022, 9:32 AM

Oct 27 2022

des closed D37182: script: Handle a missing 's' stamp gracefully..
Oct 27 2022, 8:12 PM
des committed rG473e9fcab4ea: script: Handle a missing 's' stamp gracefully. (authored by des).
script: Handle a missing 's' stamp gracefully.
Oct 27 2022, 8:12 PM
des requested review of D37182: script: Handle a missing 's' stamp gracefully..
Oct 27 2022, 8:09 PM
des committed rG6ac087cf8ff4: script: Further usage string nits. (authored by des).
script: Further usage string nits.
Oct 27 2022, 8:05 PM
des closed D37177: script: Use size_t / ssize_t where needed. script: Further usage string nits..
Oct 27 2022, 8:05 PM
des committed rG3276866f40ca: script: Use size_t / ssize_t where needed. (authored by des).
script: Use size_t / ssize_t where needed.
Oct 27 2022, 8:05 PM
des requested review of D37177: script: Use size_t / ssize_t where needed. script: Further usage string nits..
Oct 27 2022, 3:38 PM
des committed rG8e096e24d434: script: Correct -F in man page and usage string. (authored by des).
script: Correct -F in man page and usage string.
Oct 27 2022, 2:47 PM
des committed rGe7c13cf4383d: script: Add usage string for playback mode. (authored by des).
script: Add usage string for playback mode.
Oct 27 2022, 2:47 PM
des closed D37138: script: Correct -F in man page and usage string. Sponsored by: Klara, Inc. MFC after: 1 week script: Add usage string for playback mode. Sponsored by: Klara, Inc..
Oct 27 2022, 2:46 PM

Oct 26 2022

des added a comment to D37138: script: Correct -F in man page and usage string. Sponsored by: Klara, Inc. MFC after: 1 week script: Add usage string for playback mode. Sponsored by: Klara, Inc..

Phabricator made a mess of the summary... this will be two separate commits (one for -F and one for -p).

Oct 26 2022, 6:16 PM
des requested review of D37138: script: Correct -F in man page and usage string. Sponsored by: Klara, Inc. MFC after: 1 week script: Add usage string for playback mode. Sponsored by: Klara, Inc..
Oct 26 2022, 6:14 PM
des committed rGdeb2f1b616f1: w: Fix premature rounding. (authored by des).
w: Fix premature rounding.
Oct 26 2022, 3:57 PM
des closed D37128: w: Fix premature rounding..
Oct 26 2022, 3:57 PM

Oct 25 2022

des requested review of D37128: w: Fix premature rounding..
Oct 25 2022, 10:42 PM

Oct 22 2022

des closed D37034: sh: when loading profile, read only .sh files..
Oct 22 2022, 5:06 PM
des committed rG8d7221ca2dd5: sh: when loading profile, read only .sh files. (authored by des).
sh: when loading profile, read only .sh files.
Oct 22 2022, 5:06 PM

Oct 21 2022

des committed rG04f6b9cb1822: w: cosmetic fixes. (authored by des).
w: cosmetic fixes.
Oct 21 2022, 4:40 PM

Oct 19 2022

des committed rGd05e43bc0d57: pax: update date parsing code (from OpenBSD) (authored by des).
pax: update date parsing code (from OpenBSD)
Oct 19 2022, 5:04 PM

Oct 18 2022

des added a comment to D37034: sh: when loading profile, read only .sh files..

cf. https://bugs.freebsd.org/266913

Oct 18 2022, 1:37 PM
des updated the diff for D37034: sh: when loading profile, read only .sh files..

fix comment

Oct 18 2022, 1:32 PM
des requested review of D37034: sh: when loading profile, read only .sh files..
Oct 18 2022, 1:30 PM

Oct 13 2022

des accepted D36930: renice: fix renice_abs_user and renice_rel_user if root user configured with other shell as sh.
Oct 13 2022, 1:48 PM

Oct 3 2022

des committed rGd3890a547d20: sh: when loading profile, skip obvious scratch files. (authored by des).
sh: when loading profile, skip obvious scratch files.
Oct 3 2022, 2:36 PM
des closed D36856: sh: when loading profile, skip obvious scratch files..
Oct 3 2022, 2:36 PM

Oct 2 2022

des added inline comments to D36856: sh: when loading profile, skip obvious scratch files..
Oct 2 2022, 2:13 PM
des closed D36592: Put OPIE to rest..
Oct 2 2022, 12:48 PM
des added a comment to D36720: tests/usr.bin/renice: Prevent running them in parallel.

Are these tests fundamentally incompatible with parallel execution?

Oct 2 2022, 12:46 PM
des added a comment to D36824: libfetch: Use memcpy in place of an odd strncpy..

Looks like a job for strlcpy()...

Oct 2 2022, 12:41 PM
des added a reviewer for D36825: libfetch: Pass a zeroed digest to DigestCalcResponse.: grembo.

This is @grembo's code.

Oct 2 2022, 12:39 PM
des accepted D36854: Remove OPIE documentation.
Oct 2 2022, 12:36 PM
des updated the diff for D36856: sh: when loading profile, skip obvious scratch files..

consistent quoting

Oct 2 2022, 12:26 PM
des requested review of D36856: sh: when loading profile, skip obvious scratch files..
Oct 2 2022, 12:24 PM
des committed rG0aa2700123e2: Put OPIE to rest. (authored by des).
Put OPIE to rest.
Oct 2 2022, 1:38 AM
des updated the diff for D36592: Put OPIE to rest..

rebase, remove opielocks, fix whitespace nit

Oct 2 2022, 12:48 AM

Oct 1 2022

des committed rG497cdf9673ec: sh: read more profile files. (authored by des).
sh: read more profile files.
Oct 1 2022, 9:32 PM