Paths

Table of Contentst

getty: Avoid NULL deref if stdin is not a tty.
ClosedPublic
Actions

Authored by des on Nov 4 2022, 2:44 PM.

Tags

None

Referenced Files

	F172475915: D37265.diff
	Fri, Sep 18, 6:00 PM

	Unknown Object (File)
	Wed, Sep 16, 2:42 PM

	Unknown Object (File)
	Sat, Sep 12, 1:40 AM

	Unknown Object (File)
	Fri, Sep 11, 1:08 AM

	Unknown Object (File)
	Tue, Sep 8, 10:20 PM

	Unknown Object (File)
	Sun, Sep 6, 3:43 AM

	Unknown Object (File)
	Sat, Sep 5, 3:17 PM

	Unknown Object (File)
	Sat, Sep 5, 1:10 PM

View All Files

Subscribers

allanjude

imp

Details

Reviewers

allanjude

Group Reviewers

Klara

Commits

rGeb4d86d529e2: getty: Avoid NULL deref if stdin is not a tty.

Summary

Sponsored by: Klara, Inc.
Obtained from: Apple OSS Distributions

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Nov 4 2022, 2:44 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 4 2022, 2:44 PM

des requested review of this revision.Nov 4 2022, 2:44 PM

Harbormaster completed remote builds in B48148: Diff 112607.Nov 4 2022, 2:44 PM

allanjude added a subscriber: allanjude.Nov 4 2022, 2:46 PM

allanjude added inline comments.

libexec/getty/main.c
218	doesn't this need a parameter for the %m?

des added inline comments.Nov 4 2022, 2:48 PM

libexec/getty/main.c
218	No, `%m` means “insert `strerror(errno)` here”.

Reviewed by: allanjude

This revision is now accepted and ready to land.Nov 4 2022, 3:31 PM

Closed by commit rGeb4d86d529e2: getty: Avoid NULL deref if stdin is not a tty. (authored by des). · Explain WhyNov 4 2022, 3:31 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGeb4d86d529e2: getty: Avoid NULL deref if stdin is not a tty..

des mentioned this in rGd488e8d0372d: getty: code cleanup, part 1.Nov 14 2022, 11:23 AM

Revision Contents
Changeset List

Path

Size

libexec/

getty/

main.c

11 lines

Diff 112611

View Options

getty: Avoid NULL deref if stdin is not a tty.ClosedPublicActions