libc: Disable debugging code in the resolver.

[karels]

My main question is whether the DEBUG definitions should just be deleted, or whether it is worth leaving bread crumbs for where it used to be defined.

lib/libc/net/res_config.h

3

Shouldn't this just be deleted rather than doing #undef? If the user defines DEBUG then includes headers, or defines DEBUG on the command line, I think it should be honored,

lib/libc/resolv/res_mkquery.c

87

I wonder whether the previous two lines should just be deleted (similarly elsewhere).

[des]

lib/libc/net/res_config.h

3

I was following the established idiom, cf. SUNSECURITY below.

lib/libc/resolv/res_mkquery.c

87

One might ask why these don't just #include "res_config.h", cf. res_init.c which also redefines RESOLVSORT.

[des]

comment rather than undef

[karels]

lib/libc/net/res_config.h

3

I'm not sure the two cases are analogous. If I understand correctly, there is no reason to enable SUNSECURITY at all. However, DEBUG might reasonably enabled for debugging, etc. It makes the debug option to the resolver actually do something.

btw, why did you remove the comment on SUNSECURITY? I wouldn't change that line at all.

lib/libc/resolv/res_mkquery.c

87

True, but the comment no longer makes sense.

[des]

jfyi this is on hold pending discussions with a concerned third party