In D30769#697756, @eduardo wrote:

Should I abandon this review since maintainer reset was done?

https://cgit.freebsd.org/ports/commit/?id=707989ed0f7c83660cfb8213641054207a3de529

@grembo Patch is not applying after latest changes on git port. Could you please rebase it? I finally found the time to work on it, sorry for the delay

In D30238#689919, @grembo wrote:

In D30238#679780, @garga wrote:

I won't have the time to work on it until next week, but I like the idea

Any news, anything I can do to help?

In D30694#689875, @eduardo wrote:

Should I bump PORTREVISION?

I won't have the time to work on it until next week, but I like the idea

Approved by: garga

It's missing the new port entry on net/Makefile

Also, a brief description of new port on commit log is useful. There is a script called addport designed to help us when adding new ports:

It's missing new port entry on net/Makefile

I've edited summary because PR: field must contain only PR number instead of full URL. Please adjust that on commit message

Changes look good to me, but ports repository is being converted to git right now. Lets wait the new repository to be open for commits and then you can update the patch using git.

In D29311#656458, @eduardo wrote:

In D29311#656328, @garga wrote:

PR line on commit log must contain only PR number instead of full URL. While touching it please add missed newline chars

Looks like some kind of review interface bug, I was forced to remove "-" from first list of port changes.

PR line on commit log must contain only PR number instead of full URL. While touching it please add missed newline chars

You don't need to mention the TODO on commit message. Other than that it looks fine

@dbaio feel free to take the maintainership if you want since I'm not using po4a anymore these days

A single Approved by line is enough. And Differential Revision line ls mandatory. It would look like this:

It must follow templates format so it should have Approved by: followed by a TAB and then people that approved. Differential line should be Differential Revision: followed by a TAB and the general URL for this review, which is https://reviews.freebsd.org/D28534

Just commit D28476 before this one

Sorry about the noise and confusion, I need coffee. Just fix the date and go ahead

Just adjust the news date and it looks good