Page MenuHomeFreeBSD

graphics/glfw: update to version 3.3.3
ClosedPublic

Authored by eduardo on Mar 10 2021, 7:35 AM.

Details

Summary

graphics/glfw: update to version 3.3.3

Test Plan
$ portlint -C
looks fine

poudriere testport:

VERSION ARCH LOGS
11.4-RELEASE-p8 amd64 log
11.4-RELEASE-p8 i386 log
12.2-RELEASE-p4 amd64 log
12.2-RELEASE-p4 i386 log
14.0-CURRENT amd64 log
14.0-CURRENT i386 log

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

eduardo edited the summary of this revision. (Show Details)

revert "USE_LDCONFIG=y"es because of portlint warning, maybe it doesn,'t understand glfw pkg-plist variables(?).

lib/libglfw.so
lib/libglfw.so.%%MAJVER%%
lib/libglfw.so.%%VERSION%%

garga requested changes to this revision.Mar 10 2021, 12:29 PM
garga added inline comments.
Makefile
7 ↗(On Diff #85470)

For github downloads you should use USE_GITHUB knob

This revision now requires changes to proceed.Mar 10 2021, 12:29 PM
tobik added inline comments.
Makefile
7 ↗(On Diff #85470)

No, this is fine. This is exactly the way to go if there is a release tarball available via GitHub releases. USE_GITHUB uses git-archive(1) under the hood so is dynamically generated and then cached which is not necessarily the better option. Release assets are static and specifically created by upstream for release purposes and downstream consumption.

garga added inline comments.
Makefile
7 ↗(On Diff #85470)

cool, I never used that way before. Good to learn new things. Thanks!

This revision is now accepted and ready to land.Mar 10 2021, 3:07 PM

Never follow blindly portlint.

@eduardo before you commit, I want to see the commit message, could you update the summary accordingly?
@tobik helped in the review.

Never follow blindly portlint.

@eduardo before you commit, I want to see the commit message, could you update the summary accordingly?
@tobik helped in the review.

Yes, you are right.
Summary is updated.

This revision was automatically updated to reflect the committed changes.

Never follow blindly portlint.

@eduardo before you commit, I want to see the commit message, could you update the summary accordingly?
@tobik helped in the review.

Yes, you are right.
Summary is updated.

@eduardo

I didn't have time to give advices here , wait a bit more when we say/ask something.

In the commit message, try to explain why you did those changes and give credits to everyone involved.

That was my suggestion:

graphics/glfw: Update to 3.3.3

Project has moved to GitHub, using release tarball available
via GitHub releases.

While here, reorder Makefile.

ChangeLog: https://github.com/glfw/glfw/releases/tag/3.3.3

Reviewed by:  tobik
Approved by:  dbaio, garga (mentors)
Differential Revision: https://reviews.freebsd.org/D29179

@debaio

Sorry about my commit. Next time I will wait for permission to carry on.

dbaio (Danilo G. Baio) <phabric-noreply@freebsd.org> escreveu no dia
quinta, 11/03/2021 à(s) 11:36:

dbaio added a comment.

In D29179#653938 <https://reviews.freebsd.org/D29179#653938>, @eduardo

wrote:

> In D29179#653507 <https://reviews.freebsd.org/D29179#653507>, @dbaio

wrote:

>
>> Never follow blindly portlint.
>>
>> @eduardo  before you commit, I want to see the commit message, could

you update the summary accordingly?

>> @tobik  helped in the review.
>
> Yes, you are right.
> Summary is updated.

@eduardo

I didn't have time to give advices here , wait a bit more when we

say/ask something.

In the commit message, try to explain why you did those changes and give

credits to everyone involved.

That was my suggestion:

  graphics/glfw: Update to 3.3.3

  Project has moved to GitHub, using release tarball available
  via GitHub releases.

  While here, reorder Makefile.

  ChangeLog: https://github.com/glfw/glfw/releases/tag/3.3.3

  Reviewed by:  tobik
  Approved by:  dbaio, garga (mentors)
  Differential Revision: https://reviews.freebsd.org/D29179

REPOSITORY

rP FreeBSD ports repository

CHANGES SINCE LAST ACTION

https://reviews.freebsd.org/D29179/new/

REVISION DETAIL

https://reviews.freebsd.org/D29179

EMAIL PREFERENCES

https://reviews.freebsd.org/settings/panel/emailpreferences/

To: eduardo, dbaio, garga
Cc: tobik, mat