Page MenuHomeFreeBSD

graphics/imv: Update to 4.2.0
Needs ReviewPublic

Authored by eduardo on Wed, Mar 31, 9:14 AM.

Details

Reviewers
dbaio
garga
Summary
graphics/imv: Update to 4.2.0

ChangeLog: https://github.com/eXeC64/imv/blob/v4.2.0/CHANGELOG

Approved by:	dbaio, garga (mentors)
Differential Revision:	https://reviews.freebsd.org/D29508
Test Plan
$ portlint -C
WARN: Makefile: Consider adding support for a NLS knob to conditionally disable gettext support.

poudriere testport logs:

114amd64 11.4-RELEASE-p8 amd64
114i386 11.4-RELEASE-p8 i386
122amd64 12.2-RELEASE-p4 amd64
122i386 12.2-RELEASE-p4 i386
140amd64 14.0-CURRENT amd64
140i386 14.0-CURRENT i386

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

eduardo edited the summary of this revision. (Show Details)

Changes look good to me, but ports repository is being converted to git right now. Lets wait the new repository to be open for commits and then you can update the patch using git.

git diff:
git diff -U999999 . > imv.diff

Use _MESON_ENABLED instead of _MESON_ON/OFF

Can't use _MESON_ENABLED for windows option:
"meson.build:1:0: ERROR: Value "x11=disabled" (of type "string") for combo option "window system to use" is not one of the choices. Possible choices are (as string): "all", "wayland", "x11"."

graphics/imv/Makefile
72–85

I think you can't have two -Dwindows= args:
https://github.com/eXeC64/imv/blob/master/meson.build#L25-L38

Maybe the better approach is using OPTIONS SINGLE here.