graphics/imv: Update to 4.2.0 ChangeLog: https://github.com/eXeC64/imv/blob/v4.2.0/CHANGELOG Reviewed by: mat Approved by: dbaio, garga (mentors) Differential Revision: https://reviews.freebsd.org/D29508
- R11:82d01b1cc3d6: graphics/imv: Update to 4.2.0
Changes look good to me, but ports repository is being converted to git right now. Lets wait the new repository to be open for commits and then you can update the patch using git.
Please, convert all the *_MESON_ON/OFF into *_MESON_ENABLED. https://docs.freebsd.org/en/books/porters-handbook/makefiles/#options-meson_enabled
Can't use _MESON_ENABLED for windows option:
"meson.build:1:0: ERROR: Value "x11=disabled" (of type "string") for combo option "window system to use" is not one of the choices. Possible choices are (as string): "all", "wayland", "x11"."
I think you can't have two -Dwindows= args:
Maybe the better approach is using OPTIONS SINGLE here.
I did some tests as well:
====> Windowing system: you have to select exactly one of them WAYLAND=on: Wayland (graphics) support X11=off: X11 (graphics) support ALL=off ok
====> Windowing system: you have to select exactly one of them WAYLAND=off: Wayland (graphics) support X11=on: X11 (graphics) support ALL=off ok
====> Windowing system: you have to select exactly one of them WAYLAND=off: Wayland (graphics) support X11=off: X11 (graphics) support ALL=on ====> Running Q/A tests (stage-qa) Error: /usr/local/bin/imv-wayland is linked to /usr/local/lib/libwayland-client.so.0 from graphics/wayland but it is not declared as a dependency Warning: you need LIB_DEPENDS+=libwayland-client.so:graphics/wayland Error: /usr/local/bin/imv-wayland is linked to /usr/local/lib/libwayland-egl.so.1 from graphics/wayland but it is not declared as a dependency Warning: you need LIB_DEPENDS+=libwayland-egl.so:graphics/wayland
Final adjustments, add WAYLAND_LIB_DEPENDS to the ALL option as well.
- add missing wayland dependency to ALL "Windowing system" option
- refreshed poudriere testport logs
Thanks mat and my mentors dbaio and garga!
According to https://github.com/eXeC64/imv/blob/master/meson_options.txt,
"find_library" is deprecated: